tahoe-lafs/trac-2024-07-25
2
0
Issues 1.1k Wiki

remove misc/debian or sync it from Debian #1454

New Issue
Closed
opened 2011-07-28 23:55:19 +00:00 by zooko · 14 comments
zooko commented 2011-07-28 23:55:19 +00:00
Copy Link

Now that Debian packages Tahoe-LAFS, we should probably remove the source:misc/debian and source:misc/debian_helpers, or else make sure that the tools/scripts/config-files that Debian itself uses doesn't differ from those.

Now that Debian packages Tahoe-LAFS, we should probably remove the source:misc/debian and source:misc/debian_helpers, or else make sure that the tools/scripts/config-files that Debian itself uses doesn't differ from those.
zooko added the
packaging
minor
defect
1.8.2
 labels 2011-07-28 23:55:19 +00:00
zooko added this to the undecided milestone 2011-07-28 23:55:19 +00:00
davidsarah commented 2011-07-29 02:57:06 +00:00
Owner
Copy Link

+1 on removing these directories. I think we should do that for 1.9.

+1 on removing these directories. I think we should do that for 1.9.
davidsarah commented 2011-07-29 03:03:01 +00:00
Owner
Copy Link

Attachment rm-misc-debian-and-debian_helpers.darcs.patch (147672 bytes) added

Remove misc/debian and misc/debian_helpers, which are out-of-date relative to the official Debian packages. fixes #1454

**Attachment** rm-misc-debian-and-debian_helpers.darcs.patch (147672 bytes) added Remove misc/debian and misc/debian_helpers, which are out-of-date relative to the official Debian packages. fixes #1454
rm-misc-debian-and-debian_helpers.darcs.patch
144 KiB
tahoe-lafs modified the milestone from undecided to 1.9.0 2011-07-29 03:03:32 +00:00
warner commented 2011-07-31 19:51:24 +00:00
Copy Link

+1 for me too. It means we must shut down our .deb-producing buildbots, and devs/bleeding-edge-users can no longer get convenient debian packages of current trunk (instead they must apply the official debian .diff.gz to their source tree and build a .deb from that, and since that .diff probably clobbers a bunch of the setuptools weirdness in setup.py it may be a one-way operation).

Also it means that users of non-current debian/ubuntu OSes won't be able to get debian packages at all: the current debian diff might not work for them, and we aren't providing anything better.

But we aren't testing or maintaining this stuff, so I expect it probably doesn't work already. And I'm not using a debian box on a daily basis anymore, so it's not as important to me anyways :).

I can't tell just by looking at the patch what exactly it removes. (lsdiff or diffstat are great tools, but don't work on darcs patches). So I'll take your word that it's the equivalent of 'rm -r misc/debian misc/debian_helpers'. Also it should remove the debian portions of the Makefile (everything from line 259 to the end of the file).

It should also update docs/debian.rst: replace the instructions about building a debian package to say "get the diff from packages.debian.org and use debuild as usual". It should keep the section on the debian-package names of Tahoe's dependencies, but should no longer claim that tahoe's source tree will help you build debian packages itself.

+1 for me too. It means we must shut down our .deb-producing buildbots, and devs/bleeding-edge-users can no longer get convenient debian packages of current trunk (instead they must apply the official debian .diff.gz to their source tree and build a .deb from that, and since that .diff probably clobbers a bunch of the setuptools weirdness in setup.py it may be a one-way operation). Also it means that users of non-current debian/ubuntu OSes won't be able to get debian packages at all: the current debian diff might not work for them, and we aren't providing anything better. But we aren't testing or maintaining this stuff, so I expect it probably doesn't work already. And I'm not using a debian box on a daily basis anymore, so it's not as important to me anyways :). I can't tell just by looking at the patch what exactly it removes. (lsdiff or diffstat are great tools, but don't work on darcs patches). So I'll take your word that it's the equivalent of 'rm -r misc/debian misc/debian_helpers'. Also it should remove the debian portions of the Makefile (everything from line 259 to the end of the file). It should also update docs/debian.rst: replace the instructions about building a debian package to say "get the diff from packages.debian.org and use debuild as usual". It should keep the section on the debian-package names of Tahoe's dependencies, but should no longer claim that tahoe's source tree will help you build debian packages itself.
davidsarah commented 2011-07-31 21:12:08 +00:00
Owner
Copy Link

#1424 was a duplicate of this ticket.

Replying to warner:

+1 for me too. It means we must shut down our .deb-producing buildbots, and devs/bleeding-edge-users can no longer get convenient debian packages of current trunk (instead they must apply the official debian .diff.gz to their source tree and build a .deb from that, and since that .diff probably clobbers a bunch of the setuptools weirdness in setup.py it may be a one-way operation).

... but see #1168 for a way to stop that being one-way.

If we abandon the ability to automatically produce bleeding-edge .debs, I think that means that we could close #299, #423, #769, #1257, #1308, and #1348.

Also it means that users of non-current debian/ubuntu OSes won't be able to get debian packages at all: the current debian diff might not work for them, and we aren't providing anything better.

But we aren't testing or maintaining this stuff, so I expect it probably doesn't work already.

Right, as evidenced by the above tickets :-)

And I'm not using a debian box on a daily basis anymore, so it's not as important to me anyways :).

I can't tell just by looking at the patch what exactly it removes. (lsdiff or diffstat are great tools, but don't work on darcs patches). So I'll take your word that it's the equivalent of 'rm -r misc/debian misc/debian_helpers'.

It is.

Also it should remove the debian portions of the Makefile (everything from line 259 to the end of the file).

It should also update docs/debian.rst: replace the instructions about building a debian package to say "get the diff from packages.debian.org and use debuild as usual". It should keep the section on the debian-package names of Tahoe's dependencies, but should no longer claim that tahoe's source tree will help you build debian packages itself.

OK, I'll update it to do these things.

#1424 was a duplicate of this ticket. Replying to [warner](/tahoe-lafs/trac-2024-07-25/issues/1454#issuecomment-84536): > +1 for me too. It means we must shut down our .deb-producing buildbots, and devs/bleeding-edge-users can no longer get convenient debian packages of current trunk (instead they must apply the official debian .diff.gz to their source tree and build a .deb from that, and since that .diff probably clobbers a bunch of the setuptools weirdness in setup.py it may be a one-way operation). ... but see #1168 for a way to stop that being one-way. If we abandon the ability to automatically produce bleeding-edge .debs, I think that means that we could close #299, #423, #769, #1257, #1308, and #1348. > Also it means that users of non-current debian/ubuntu OSes won't be able to get debian packages at all: the current debian diff might not work for them, and we aren't providing anything better. > > But we aren't testing or maintaining this stuff, so I expect it probably doesn't work already. Right, as evidenced by the above tickets :-) > And I'm not using a debian box on a daily basis anymore, so it's not as important to me anyways :). > > I can't tell just by looking at the patch what exactly it removes. (lsdiff or diffstat are great tools, but don't work on darcs patches). So I'll take your word that it's the equivalent of 'rm -r misc/debian misc/debian_helpers'. It is. > Also it should remove the debian portions of the Makefile (everything from line 259 to the end of the file). > > It should also update docs/debian.rst: replace the instructions about building a debian package to say "get the diff from packages.debian.org and use debuild as usual". It should keep the section on the debian-package names of Tahoe's dependencies, but should no longer claim that tahoe's source tree will help you build debian packages itself. OK, I'll update it to do these things.
warner commented 2011-08-01 01:54:03 +00:00
Copy Link

Attachment debian.rst (2191 bytes) added

replacement docs

**Attachment** debian.rst (2191 bytes) added replacement docs
debian.rst
2.1 KiB
davidsarah commented 2011-08-01 04:22:56 +00:00
Owner
Copy Link

Attachment remove-debian-build-targets.darcs.patch (33135 bytes) added

Makefile: remove targets that used misc/debian[_helpers] which no longer exist. Also change docs/debian.rst to reflect the fact that we no longer support building .debs using those targets. refs #1454

**Attachment** remove-debian-build-targets.darcs.patch (33135 bytes) added Makefile: remove targets that used misc/debian[_helpers] which no longer exist. Also change docs/debian.rst to reflect the fact that we no longer support building .debs using those targets. refs #1454
remove-debian-build-targets.darcs.patch
32 KiB
davidsarah commented 2011-08-01 04:24:29 +00:00
Owner
Copy Link

Attachment simplify-makefile-and-setup-py.darcs.patch (28351 bytes) added

Makefile and setup.py: remove setup.py commands that we no longer need, and their uses in the Makefile. Delete a stale and incorrect comment about updating _version.py. Also fix some coding style checks in the Makefile to operate on all source files. (This isn't strictly to do with #1454, but since it also touches the Makefile I'll put it here.)

**Attachment** simplify-makefile-and-setup-py.darcs.patch (28351 bytes) added Makefile and setup.py: remove setup.py commands that we no longer need, and their uses in the Makefile. Delete a stale and incorrect comment about updating _version.py. Also fix some coding style checks in the Makefile to operate on all source files. (This isn't strictly to do with #1454, but since it also touches the Makefile I'll put it here.)
simplify-makefile-and-setup-py.darcs.patch
28 KiB
warner commented 2011-08-11 17:33:12 +00:00
Copy Link

I cannot apply the rm-misc-debian.. patch: it depends upon MDMF. Could you create an alternate form which does not?

I cannot apply the rm-misc-debian.. patch: it depends upon MDMF. Could you create an alternate form which does not?
warner commented 2011-08-11 18:39:55 +00:00
Copy Link

Nevermind.. I made a new patch for that. I'm +1 on the two debian patches, will land them now. I'm going to move the third non-debian patch out to a different ticket and review it separately.

Nevermind.. I made a new patch for that. I'm +1 on the two debian patches, will land them now. I'm going to move the third non-debian patch out to a different ticket and review it separately.
david-sarah@jacaranda.org commented 2011-08-11 18:40:24 +00:00
Owner
Copy Link

In changeset:4d58e7cef9569b12:

Makefile: remove targets that used misc/debian[_helpers] which no longer exist. Also change docs/debian.rst to reflect the fact that we no longer support building .debs using those targets. refs #1454
In changeset:4d58e7cef9569b12: ``` Makefile: remove targets that used misc/debian[_helpers] which no longer exist. Also change docs/debian.rst to reflect the fact that we no longer support building .debs using those targets. refs #1454 ```
warner@lothar.com commented 2011-08-11 18:40:24 +00:00
Owner
Copy Link

In changeset:37cd111009d0b30e:

remove misc/debian[_helpers], rely upon official packaging instead. fixes #1454
In changeset:37cd111009d0b30e: ``` remove misc/debian[_helpers], rely upon official packaging instead. fixes #1454 ```
tahoe-lafs added the
fixed
 label 2011-08-11 18:40:24 +00:00
warner@lothar.com closed this issue 2011-08-11 18:40:24 +00:00
warner commented 2011-08-11 18:43:46 +00:00
Copy Link

third patch moved to ticket #1479

third patch moved to ticket #1479
david-sarah@jacaranda.org commented 2011-08-16 22:53:44 +00:00
Owner
Copy Link

In [5181/ticket393-MDMF-2]:

Makefile: remove targets that used misc/debian[_helpers] which no longer exist. Also change docs/debian.rst to reflect the fact that we no longer support building .debs using those targets. refs #1454
In [5181/ticket393-MDMF-2]: ``` Makefile: remove targets that used misc/debian[_helpers] which no longer exist. Also change docs/debian.rst to reflect the fact that we no longer support building .debs using those targets. refs #1454 ```
warner@lothar.com commented 2011-08-16 22:53:44 +00:00
Owner
Copy Link

In [5182/ticket393-MDMF-2]:

remove misc/debian[_helpers], rely upon official packaging instead. fixes #1454
In [5182/ticket393-MDMF-2]: ``` remove misc/debian[_helpers], rely upon official packaging instead. fixes #1454 ```
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels   
0.2.0

   
0.3.0

   
0.4.0

   
0.5.0

   
0.5.1

   
0.6.0

   
0.6.1

   
0.7.0

   
0.8.0

   
0.9.0

   
1.0.0

   
1.1.0

   
1.10.0

   
1.10.1

   
1.10.2

   
1.10a2

   
1.11.0

   
1.12.0

   
1.12.1

   
1.13.0

   
1.14.0

   
1.15.0

   
1.15.1

   
1.2.0

   
1.3.0

   
1.4.1

   
1.5.0

   
1.6.0

   
1.6.1

   
1.7.0

   
1.7.1

   
1.7β

   
1.8.0

   
1.8.1

   
1.8.2

   
1.8.3

   
1.8β

   
1.9.0

   
1.9.0-s3branch

   
1.9.0a1

   
1.9.0a2

   
1.9.0b1

   
1.9.1

   
1.9.2

   
1.9.2a1

   
LeastAuthority.com automation

   
blocker

   
cannot reproduce

   
cloud-branch

   
code

catch-all for anything that can be fixed by writing code but isn't classified better

  
code-dirnodes

anything involving tahoe directories

  
code-encoding

immutable-file encoding format/layout, cap format, encoding/decoding algorithms

  
code-frontend

general frontend things: new user-facing interfaces, FTP/SFTP servers, FUSE-like interfaces

  
code-frontend-cli

CLI tools

  
code-frontend-ftp-sftp

   
code-frontend-magic-folder

   
code-frontend-web

webapi interfaces, user-facing "WUI" interfaces

  
code-mutable

anything involving mutable files: encoding/decoding, share format

  
code-network

Introducer, locating storage servers, establishing/maintaining connections to them

  
code-nodeadmin

node startup/shutdown, tools to create nodes, logging tools, management/monitoring tools, manhole, disk-space-limiting tools

  
code-peerselection

server selection/sorting algorithm, rebalancing code, allocation policy, swarming-download

  
code-storage

storage-server implementation, share-storage directory layout, client-to-server share transfer protocol

  
contrib

problems with non-core things that live in the source:contrib/ directory

  
critical

   
defect

   
dev-infrastructure

things that help us build Tahoe: buildbot, automated speed/memory/code-coverage tests and results-displayers, IRC channels, mailing lists, this Trac instance

  
documentation

docs items. Also use 'docs' keyword on tickets in more specific components.

  
duplicate

   
enhancement

   
fixed

   
invalid

   
major

   
minor

   
n/a

   
normal

   
operational

things involved in running a tahoe grid, external tools to monitor/maintain a grid (like "nodeadmin" but larger-scale). Was also used for issues with the allmydata.com grid.

  
packaging

setup.py script, library dependencies, binary packages, licensing, installation instructions

  
somebody else's problem

   
supercritical

   
task

   
trivial

   
unknown

Uncategorized. All tickets default to this component until someone updates it.

  
was already fixed

   
website

things about the tahoe-lafs.org website (and sometimes this Trac instance, shared with 'dev-infrastructure')

  
wontfix

   
worksforme
No Label
0.2.0
0.3.0
0.4.0
0.5.0
0.5.1
0.6.0
0.6.1
0.7.0
0.8.0
0.9.0
1.0.0
1.1.0
1.10.0
1.10.1
1.10.2
1.10a2
1.11.0
1.12.0
1.12.1
1.13.0
1.14.0
1.15.0
1.15.1
1.2.0
1.3.0
1.4.1
1.5.0
1.6.0
1.6.1
1.7.0
1.7.1
1.7β
1.8.0
1.8.1
1.8.2
1.8.3
1.8β
1.9.0
1.9.0-s3branch
1.9.0a1
1.9.0a2
1.9.0b1
1.9.1
1.9.2
1.9.2a1
LeastAuthority.com automation
blocker
cannot reproduce
cloud-branch
code
code-dirnodes
code-encoding
code-frontend
code-frontend-cli
code-frontend-ftp-sftp
code-frontend-magic-folder
code-frontend-web
code-mutable
code-network
code-nodeadmin
code-peerselection
code-storage
contrib
critical
defect
dev-infrastructure
documentation
duplicate
enhancement
fixed
invalid
major
minor
n/a
normal
operational
packaging
somebody else's problem
supercritical
task
trivial
unknown
was already fixed
website
wontfix
worksforme
Milestone
Clear milestone
No items
No Milestone
1.9.0
Assignees
Clear assignees
No Assignees
warner
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Reference: tahoe-lafs/trac-2024-07-25#1454
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?