Makefile/setup.py cleanups #1479

New Issue

warner · 2011-08-11T18:43:12Z

warner commented

2011-08-11 18:43:12 +00:00

Ticket #1454 had a non-debian patch in simplify-makefile-and-setup-py.darcs.patch which needs separate review.

Ticket #1454 had a non-debian patch in [simplify-makefile-and-setup-py.darcs.patch](/tahoe-lafs/trac-2024-07-25/attachments/000078ac-2613-c671-84db-c8d2d4422908) which needs separate review.

warner added the

labels 2011-08-11 18:43:12 +00:00

warner added this to the 1.9.0 milestone 2011-08-11 18:43:12 +00:00

warner commented

2011-08-11 18:52:18 +00:00

Replacing $(RUNPP) with something in our bin/tahoe loses the
ability to get a repl running without actually importing the tahoe code
(at least allmydata.scripts and that infernal *init*.py). I
don't think that's a big loss, though. I do like the removal of code
from setup.py.

Relying more heavily upon the gross 'darcsver'-prefixing in setup.cfg is
bad, since I want to get rid of setuptools and this reliance makes that
more difficult, but I don't have the energy to fight for the Makefile
any more. So I'm willing to go along with that too.

So I'm +1 on this as long as we really try to make bin/tahoe and
__init__.py and our setup.py simpler in the near future.

Replacing $(RUNPP) with something in our `bin/tahoe` loses the ability to get a repl running without actually importing the tahoe code (at least allmydata.scripts and that infernal `*init*.py`). I don't think that's a big loss, though. I *do* like the removal of code from setup.py. Relying more heavily upon the gross 'darcsver'-prefixing in setup.cfg is bad, since I want to get rid of setuptools and this reliance makes that more difficult, but I don't have the energy to fight for the Makefile any more. So I'm willing to go along with that too. So I'm +1 on this as long as we really try to make bin/tahoe and `__init__.py` and our `setup.py` simpler in the near future.

warner commented

2011-08-11 18:58:43 +00:00

Landed, in changeset:16e6bb2b738e4edc.

warner added the

fixed

label 2011-08-11 18:58:43 +00:00

warner closed this issue

2011-08-11 18:58:43 +00:00

davidsarah commented

2011-08-12 00:10:41 +00:00

Replying to warner:

Replacing $(RUNPP) with something in our bin/tahoe loses the
ability to get a repl running without actually importing the tahoe code
(at least allmydata.scripts and that infernal *init*.py).

Well, this guarantees that we do the same checks on package versions (which are necessary to detect the situation in #1258) when starting a repl as we do when running the CLI, and for the unit tests (#1296). The path setup code is so flaky that I really prefer that there is only one kind of flakiness rather than several.

Relying more heavily upon the gross 'darcsver'-prefixing in setup.cfg is
bad, since I want to get rid of setuptools and this reliance makes that
more difficult, but I don't have the energy to fight for the Makefile
any more.

When we get rid of the prefixing in setup.cfg, it'll automatically be got rid of for the Makefile targets as well.

So I'm +1 on this as long as we really try to make bin/tahoe and
*init*.py and our setup.py simpler in the near future.

Just try and stop me! ;-)

Replying to [warner](/tahoe-lafs/trac-2024-07-25/issues/1479#issuecomment-84961): > Replacing $(RUNPP) with something in our `bin/tahoe` loses the > ability to get a repl running without actually importing the tahoe code > (at least allmydata.scripts and that infernal `*init*.py`). Well, this guarantees that we do the same checks on package versions (which are necessary to detect the situation in #1258) when starting a repl as we do when running the CLI, and for the unit tests (#1296). The path setup code is so flaky that I really prefer that there is only one kind of flakiness rather than several. > Relying more heavily upon the gross 'darcsver'-prefixing in setup.cfg is > bad, since I want to get rid of setuptools and this reliance makes that > more difficult, but I don't have the energy to fight for the Makefile > any more. When we get rid of the prefixing in setup.cfg, it'll automatically be got rid of for the Makefile targets as well. > So I'm +1 on this as long as we really try to make bin/tahoe and > `*init*.py` and our `setup.py` simpler in the near future. Just try and stop me! ;-)

david-sarah@jacaranda.org commented

2011-08-26 23:05:05 +00:00

In changeset:bdca62ea02097f93:

setup.cfg: remove no-longer-supported test_mac_diskimage alias. refs #1479

In changeset:bdca62ea02097f93: ``` setup.cfg: remove no-longer-supported test_mac_diskimage alias. refs #1479 ```

davidsarah commented

2011-08-26 23:07:15 +00:00

I had deleted test_mac_diskimage from setup.py but not from setup.cfg; changeset:bdca62ea02097f93 fixes that.

Sign in to join this conversation.

No Label

LeastAuthority.com automation

code-frontend-ftp-sftp

code-frontend-magic-folder

somebody else's problem

No Milestone

No Assignees

2 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Reference: tahoe-lafs/trac-2024-07-25#1479