tahoe-lafs/web-landing-page
tahoe-lafs/web-landing-page
2
0
Fork 0
Code Issues 5 Pull Requests Actions Activity

Remove custom font-family override #23

Merged
btlogy merged 1 commits from no-font-override into main 2025-05-07 07:27:57 +00:00
Conversation 3 Commits 1 Files Changed 1 -4
hacklschorsch commented 2025-04-25 10:38:58 +00:00
Collaborator
Copy Link

Minimal-mistakes already uses sane and generally available fonts.

See https://mmistakes.github.io/minimal-mistakes/docs/stylesheets/#font-stacks on how to override font family choice with this theme if we still want to do it and https://infinnie.github.io/blog/2017/systemui.html why not to use 'system-ui' for font-family on web pages.

Minimal-mistakes already uses sane and generally available fonts. See https://mmistakes.github.io/minimal-mistakes/docs/stylesheets/#font-stacks on how to override font family choice with this theme if we still want to do it and https://infinnie.github.io/blog/2017/systemui.html why not to use 'system-ui' for font-family on web pages.
hacklschorsch added 1 commit 2025-04-25 10:38:59 +00:00
Don't override page font like this or to this font family
All checks were successful
Jekyll / jekyll (pull_request) Successful in 34s
Details
Jekyll cleanup / jekyll_cleanup (pull_request) Successful in 10s
Details
d6726651be 
See https://mmistakes.github.io/minimal-mistakes/docs/stylesheets/#font-stacks on how to override font family choice with this theme proper and https://infinnie.github.io/blog/2017/systemui.html why not to use 'system-ui' for font-family on web pages.
gitea-actions commented 2025-04-25 10:39:32 +00:00
First-time contributor
Copy Link

🔨 Docker build success

🔧 Jekyll build success

🚀 Jekyll deploy success

🔗 Preview site here

Pusher: @hacklschorsch, Action: pull_request, Workflow: Jekyll, Run: 170

#### :hammer: Docker build `success` #### :wrench: Jekyll build `success` #### :rocket: Jekyll deploy `success` #### :link: Preview site [here](https://preview.lafs.eval.latfa.net&#x2F;23&#x2F;) *Pusher: @hacklschorsch, Action: `pull_request`, Workflow: `Jekyll`, Run: 170* <!-- pr-commenter-metadata: image-success,build-success,deploy-success,pusher-hacklschorsch-pull_request-170 -->
hacklschorsch requested review from btlogy 2025-04-25 11:50:03 +00:00
btlogy commented 2025-05-02 09:00:17 +00:00
Owner
Copy Link

@hacklschorsch: I do not mind dropping this font, but it was the one used by the mockup (see #12).

@hacklschorsch: I do not mind dropping this font, but it was the one used by the mockup (see #12).
btlogy commented 2025-05-07 07:27:53 +00:00
Owner
Copy Link

As commented here, system-ui was a mistake indeed.

As commented [here](https://code.lafs.eval.latfa.net/tahoe-lafs/web-landing-page/issues/12#issuecomment-110182), `system-ui` was a mistake indeed.
btlogy merged commit 080af25223 into main 2025-05-07 07:27:57 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
btlogy
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: tahoe-lafs/web-landing-page#23
No description provided.
Delete Branch "no-font-override"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?