Rework toward the minimal mockup #12
Loading…
Reference in New Issue
Block a user
No description provided.
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
As discussed with @meejah and Tiff, we should get rid of the big pictures and the pattern.
Mostly done in #13, #14 and #15
Better images should be PR soon...
In #21, @hacklschorsch has suggested that the custom CSS might have broken the initial responsive design...
I wonder if we can review this to simplify our customization.
In #23, @hacklschorsch is proposing to avoid the
system-ui
font for good reason. But it was the one proposed by Tiff in the mockup. So should we do use the default again (it does not look that bad to me)?In the meantime, we still miss a few changes to match the mock-up:
If I am not mistaken, this is a misunderstanding -
system-ui
is an alias that stands for different fonts, depending on what OS you are using. Tiff's (possibly macOS?) screenshot is only valid for macOS - usingsystem-ui
on different OSes and browsers leads to different fonts being used.The theme we use already does that, but in a bit more sensible manner, differentiating between the defaults for serif and non-serif fonts: https://mmistakes.github.io/minimal-mistakes/docs/stylesheets/#font-stacks
I do not think there is any misunderstanding about what the
system-ui
is. But if I remember correctly, Tiff's design was explicitly using this font (in the code, not the screenshot).So as I said: we can go back to use the fonts provided by the theme if it makes sense (and I believe it does).
My comment was to remember why we have switched to
system-ui
in the first place: I was merely back-porting Tiff's choices (or more likely the defaults from Figma).I was not 100% sure that
system-ui
was comming from the mock-up. So I went back to it and it's not there!My bad thus @hacklschorsch: I've likely chosen
system-ui
myself!Here are the font I've managed to collect from the mock-up:
Montserrat
for the top logo and the buttonsOpen Sans
for the news articlesAg
for the restI'm going to merge #23 and see with @hacklschorsch if we can improve the fonts differently.