give nice error page when URL is mangled or from the future #884

New Issue

URLs from the future also give an ugly error message: * <http://testgrid.allmydata.org:3567/uri/lafs:from_the_future> Fixing this ticket would help the PREFIXED_RO_URI proposal in #833: * <http://testgrid.allmydata.org:3567/uri/imm.lafs:from_the_future>

tahoe-lafs modified the milestone from undecided to 1.6.0

2010-01-16 17:29:39 +00:00

tahoe-lafs changed title from ~~give nice error page when URL is mangled~~ to give nice error page when URL is mangled or from the future

2010-01-16 17:29:39 +00:00

zooko commented

2010-01-26 16:56:04 +00:00

With the Tahoe-LAFS -r4170:

GET unknown URI type: can only do t=info and t=json, not t=.
Using a webapi server that supports a later version of Tahoe may help.

I guess it could be prettier, but this is an improvement. :-)

With the Tahoe-LAFS -r4170: ``` GET unknown URI type: can only do t=info and t=json, not t=. Using a webapi server that supports a later version of Tahoe may help. ``` I guess it could be prettier, but this is an improvement. :-)

zooko modified the milestone from 1.6.0 to eventually

2010-01-26 16:56:04 +00:00

tahoe-lafs modified the milestone from eventually to 1.7.0

2010-02-01 19:41:24 +00:00

davidsarah commented

2010-02-02 02:46:52 +00:00

#274 was a duplicate. From the description and comments of that ticket:

[...] This case should present a friendly error message in the wui that says: "The requested link has an incorrect format. If you pasted this from the clipboard, make sure you copied the entire link without extra line breaks."

Also, the wapi should return an "invalid cap" error code, so that extensions can report to their own users the problem.
[...]
Bonus wishlist feature: Detect common cases, such as internal newlines or missing suffixes or prefixes and tell the user the specific problem.

(One such case is #885.)

For instance if there is no "URI::" string anywhere in the input, remind them that caps always include these strings. If there is such a substring, but the other fields are too short, suggest that they included whitespace (from "friendly" formatting) or chopped off the end.

#274 was a duplicate. From the description and comments of that ticket: > [...] This case should present a friendly error message in the wui that says: "The requested link has an incorrect format. If you pasted this from the clipboard, make sure you copied the entire link without extra line breaks." > Also, the wapi should return an "invalid cap" error code, so that extensions can report to their own users the problem. [...] > Bonus wishlist feature: Detect common cases, such as internal newlines or missing suffixes or prefixes and tell the user the specific problem. (One such case is #885.) > For instance if there is no "URI:<type>:" string anywhere in the input, remind them that caps always include these strings. If there *is* such a substring, but the other fields are too short, suggest that they included whitespace (from "friendly" formatting) or chopped off the end.

davidsarah commented

2010-02-09 04:29:02 +00:00

Also, if a path goes through an unknown node, the error is "Sorry, but I couldn't find the object you requested.", which is not as helpful as it could be:

http://testgrid.allmydata.org:3567/uri/URI:DIR2:bntvvn2bf37vwmrd3ttbygt4s4:qymwa2lcvhjvi3hnamxew6ywro5jmj7zfnspmrpqv3n7faibprlq/immutable-future-file/foo

It should say that a later Tahoe version is needed to read children of 'immutable-future-file'.

Also, if a path goes through an unknown node, the error is "Sorry, but I couldn't find the object you requested.", which is not as helpful as it could be: <http://testgrid.allmydata.org:3567/uri/URI:DIR2:bntvvn2bf37vwmrd3ttbygt4s4:qymwa2lcvhjvi3hnamxew6ywro5jmj7zfnspmrpqv3n7faibprlq/immutable-future-file/foo> It should say that a later Tahoe version is needed to read children of 'immutable-future-file'.

tahoe-lafs modified the milestone from 1.7.0 to 1.6.1

2010-02-15 19:42:56 +00:00

zooko commented

2010-02-16 05:30:47 +00:00

Bumping this out of v1.6.1 just to prioritize the other tickets left in v1.6.1.

zooko modified the milestone from 1.6.1 to 1.7.0

2010-02-16 05:30:47 +00:00

tahoe-lafs added the

code-frontend-web

label 2010-03-12 04:12:07 +00:00

tahoe-lafs modified the milestone from 1.7.0 to 1.7.1

2010-06-12 20:58:08 +00:00

tahoe-lafs modified the milestone from 1.7.1 to 1.8β

2010-07-17 03:54:50 +00:00

tahoe-lafs modified the milestone from 1.8β to 1.9.0

2010-09-10 21:02:06 +00:00

tahoe-lafs modified the milestone from 1.9.0 to 1.10.0

2011-08-14 01:12:46 +00:00

davidsarah commented

2011-12-31 06:20:49 +00:00

#1650 was a duplicate of the case in comment:74371. I really, really want to get this fixed for 1.10.

#1650 was a duplicate of the case in [comment:74371](/tahoe-lafs/trac-2024-07-25/issues/884#issuecomment-74371). I really, really want to get this fixed for 1.10.

Sign in to join this conversation.