Improve step error conditions

Signed-off-by: Benoit Donneaux <benoit@leastauthority.com>
This commit is contained in:
bEn 2024-05-24 12:53:27 +02:00
parent d2c7588767
commit daf2ed5190
1 changed files with 1 additions and 9 deletions

View File

@ -52,7 +52,6 @@ jobs:
fi fi
docker-compose run --rm -v "${JOB_CONTAINER_NAME}:/site" -w /site \ docker-compose run --rm -v "${JOB_CONTAINER_NAME}:/site" -w /site \
jekyll build --verbose jekyll build --verbose
continue-on-error: true
- name: Deploy Jekyll site - name: Deploy Jekyll site
id: deploy_site id: deploy_site
run: | run: |
@ -75,10 +74,9 @@ jobs:
rsync -halvi --delete \ rsync -halvi --delete \
-e "ssh -a -x -o StrictHostKeyChecking=no" \ -e "ssh -a -x -o StrictHostKeyChecking=no" \
./_site/ "${WEB_USER}@${WEB_DOMAIN}:${WEB_ROOT}${WEB_CONTEXT}" ./_site/ "${WEB_USER}@${WEB_DOMAIN}:${WEB_ROOT}${WEB_CONTEXT}"
continue-on-error: true
- name: Comment pull request - name: Comment pull request
id: comment_pull_request id: comment_pull_request
if: gitea.event_name == 'pull_request' if: ${{ always() && gitea.event_name == 'pull_request' }}
uses: exercism/pr-commenter-action@v1.5.1 uses: exercism/pr-commenter-action@v1.5.1
with: with:
template-variables: | template-variables: |
@ -96,9 +94,3 @@ jobs:
"gitRunAttempt": "${{ gitea.run_attempt }}" "gitRunAttempt": "${{ gitea.run_attempt }}"
} }
config-file: ".gitea/pr-commenter.yml" config-file: ".gitea/pr-commenter.yml"
- name: Fail on error
id: fail-on-error
if: |
steps.build_site.outcome != 'success'
|| steps.deploy_site.outcome != 'success'
run: exit 1