From daf2ed519032652fb9cad457f531c7dcc4c00209 Mon Sep 17 00:00:00 2001
From: Benoit Donneaux <benoit@leastauthority.com>
Date: Fri, 24 May 2024 12:53:27 +0200
Subject: [PATCH] Improve step error conditions

Signed-off-by: Benoit Donneaux <benoit@leastauthority.com>
---
 .gitea/workflows/jekyll.yaml | 10 +---------
 1 file changed, 1 insertion(+), 9 deletions(-)

diff --git a/.gitea/workflows/jekyll.yaml b/.gitea/workflows/jekyll.yaml
index 80fcd74..fa4111f 100644
--- a/.gitea/workflows/jekyll.yaml
+++ b/.gitea/workflows/jekyll.yaml
@@ -52,7 +52,6 @@ jobs:
           fi
           docker-compose run --rm -v "${JOB_CONTAINER_NAME}:/site" -w /site \
           jekyll build --verbose
-        continue-on-error: true
       - name: Deploy Jekyll site
         id: deploy_site
         run: |
@@ -75,10 +74,9 @@ jobs:
           rsync -halvi --delete \
             -e "ssh -a -x -o StrictHostKeyChecking=no" \
             ./_site/ "${WEB_USER}@${WEB_DOMAIN}:${WEB_ROOT}${WEB_CONTEXT}"
-        continue-on-error: true
       - name: Comment pull request
         id: comment_pull_request
-        if: gitea.event_name == 'pull_request'
+        if: ${{ always() && gitea.event_name == 'pull_request' }}
         uses: exercism/pr-commenter-action@v1.5.1
         with:
           template-variables: |
@@ -96,9 +94,3 @@ jobs:
               "gitRunAttempt": "${{ gitea.run_attempt }}"
             }
           config-file: ".gitea/pr-commenter.yml"
-      - name: Fail on error
-        id: fail-on-error
-        if: |
-          steps.build_site.outcome != 'success'
-          || steps.deploy_site.outcome != 'success'
-        run: exit 1