FTP frontend: Improve message if Twisted is unpatched #926

New Issue

Hm, we don't like to use assert for flow control. For one thing, assertions are not checked if the PYTHONOPTIMIZE env var is set or if -O is passed to the Python command-line. So for future reference, checks like this should be done with normal old if statements instead of assertions.

But, I'm going to apply this patch, which is just about making the error message more useful.

Thanks!

fixed by changeset:4a4305e7e6514dcf

Hm, we don't like to use assert for flow control. For one thing, assertions are not checked if the `PYTHONOPTIMIZE` env var is set or if `-O` is passed to the Python command-line. So for future reference, checks like this should be done with normal old `if` statements instead of assertions. But, I'm going to apply this patch, which is just about making the error message more useful. Thanks! fixed by changeset:4a4305e7e6514dcf

zooko added the

fixed

label 2010-01-26 14:54:35 +00:00

zooko modified the milestone from undecided to 1.6.0

2010-01-26 14:54:35 +00:00

zooko closed this issue

2010-01-26 14:54:35 +00:00

davidsarah commented

2010-01-27 02:08:18 +00:00

Attachment if-instead-of-assert-darcspatch.txt (42188 bytes) added

Use if instead of assert to check for twisted ftp patch

**Attachment** if-instead-of-assert-darcspatch.txt (42188 bytes) added Use if instead of assert to check for twisted ftp patch

if-instead-of-assert-darcspatch.txt

41 KiB

davidsarah commented

2010-01-27 02:09:06 +00:00

Replying to zooko:

Hm, we don't like to use assert for flow control.

I agree, patch attached.

Replying to [zooko](/tahoe-lafs/trac-2024-07-25/issues/926#issuecomment-74982): > Hm, we don't like to use assert for flow control. I agree, patch attached.

zooko commented

2010-02-01 05:12:18 +00:00

applied David-Sarah's patch in changeset:100548257add900d; Thanks!

Sign in to join this conversation.