Make all test_runner tests work on cygwin #908

New Issue

tahoe-lafs · 2010-01-16T20:31:56Z

davidsarah commented

2010-01-16 20:31:56 +00:00

source:src/allmydata/test/test_runner.py skips some tests due to this code:

if "cygwin" in sys.platform.lower():
    raise unittest.SkipTest("We don't know how to make this test work on cygwin: spawnProcess seems to hang forever. We don't know if 'bin/tahoe start' can be run on cygwin.")

source:src/allmydata/test/test_runner.py skips some tests due to this code: ``` if "cygwin" in sys.platform.lower(): raise unittest.SkipTest("We don't know how to make this test work on cygwin: spawnProcess seems to hang forever. We don't know if 'bin/tahoe start' can be run on cygwin.") ```

tahoe-lafs added the

labels 2010-01-16 20:31:56 +00:00

tahoe-lafs added this to the undecided milestone 2010-01-16 20:31:56 +00:00

davidsarah commented

2010-01-16 20:36:11 +00:00

I strongly suspect that this code:

if sys.platform == "win32":
    bintahoe += ".exe"

should also apply to cygwin (which, like native Windows, uses an .exe filetype for executables). That might not be the only problem.

I strongly suspect that this code: ``` if sys.platform == "win32": bintahoe += ".exe" ``` should also apply to cygwin (which, like native Windows, uses an .exe filetype for executables). That might not be the only problem.

tahoe-lafs modified the milestone from undecided to 1.7.0

2010-02-01 19:47:31 +00:00

zooko commented

2010-02-27 18:20:38 +00:00

We need a cygwin buildslave! We had one, but it was powered off when allmydata.com moved out of their office at 555 De Haro Street. I suspect that the machine is now in Brian's closet waiting patiently for a "Set Up Tahoe-LAFS Buildslave Machines" party.

zooko commented

2010-05-08 19:20:44 +00:00

Marking this as Milestone="eventually". This ticket will be revived come the day that someone contributes a cygwin buildslave.

zooko modified the milestone from 1.7.0 to eventually

2010-05-08 19:20:44 +00:00

davidsarah commented

2010-07-15 00:43:22 +00:00

Replying to davidsarah:

I strongly suspect that this code:
if sys.platform == "win32":
    bintahoe += ".exe"
should also apply to cygwin (which, like native Windows, uses an .exe filetype for executables).

This is incorrect; the cygwin bin/tahoe script has no extension. (It is a script with a Python shebang header, not a Windows executable.)

Replying to [davidsarah](/tahoe-lafs/trac-2024-07-25/issues/908#issuecomment-74737): > I strongly suspect that this code: > ``` > if sys.platform == "win32": > bintahoe += ".exe" > ``` > should also apply to cygwin (which, like native Windows, uses an .exe filetype for executables). This is incorrect; the cygwin `bin/tahoe` script has no extension. (It is a script with a Python shebang header, not a Windows executable.)

davidsarah commented

2010-07-15 02:49:10 +00:00

See also #1119 (make cygwin a supported platform).

davidsarah commented

2011-01-22 07:37:02 +00:00

This might have been fixed by [4964/trunk/#file6], which made the runner tests use subprocess.Popen instead of (indirectly) Twisted's reactor.spawnProcess.

This might have been fixed by [4964/trunk/#file6], which made the runner tests use `subprocess.Popen` instead of (indirectly) Twisted's `reactor.spawnProcess`.

davidsarah commented

2012-03-29 23:14:36 +00:00

Replying to davidsarah:

This might have been fixed by [4964/trunk/#file6], which made the runner tests use subprocess.Popen instead of (indirectly) Twisted's reactor.spawnProcess.

Assigning to me to check whether that fixed it.

Replying to [davidsarah](/tahoe-lafs/trac-2024-07-25/issues/908#issuecomment-74744): > This might have been fixed by [4964/trunk/#file6], which made the runner tests use `subprocess.Popen` instead of (indirectly) Twisted's `reactor.spawnProcess`. Assigning to me to check whether that fixed it.

exarkun commented

2020-01-16 20:07:05 +00:00

There does not appear to be sufficient interest in cygwin to warrant keeping this open.

exarkun added the

wontfix

label 2020-01-16 20:07:05 +00:00

exarkun closed this issue

2020-01-16 20:07:05 +00:00

Sign in to join this conversation.