tahoe-lafs
/
trac-2024-07-25
2
0
Issues 1.1k Wiki

tahoe backup loops on recursive links #850

New Issue
Closed
opened 2009-12-06 13:20:18 +00:00 by francois · 7 comments
francois commented 2009-12-06 13:20:18 +00:00
Owner
Copy Link
francois@korn:~$ mkdir /tmp/test-backup/
francois@korn:~$ ln -s . /tmp/test-backup/test
francois@korn:~$ tahoe backup -v /tmp/test-backup tahoe:tmp
/usr/lib/pymodules/python2.6/foolscap/banana.py:2: [DeprecationWarning](wiki/DeprecationWarning): the sets module is deprecated
> import struct, sets, time
processing /tmp/test-backup, olddircap None
processing /tmp/test-backup/test, olddircap None
processing /tmp/test-backup/test/test, olddircap None
processing /tmp/test-backup/test/test/test, olddircap None
processing /tmp/test-backup/test/test/test/test, olddircap None
processing /tmp/test-backup/test/test/test/test/test, olddircap None
processing /tmp/test-backup/test/test/test/test/test/test, olddircap None
processing /tmp/test-backup/test/test/test/test/test/test/test, olddircap None
processing /tmp/test-backup/test/test/test/test/test/test/test/test, olddircap None
processing /tmp/test-backup/test/test/test/test/test/test/test/test/test, olddircap None
processing /tmp/test-backup/test/test/test/test/test/test/test/test/test/test, olddircap None
processing /tmp/test-backup/test/test/test/test/test/test/test/test/test/test/test, olddircap None
processing /tmp/test-backup/test/test/test/test/test/test/test/test/test/test/test/test, olddircap None
processing /tmp/test-backup/test/test/test/test/test/test/test/test/test/test/test/test/test, olddircap None
processing /tmp/test-backup/test/test/test/test/test/test/test/test/test/test/test/test/test/test, olddircap None
processing /tmp/test-backup/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test, olddircap None
processing /tmp/test-backup/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test, olddircap None
processing /tmp/test-backup/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test, olddircap None
processing /tmp/test-backup/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test, olddircap None
processing /tmp/test-backup/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test, olddircap None
processing /tmp/test-backup/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test, olddircap None
processing /tmp/test-backup/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test, olddircap None
processing /tmp/test-backup/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test, olddircap None
processing /tmp/test-backup/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test, olddircap None
processing /tmp/test-backup/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test, olddircap None
processing /tmp/test-backup/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test, olddircap None
processing /tmp/test-backup/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test, olddircap None
processing /tmp/test-backup/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test, olddircap None
processing /tmp/test-backup/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test, olddircap None
processing /tmp/test-backup/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test, olddircap None
processing /tmp/test-backup/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test, olddircap None
processing /tmp/test-backup/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test, olddircap None
processing /tmp/test-backup/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test, olddircap None
processing /tmp/test-backup/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test, olddircap None
processing /tmp/test-backup/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test, olddircap None
processing /tmp/test-backup/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test, olddircap None
processing /tmp/test-backup/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test, olddircap None
processing /tmp/test-backup/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test, olddircap None
processing /tmp/test-backup/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test, olddircap None
processing /tmp/test-backup/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test, olddircap None
processing /tmp/test-backup/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test, olddircap None
Traceback (most recent call last):
> File "/usr/bin/tahoe", line 8, in <module>
    load_entry_point('allmydata-tahoe==1.5.0', 'console_scripts', 'tahoe')()
> File "/usr/lib/pymodules/python2.6/allmydata/scripts/runner.py", line 91, in run
    rc = runner(sys.argv[1:])
> File "/usr/lib/pymodules/python2.6/allmydata/scripts/runner.py", line 78, in runner
    rc = cli.dispatchcommand(so)
> File "/usr/lib/pymodules/python2.6/allmydata/scripts/cli.py", line 456, in backup
    rc = tahoe_backup.backup(options)
> File "/usr/lib/pymodules/python2.6/allmydata/scripts/tahoe_backup.py", line 370, in backup
    return bu.run()
> File "/usr/lib/pymodules/python2.6/allmydata/scripts/tahoe_backup.py", line 212, in run
    new_backup_dircap = self.process(options.from_dir, latest_backup_dircap)
> File "/usr/lib/pymodules/python2.6/allmydata/scripts/tahoe_backup.py", line 262, in process
    newchilddircap = self.process(childpath, oldchildcap)
> File "/usr/lib/pymodules/python2.6/allmydata/scripts/tahoe_backup.py", line 262, in process
    newchilddircap = self.process(childpath, oldchildcap)
> File "/usr/lib/pymodules/python2.6/allmydata/scripts/tahoe_backup.py", line 262, in process
    newchilddircap = self.process(childpath, oldchildcap)
> File "/usr/lib/pymodules/python2.6/allmydata/scripts/tahoe_backup.py", line 262, in process
    newchilddircap = self.process(childpath, oldchildcap)
> File "/usr/lib/pymodules/python2.6/allmydata/scripts/tahoe_backup.py", line 262, in process
    newchilddircap = self.process(childpath, oldchildcap)
> File "/usr/lib/pymodules/python2.6/allmydata/scripts/tahoe_backup.py", line 262, in process
    newchilddircap = self.process(childpath, oldchildcap)
> File "/usr/lib/pymodules/python2.6/allmydata/scripts/tahoe_backup.py", line 262, in process
    newchilddircap = self.process(childpath, oldchildcap)
> File "/usr/lib/pymodules/python2.6/allmydata/scripts/tahoe_backup.py", line 262, in process
    newchilddircap = self.process(childpath, oldchildcap)
> File "/usr/lib/pymodules/python2.6/allmydata/scripts/tahoe_backup.py", line 262, in process
    newchilddircap = self.process(childpath, oldchildcap)
> File "/usr/lib/pymodules/python2.6/allmydata/scripts/tahoe_backup.py", line 262, in process
    newchilddircap = self.process(childpath, oldchildcap)
> File "/usr/lib/pymodules/python2.6/allmydata/scripts/tahoe_backup.py", line 262, in process
    newchilddircap = self.process(childpath, oldchildcap)
> File "/usr/lib/pymodules/python2.6/allmydata/scripts/tahoe_backup.py", line 262, in process
    newchilddircap = self.process(childpath, oldchildcap)
> File "/usr/lib/pymodules/python2.6/allmydata/scripts/tahoe_backup.py", line 262, in process
    newchilddircap = self.process(childpath, oldchildcap)
> File "/usr/lib/pymodules/python2.6/allmydata/scripts/tahoe_backup.py", line 262, in process
    newchilddircap = self.process(childpath, oldchildcap)
> File "/usr/lib/pymodules/python2.6/allmydata/scripts/tahoe_backup.py", line 262, in process
    newchilddircap = self.process(childpath, oldchildcap)
> File "/usr/lib/pymodules/python2.6/allmydata/scripts/tahoe_backup.py", line 262, in process
    newchilddircap = self.process(childpath, oldchildcap)
> File "/usr/lib/pymodules/python2.6/allmydata/scripts/tahoe_backup.py", line 262, in process
    newchilddircap = self.process(childpath, oldchildcap)
> File "/usr/lib/pymodules/python2.6/allmydata/scripts/tahoe_backup.py", line 262, in process
    newchilddircap = self.process(childpath, oldchildcap)
> File "/usr/lib/pymodules/python2.6/allmydata/scripts/tahoe_backup.py", line 262, in process
    newchilddircap = self.process(childpath, oldchildcap)
> File "/usr/lib/pymodules/python2.6/allmydata/scripts/tahoe_backup.py", line 262, in process
    newchilddircap = self.process(childpath, oldchildcap)
> File "/usr/lib/pymodules/python2.6/allmydata/scripts/tahoe_backup.py", line 262, in process
    newchilddircap = self.process(childpath, oldchildcap)
> File "/usr/lib/pymodules/python2.6/allmydata/scripts/tahoe_backup.py", line 262, in process
    newchilddircap = self.process(childpath, oldchildcap)
> File "/usr/lib/pymodules/python2.6/allmydata/scripts/tahoe_backup.py", line 262, in process
    newchilddircap = self.process(childpath, oldchildcap)
> File "/usr/lib/pymodules/python2.6/allmydata/scripts/tahoe_backup.py", line 262, in process
    newchilddircap = self.process(childpath, oldchildcap)
> File "/usr/lib/pymodules/python2.6/allmydata/scripts/tahoe_backup.py", line 262, in process
    newchilddircap = self.process(childpath, oldchildcap)
> File "/usr/lib/pymodules/python2.6/allmydata/scripts/tahoe_backup.py", line 262, in process
    newchilddircap = self.process(childpath, oldchildcap)
> File "/usr/lib/pymodules/python2.6/allmydata/scripts/tahoe_backup.py", line 262, in process
    newchilddircap = self.process(childpath, oldchildcap)
> File "/usr/lib/pymodules/python2.6/allmydata/scripts/tahoe_backup.py", line 262, in process
    newchilddircap = self.process(childpath, oldchildcap)
> File "/usr/lib/pymodules/python2.6/allmydata/scripts/tahoe_backup.py", line 262, in process
    newchilddircap = self.process(childpath, oldchildcap)
> File "/usr/lib/pymodules/python2.6/allmydata/scripts/tahoe_backup.py", line 262, in process
    newchilddircap = self.process(childpath, oldchildcap)
> File "/usr/lib/pymodules/python2.6/allmydata/scripts/tahoe_backup.py", line 262, in process
    newchilddircap = self.process(childpath, oldchildcap)
> File "/usr/lib/pymodules/python2.6/allmydata/scripts/tahoe_backup.py", line 262, in process
    newchilddircap = self.process(childpath, oldchildcap)
> File "/usr/lib/pymodules/python2.6/allmydata/scripts/tahoe_backup.py", line 262, in process
    newchilddircap = self.process(childpath, oldchildcap)
> File "/usr/lib/pymodules/python2.6/allmydata/scripts/tahoe_backup.py", line 262, in process
    newchilddircap = self.process(childpath, oldchildcap)
> File "/usr/lib/pymodules/python2.6/allmydata/scripts/tahoe_backup.py", line 262, in process
    newchilddircap = self.process(childpath, oldchildcap)
> File "/usr/lib/pymodules/python2.6/allmydata/scripts/tahoe_backup.py", line 262, in process
    newchilddircap = self.process(childpath, oldchildcap)
> File "/usr/lib/pymodules/python2.6/allmydata/scripts/tahoe_backup.py", line 262, in process
    newchilddircap = self.process(childpath, oldchildcap)
> File "/usr/lib/pymodules/python2.6/allmydata/scripts/tahoe_backup.py", line 262, in process
    newchilddircap = self.process(childpath, oldchildcap)
> File "/usr/lib/pymodules/python2.6/allmydata/scripts/tahoe_backup.py", line 262, in process
    newchilddircap = self.process(childpath, oldchildcap)
> File "/usr/lib/pymodules/python2.6/allmydata/scripts/tahoe_backup.py", line 262, in process
    newchilddircap = self.process(childpath, oldchildcap)
> File "/usr/lib/pymodules/python2.6/allmydata/scripts/tahoe_backup.py", line 268, in process
    raise [BackupProcessingError](wiki/BackupProcessingError)("Cannot backup this file %r" % childpath)
allmydata.scripts.tahoe_backup.BackupProcessingError: Cannot backup this file '/tmp/test-backup/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test'
francois@korn:~$
``` francois@korn:~$ mkdir /tmp/test-backup/ francois@korn:~$ ln -s . /tmp/test-backup/test francois@korn:~$ tahoe backup -v /tmp/test-backup tahoe:tmp /usr/lib/pymodules/python2.6/foolscap/banana.py:2: [DeprecationWarning](wiki/DeprecationWarning): the sets module is deprecated > import struct, sets, time processing /tmp/test-backup, olddircap None processing /tmp/test-backup/test, olddircap None processing /tmp/test-backup/test/test, olddircap None processing /tmp/test-backup/test/test/test, olddircap None processing /tmp/test-backup/test/test/test/test, olddircap None processing /tmp/test-backup/test/test/test/test/test, olddircap None processing /tmp/test-backup/test/test/test/test/test/test, olddircap None processing /tmp/test-backup/test/test/test/test/test/test/test, olddircap None processing /tmp/test-backup/test/test/test/test/test/test/test/test, olddircap None processing /tmp/test-backup/test/test/test/test/test/test/test/test/test, olddircap None processing /tmp/test-backup/test/test/test/test/test/test/test/test/test/test, olddircap None processing /tmp/test-backup/test/test/test/test/test/test/test/test/test/test/test, olddircap None processing /tmp/test-backup/test/test/test/test/test/test/test/test/test/test/test/test, olddircap None processing /tmp/test-backup/test/test/test/test/test/test/test/test/test/test/test/test/test, olddircap None processing /tmp/test-backup/test/test/test/test/test/test/test/test/test/test/test/test/test/test, olddircap None processing /tmp/test-backup/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test, olddircap None processing /tmp/test-backup/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test, olddircap None processing /tmp/test-backup/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test, olddircap None processing /tmp/test-backup/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test, olddircap None processing /tmp/test-backup/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test, olddircap None processing /tmp/test-backup/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test, olddircap None processing /tmp/test-backup/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test, olddircap None processing /tmp/test-backup/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test, olddircap None processing /tmp/test-backup/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test, olddircap None processing /tmp/test-backup/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test, olddircap None processing /tmp/test-backup/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test, olddircap None processing /tmp/test-backup/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test, olddircap None processing /tmp/test-backup/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test, olddircap None processing /tmp/test-backup/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test, olddircap None processing /tmp/test-backup/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test, olddircap None processing /tmp/test-backup/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test, olddircap None processing /tmp/test-backup/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test, olddircap None processing /tmp/test-backup/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test, olddircap None processing /tmp/test-backup/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test, olddircap None processing /tmp/test-backup/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test, olddircap None processing /tmp/test-backup/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test, olddircap None processing /tmp/test-backup/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test, olddircap None processing /tmp/test-backup/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test, olddircap None processing /tmp/test-backup/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test, olddircap None processing /tmp/test-backup/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test, olddircap None processing /tmp/test-backup/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test, olddircap None Traceback (most recent call last): > File "/usr/bin/tahoe", line 8, in <module> load_entry_point('allmydata-tahoe==1.5.0', 'console_scripts', 'tahoe')() > File "/usr/lib/pymodules/python2.6/allmydata/scripts/runner.py", line 91, in run rc = runner(sys.argv[1:]) > File "/usr/lib/pymodules/python2.6/allmydata/scripts/runner.py", line 78, in runner rc = cli.dispatchcommand(so) > File "/usr/lib/pymodules/python2.6/allmydata/scripts/cli.py", line 456, in backup rc = tahoe_backup.backup(options) > File "/usr/lib/pymodules/python2.6/allmydata/scripts/tahoe_backup.py", line 370, in backup return bu.run() > File "/usr/lib/pymodules/python2.6/allmydata/scripts/tahoe_backup.py", line 212, in run new_backup_dircap = self.process(options.from_dir, latest_backup_dircap) > File "/usr/lib/pymodules/python2.6/allmydata/scripts/tahoe_backup.py", line 262, in process newchilddircap = self.process(childpath, oldchildcap) > File "/usr/lib/pymodules/python2.6/allmydata/scripts/tahoe_backup.py", line 262, in process newchilddircap = self.process(childpath, oldchildcap) > File "/usr/lib/pymodules/python2.6/allmydata/scripts/tahoe_backup.py", line 262, in process newchilddircap = self.process(childpath, oldchildcap) > File "/usr/lib/pymodules/python2.6/allmydata/scripts/tahoe_backup.py", line 262, in process newchilddircap = self.process(childpath, oldchildcap) > File "/usr/lib/pymodules/python2.6/allmydata/scripts/tahoe_backup.py", line 262, in process newchilddircap = self.process(childpath, oldchildcap) > File "/usr/lib/pymodules/python2.6/allmydata/scripts/tahoe_backup.py", line 262, in process newchilddircap = self.process(childpath, oldchildcap) > File "/usr/lib/pymodules/python2.6/allmydata/scripts/tahoe_backup.py", line 262, in process newchilddircap = self.process(childpath, oldchildcap) > File "/usr/lib/pymodules/python2.6/allmydata/scripts/tahoe_backup.py", line 262, in process newchilddircap = self.process(childpath, oldchildcap) > File "/usr/lib/pymodules/python2.6/allmydata/scripts/tahoe_backup.py", line 262, in process newchilddircap = self.process(childpath, oldchildcap) > File "/usr/lib/pymodules/python2.6/allmydata/scripts/tahoe_backup.py", line 262, in process newchilddircap = self.process(childpath, oldchildcap) > File "/usr/lib/pymodules/python2.6/allmydata/scripts/tahoe_backup.py", line 262, in process newchilddircap = self.process(childpath, oldchildcap) > File "/usr/lib/pymodules/python2.6/allmydata/scripts/tahoe_backup.py", line 262, in process newchilddircap = self.process(childpath, oldchildcap) > File "/usr/lib/pymodules/python2.6/allmydata/scripts/tahoe_backup.py", line 262, in process newchilddircap = self.process(childpath, oldchildcap) > File "/usr/lib/pymodules/python2.6/allmydata/scripts/tahoe_backup.py", line 262, in process newchilddircap = self.process(childpath, oldchildcap) > File "/usr/lib/pymodules/python2.6/allmydata/scripts/tahoe_backup.py", line 262, in process newchilddircap = self.process(childpath, oldchildcap) > File "/usr/lib/pymodules/python2.6/allmydata/scripts/tahoe_backup.py", line 262, in process newchilddircap = self.process(childpath, oldchildcap) > File "/usr/lib/pymodules/python2.6/allmydata/scripts/tahoe_backup.py", line 262, in process newchilddircap = self.process(childpath, oldchildcap) > File "/usr/lib/pymodules/python2.6/allmydata/scripts/tahoe_backup.py", line 262, in process newchilddircap = self.process(childpath, oldchildcap) > File "/usr/lib/pymodules/python2.6/allmydata/scripts/tahoe_backup.py", line 262, in process newchilddircap = self.process(childpath, oldchildcap) > File "/usr/lib/pymodules/python2.6/allmydata/scripts/tahoe_backup.py", line 262, in process newchilddircap = self.process(childpath, oldchildcap) > File "/usr/lib/pymodules/python2.6/allmydata/scripts/tahoe_backup.py", line 262, in process newchilddircap = self.process(childpath, oldchildcap) > File "/usr/lib/pymodules/python2.6/allmydata/scripts/tahoe_backup.py", line 262, in process newchilddircap = self.process(childpath, oldchildcap) > File "/usr/lib/pymodules/python2.6/allmydata/scripts/tahoe_backup.py", line 262, in process newchilddircap = self.process(childpath, oldchildcap) > File "/usr/lib/pymodules/python2.6/allmydata/scripts/tahoe_backup.py", line 262, in process newchilddircap = self.process(childpath, oldchildcap) > File "/usr/lib/pymodules/python2.6/allmydata/scripts/tahoe_backup.py", line 262, in process newchilddircap = self.process(childpath, oldchildcap) > File "/usr/lib/pymodules/python2.6/allmydata/scripts/tahoe_backup.py", line 262, in process newchilddircap = self.process(childpath, oldchildcap) > File "/usr/lib/pymodules/python2.6/allmydata/scripts/tahoe_backup.py", line 262, in process newchilddircap = self.process(childpath, oldchildcap) > File "/usr/lib/pymodules/python2.6/allmydata/scripts/tahoe_backup.py", line 262, in process newchilddircap = self.process(childpath, oldchildcap) > File "/usr/lib/pymodules/python2.6/allmydata/scripts/tahoe_backup.py", line 262, in process newchilddircap = self.process(childpath, oldchildcap) > File "/usr/lib/pymodules/python2.6/allmydata/scripts/tahoe_backup.py", line 262, in process newchilddircap = self.process(childpath, oldchildcap) > File "/usr/lib/pymodules/python2.6/allmydata/scripts/tahoe_backup.py", line 262, in process newchilddircap = self.process(childpath, oldchildcap) > File "/usr/lib/pymodules/python2.6/allmydata/scripts/tahoe_backup.py", line 262, in process newchilddircap = self.process(childpath, oldchildcap) > File "/usr/lib/pymodules/python2.6/allmydata/scripts/tahoe_backup.py", line 262, in process newchilddircap = self.process(childpath, oldchildcap) > File "/usr/lib/pymodules/python2.6/allmydata/scripts/tahoe_backup.py", line 262, in process newchilddircap = self.process(childpath, oldchildcap) > File "/usr/lib/pymodules/python2.6/allmydata/scripts/tahoe_backup.py", line 262, in process newchilddircap = self.process(childpath, oldchildcap) > File "/usr/lib/pymodules/python2.6/allmydata/scripts/tahoe_backup.py", line 262, in process newchilddircap = self.process(childpath, oldchildcap) > File "/usr/lib/pymodules/python2.6/allmydata/scripts/tahoe_backup.py", line 262, in process newchilddircap = self.process(childpath, oldchildcap) > File "/usr/lib/pymodules/python2.6/allmydata/scripts/tahoe_backup.py", line 262, in process newchilddircap = self.process(childpath, oldchildcap) > File "/usr/lib/pymodules/python2.6/allmydata/scripts/tahoe_backup.py", line 262, in process newchilddircap = self.process(childpath, oldchildcap) > File "/usr/lib/pymodules/python2.6/allmydata/scripts/tahoe_backup.py", line 262, in process newchilddircap = self.process(childpath, oldchildcap) > File "/usr/lib/pymodules/python2.6/allmydata/scripts/tahoe_backup.py", line 268, in process raise [BackupProcessingError](wiki/BackupProcessingError)("Cannot backup this file %r" % childpath) allmydata.scripts.tahoe_backup.BackupProcessingError: Cannot backup this file '/tmp/test-backup/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test/test' francois@korn:~$ ```
tahoe-lafs added the
code-frontend-cli
major
defect
1.5.0
 labels 2009-12-06 13:20:18 +00:00
tahoe-lafs added this to the undecided milestone 2009-12-06 13:20:18 +00:00
francois commented 2009-12-06 14:57:48 +00:00
Author
Owner
Copy Link

Attachment 850-fix-and-test.dpatch (26381 bytes) added

**Attachment** 850-fix-and-test.dpatch (26381 bytes) added
850-fix-and-test.dpatch
26 KiB
zooko commented 2009-12-14 02:14:51 +00:00
Copy Link

#104 (does cp -r work as expected?) was about this issue as well as a couple of others. Moving the loop issue from #104 to here.

#104 (does cp -r work as expected?) was about this issue as well as a couple of others. Moving the loop issue from #104 to here.
warner commented 2009-12-20 20:59:13 +00:00
Copy Link

As #641 points out, if we could either skip symlinks or record them as symlinks (instead of following them), this would go away.

Francois: it looks like your patch only catches cycles of length one, right? I.e. if someone did ln -s .. foo or ln -s ../.. foo, then "tahoe backup" would still get stuck in a loop, yeah?

The more general solution (without fixing #641) would involve keeping a full list of every directory we'd ever started to process, and comparing the target of each symlinky child against that list, and bailing if it was found. That sounds like a lot of memory.

As #641 points out, if we could either skip symlinks or record them as symlinks (instead of following them), this would go away. Francois: it looks like your patch only catches cycles of length one, right? I.e. if someone did `ln -s .. foo` or `ln -s ../.. foo`, then "tahoe backup" would still get stuck in a loop, yeah? The more general solution (without fixing #641) would involve keeping a full list of every directory we'd ever started to process, and comparing the target of each symlinky child against that list, and bailing if it was found. That sounds like a lot of memory.
davidsarah commented 2009-12-20 21:03:15 +00:00
Author
Owner
Copy Link

Replying to zooko:

#104 (does cp -r work as expected?) was about this issue as well as a couple of others.

I don't think it's the same issue. This is only about recursive symlinks in the local filesystem. cp -r needs to handle loops both in the Tahoe and local filesystems. As Brian says, the only way to do that correctly in general is to keep track of the mutable directory storage indices (for the Tahoe fs) or the inode numbers (for the local fs) that you've already seen.

Replying to [zooko](/tahoe-lafs/trac-2024-07-25/issues/850#issuecomment-73787): > #104 (does cp -r work as expected?) was about this issue as well as a couple of others. I don't think it's the same issue. This is only about recursive symlinks in the local filesystem. `cp -r` needs to handle loops both in the Tahoe and local filesystems. As Brian says, the only way to do that correctly in general is to keep track of the mutable directory storage indices (for the Tahoe fs) or the inode numbers (for the local fs) that you've already seen.
francois commented 2009-12-27 21:31:37 +00:00
Author
Owner
Copy Link

Replying to warner:

Francois: it looks like your patch only catches cycles of length one, right? I.e. if someone did ln -s .. foo or ln -s ../.. foo, then "tahoe backup" would still get stuck in a loop, yeah?

Yes, Brian, you're right, this fix is wrong. Can someone with the necessary trac permissions delete this patch from the ticket ?

Replying to [warner](/tahoe-lafs/trac-2024-07-25/issues/850#issuecomment-73788): > Francois: it looks like your patch only catches cycles of length one, right? I.e. if someone did `ln -s .. foo` or `ln -s ../.. foo`, then "tahoe backup" would still get stuck in a loop, yeah? Yes, Brian, you're right, this fix is wrong. Can someone with the necessary trac permissions delete this patch from the ticket ?
warner commented 2009-12-27 21:59:46 +00:00
Copy Link

eh, I think it's fine to leave it there: no harm in having well-labeled experiments lying around :)

I don't know how to fix this in general. I suspect it will require having explicit support for symlinks in tahoe (#641), at least the ability to copy the symlink target name into a tahoe file-like object and then copy it back out again. A short-term fix (again #641, also #729) would be to let you skip over symlinks.. that's what I've been doing for my personal backups.

eh, I think it's fine to leave it there: no harm in having well-labeled experiments lying around :) I don't know how to fix this in general. I suspect it will require having explicit support for symlinks in tahoe (#641), at least the ability to copy the symlink target name into a tahoe file-like object and then copy it back out again. A short-term fix (again #641, also #729) would be to let you skip over symlinks.. that's what I've been doing for my personal backups.
warner commented 2010-01-27 22:54:30 +00:00
Copy Link

changeset:e769bbb6dd41d40c fixes this, by skipping over all symlinks (with a warning).

changeset:e769bbb6dd41d40c fixes this, by skipping over all symlinks (with a warning).
warner added the
fixed
 label 2010-01-27 22:54:30 +00:00
warner modified the milestone from undecided to 1.6.0 2010-01-27 22:54:30 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels   
0.2.0

   
0.3.0

   
0.4.0

   
0.5.0

   
0.5.1

   
0.6.0

   
0.6.1

   
0.7.0

   
0.8.0

   
0.9.0

   
1.0.0

   
1.1.0

   
1.10.0

   
1.10.1

   
1.10.2

   
1.10a2

   
1.11.0

   
1.12.0

   
1.12.1

   
1.13.0

   
1.14.0

   
1.15.0

   
1.15.1

   
1.2.0

   
1.3.0

   
1.4.1

   
1.5.0

   
1.6.0

   
1.6.1

   
1.7.0

   
1.7.1

   
1.7β

   
1.8.0

   
1.8.1

   
1.8.2

   
1.8.3

   
1.8β

   
1.9.0

   
1.9.0-s3branch

   
1.9.0a1

   
1.9.0a2

   
1.9.0b1

   
1.9.1

   
1.9.2

   
1.9.2a1

   
LeastAuthority.com automation

   
blocker

   
cannot reproduce

   
cloud-branch

   
code

catch-all for anything that can be fixed by writing code but isn't classified better

  
code-dirnodes

anything involving tahoe directories

  
code-encoding

immutable-file encoding format/layout, cap format, encoding/decoding algorithms

  
code-frontend

general frontend things: new user-facing interfaces, FTP/SFTP servers, FUSE-like interfaces

  
code-frontend-cli

CLI tools

  
code-frontend-ftp-sftp

   
code-frontend-magic-folder

   
code-frontend-web

webapi interfaces, user-facing "WUI" interfaces

  
code-mutable

anything involving mutable files: encoding/decoding, share format

  
code-network

Introducer, locating storage servers, establishing/maintaining connections to them

  
code-nodeadmin

node startup/shutdown, tools to create nodes, logging tools, management/monitoring tools, manhole, disk-space-limiting tools

  
code-peerselection

server selection/sorting algorithm, rebalancing code, allocation policy, swarming-download

  
code-storage

storage-server implementation, share-storage directory layout, client-to-server share transfer protocol

  
contrib

problems with non-core things that live in the source:contrib/ directory

  
critical

   
defect

   
dev-infrastructure

things that help us build Tahoe: buildbot, automated speed/memory/code-coverage tests and results-displayers, IRC channels, mailing lists, this Trac instance

  
documentation

docs items. Also use 'docs' keyword on tickets in more specific components.

  
duplicate

   
enhancement

   
fixed

   
invalid

   
major

   
minor

   
n/a

   
normal

   
operational

things involved in running a tahoe grid, external tools to monitor/maintain a grid (like "nodeadmin" but larger-scale). Was also used for issues with the allmydata.com grid.

  
packaging

setup.py script, library dependencies, binary packages, licensing, installation instructions

  
somebody else's problem

   
supercritical

   
task

   
trivial

   
unknown

Uncategorized. All tickets default to this component until someone updates it.

  
was already fixed

   
website

things about the tahoe-lafs.org website (and sometimes this Trac instance, shared with 'dev-infrastructure')

  
wontfix

   
worksforme
No Label
0.2.0
0.3.0
0.4.0
0.5.0
0.5.1
0.6.0
0.6.1
0.7.0
0.8.0
0.9.0
1.0.0
1.1.0
1.10.0
1.10.1
1.10.2
1.10a2
1.11.0
1.12.0
1.12.1
1.13.0
1.14.0
1.15.0
1.15.1
1.2.0
1.3.0
1.4.1
1.5.0
1.6.0
1.6.1
1.7.0
1.7.1
1.7β
1.8.0
1.8.1
1.8.2
1.8.3
1.8β
1.9.0
1.9.0-s3branch
1.9.0a1
1.9.0a2
1.9.0b1
1.9.1
1.9.2
1.9.2a1
LeastAuthority.com automation
blocker
cannot reproduce
cloud-branch
code
code-dirnodes
code-encoding
code-frontend
code-frontend-cli
code-frontend-ftp-sftp
code-frontend-magic-folder
code-frontend-web
code-mutable
code-network
code-nodeadmin
code-peerselection
code-storage
contrib
critical
defect
dev-infrastructure
documentation
duplicate
enhancement
fixed
invalid
major
minor
n/a
normal
operational
packaging
somebody else's problem
supercritical
task
trivial
unknown
was already fixed
website
wontfix
worksforme
Milestone
Clear milestone
No items
No Milestone
1.6.0
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Reference: tahoe-lafs/trac-2024-07-25#850
No description provided.
Delete Branch "%!s(<nil>)"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?