tahoe-lafs/trac-2024-07-25
2
0
Issues 1.1k Wiki

set ETag on immutable directories, short-circuit on cache hit #443

New Issue
Closed
opened 2008-06-03 04:49:39 +00:00 by warner · 23 comments
warner commented 2008-06-03 04:49:39 +00:00
Copy Link

When retrieving an immutable file, the ETag header should be set to the file's URI. When retrieving a mutable file, it should be set to the current roothash value. When retrieving a directory, it should also be set to the roothash value.

The server should also use the right sort of If-Modified-Since dance, using the ETag to let browser caches do the right thing.

When retrieving an immutable file, the ETag header should be set to the file's URI. When retrieving a mutable file, it should be set to the current roothash value. When retrieving a directory, it should also be set to the roothash value. The server should also use the right sort of If-Modified-Since dance, using the ETag to let browser caches do the right thing.
warner added the
code-frontend-web
major
enhancement
1.0.0
 labels 2008-06-03 04:49:39 +00:00
warner added this to the undecided milestone 2008-06-03 04:49:39 +00:00
warner commented 2008-11-06 19:43:22 +00:00
Author
Copy Link

I added code recently to set an ETag on immutable files (using the storage index.. I'm not sure whether to use this or the URI). It needs review, however, because the twisted.web req.setETag method needs to be called at a specific point in the response process (to make it interact with the if-etag-equals HTTP header), and I'm not sure we're doing it quite right.

We still don't have etags on mutable files.

I added code recently to set an ETag on immutable files (using the storage index.. I'm not sure whether to use this or the URI). It needs review, however, because the twisted.web `req.setETag` method needs to be called at a specific point in the response process (to make it interact with the if-etag-equals HTTP header), and I'm not sure we're doing it quite right. We still don't have etags on mutable files.
davidsarah commented 2010-01-16 00:22:01 +00:00
Owner
Copy Link

#844 references http://allmydata.org/pipermail/tahoe-dev/2009-November/003221.html which claims that the immutable-file ETag support wasn't doing the right thing for (at least) Squid to recognize immutable files as unchanged. Let's make it the goal of this ticket to make sure that we have this support works properly for a representative sample of web proxies and browsers, and open another ticket to add ETag support for mutable files.

#844 references <http://allmydata.org/pipermail/tahoe-dev/2009-November/003221.html> which claims that the immutable-file ETag support wasn't doing the right thing for (at least) Squid to recognize immutable files as unchanged. Let's make it the goal of this ticket to make sure that we have this support works properly for a representative sample of web proxies and browsers, and open another ticket to add ETag support for mutable files.
tahoe-lafs changed title from webapi should provide an ETag to Check that webapi support for ETags on immutable files works properly 2010-01-16 00:22:51 +00:00
zooko commented 2010-02-27 06:34:22 +00:00
Copy Link

Can we add into this file to also check that it does the right thing for immutable directories? Or is that sufficiently different that it should be a separate ticket?

Can we add into this file to also check that it does the right thing for immutable *directories*? Or is that sufficiently different that it should be a separate ticket?
davidsarah commented 2010-02-27 08:31:08 +00:00
Owner
Copy Link

Replying to zooko:

Can we add into this file to also check that it does the right thing for immutable directories?

We can indeed.

Replying to [zooko](/tahoe-lafs/trac-2024-07-25/issues/443#issuecomment-66776): > Can we add into this file to also check that it does the right thing for immutable *directories*? We can indeed.
tahoe-lafs modified the milestone from undecided to 1.7.0 2010-02-27 08:31:08 +00:00
tahoe-lafs changed title from Check that webapi support for ETags on immutable files works properly to Check that webapi support for ETags on immutable files/directories works properly 2010-02-27 08:31:08 +00:00
jsgf commented 2010-03-11 18:16:46 +00:00
Owner
Copy Link

I'll have a look at this, since I'm mucking around in that area anyway (at least for immutable; I'll need someone to explain the situation with mutable files to me).

I'll have a look at this, since I'm mucking around in that area anyway (at least for immutable; I'll need someone to explain the situation with mutable files to me).
jsgf commented 2010-03-11 23:12:11 +00:00
Owner
Copy Link

For immutable files:

Basic If-Match appears to be completely ignored; it always returns 200 rather than 412 (precondition failed), regardless of the provided etag.

If-None-Match will return "304 not modified" and no body, as it is supposed.

This is consistent with twisted web's server, which only checks for if-none-match. I'm not sure quite how the body is getting suppressed. We should be checking the result of setETag() to see if we have a etag hit or not; it may be its doing too much work.

Will check immutable dirs next.

For immutable files: Basic If-Match appears to be completely ignored; it always returns 200 rather than 412 (precondition failed), regardless of the provided etag. If-None-Match will return "304 not modified" and no body, as it is supposed. This is consistent with twisted web's server, which only checks for if-none-match. I'm not sure quite how the body is getting suppressed. We should be checking the result of setETag() to see if we have a etag hit or not; it may be its doing too much work. Will check immutable dirs next.
jsgf commented 2010-03-12 00:00:24 +00:00
Owner
Copy Link

Attachment imm-dir-etag.diff.txt (2939 bytes) added

Add ETag support for immutable directories

**Attachment** imm-dir-etag.diff.txt (2939 bytes) added Add ETag support for immutable directories
imm-dir-etag.diff.txt
2.9 KiB
jsgf commented 2010-03-12 00:33:12 +00:00
Owner
Copy Link

Attachment short-circuit-imm-etag.diff.txt (2807 bytes) added

Short circuit GET when client already has ETag

**Attachment** short-circuit-imm-etag.diff.txt (2807 bytes) added Short circuit GET when client already has ETag
short-circuit-imm-etag.diff.txt
2.7 KiB
tahoe-lafs modified the milestone from 1.7.0 to 1.7.1 2010-06-16 04:01:19 +00:00
zooko commented 2010-07-08 05:16:13 +00:00
Copy Link

Did anyone figure out why it was thought that the ETag mechanism wasn't working for Squid per comment:66774? Was the explanation something to do with the thing about If-Match that jsgf mentioned in comment:66781? I don't understand what If-Match is for.

Did anyone figure out why it was thought that the ETag mechanism wasn't working for Squid per [comment:66774](/tahoe-lafs/trac-2024-07-25/issues/443#issuecomment-66774)? Was the explanation something to do with the thing about If-Match that jsgf mentioned in [comment:66781](/tahoe-lafs/trac-2024-07-25/issues/443#issuecomment-66781)? I don't understand what If-Match is for.
jsgf commented 2010-07-08 08:42:51 +00:00
Owner
Copy Link

I think if-match is for PUT/POST operations to make sure the entity at the specified URI is still in the expected state.

I'm not sure why squid might have problems with Tahoe. The posting referred to in comment:66774 is pretty vague about what might be going wrong; it would be nice to see some actual analysis (or even just an HTTP protocol dump).

I think if-match is for PUT/POST operations to make sure the entity at the specified URI is still in the expected state. I'm not sure why squid might have problems with Tahoe. The posting referred to in [comment:66774](/tahoe-lafs/trac-2024-07-25/issues/443#issuecomment-66774) is pretty vague about what might be going wrong; it would be nice to see some actual analysis (or even just an HTTP protocol dump).
zooko changed title from Check that webapi support for ETags on immutable files/directories works properly to set ETag on immutable directories, short-circuit on cache hit 2010-07-08 13:40:00 +00:00
zooko commented 2010-07-08 14:24:53 +00:00
Copy Link

Well, in handling a filenode these patches say:

+            if si and req.setETag(base32.b2a(si)):

but in handling a dirnode these patches say:

+            if si and req.setETag('DIR:%s-%s' % (base32.b2a(si), t or "")):

Shouldn't the filenode also have t appended to its ETag so that people who request somefile?t=json don't get the same thing as the previous person who requested somefile?
jsgf: please reply to this and, if appropriate, re-add the "review-needed" flag on this ticket.

Well, in handling a filenode these patches say: ``` + if si and req.setETag(base32.b2a(si)): ``` but in handling a dirnode these patches say: ``` + if si and req.setETag('DIR:%s-%s' % (base32.b2a(si), t or "")): ``` Shouldn't the filenode also have `t` appended to its ETag so that people who request `somefile?t=json` don't get the same thing as the previous person who requested `somefile`? jsgf: please reply to this and, if appropriate, re-add the "review-needed" flag on this ticket.
jsgf commented 2010-07-08 18:41:50 +00:00
Owner
Copy Link

Yes, that looks pretty dubious. The ETag should be computed by a single function everywhere, rather than redone in a bespoke fashion at each point. But let me double-check that there isn't something else going on there...

Yes, that looks pretty dubious. The ETag should be computed by a single function everywhere, rather than redone in a bespoke fashion at each point. But let me double-check that there isn't something else going on there...
jsgf commented 2010-07-08 18:43:48 +00:00
Owner
Copy Link

No, I see. The first one is for plain immutable files which only have one representation - their actual binary contents. The second is for directories, which are interpreted by Tahoe itself and can have multiple representations. If you access the directory as a just the raw immutable file then you'll end up with an ETag of the first form.

No, I see. The first one is for plain immutable files which only have one representation - their actual binary contents. The second is for directories, which are interpreted by Tahoe itself and can have multiple representations. If you access the directory as a just the raw immutable file then you'll end up with an ETag of the first form.
zooko commented 2010-07-08 23:54:52 +00:00
Copy Link

But won't the current patch make the following thing go wrong, causing the second request to cache-hit when instead the second request needs to returning something entirely different.

(If I'm right, then this probably goes to show that our source:docs/frontends/webapi.txt needs to be reorganized so that people like jsgf can easily find this stuff.)

$ wget http://127.0.0.1:3456/uri/URI:CHK:u7xfz46l7lpwaxw6yjeqnotqk4:i55qdey7cwaqbfurafx73f4flxmyj6lhq7lynbkfcx5us4g7l5za:3:10:124
--2010-07-08 17:39:41--  http://127.0.0.1:3456/uri/URI:CHK:u7xfz46l7lpwaxw6yjeqnotqk4:i55qdey7cwaqbfurafx73f4flxmyj6lhq7lynbkfcx5us4g7l5za:3:10:124
Connecting to 127.0.0.1:3456... connected.
HTTP request sent, awaiting response... 200 OK
Length: 124 [text/plain]
Saving to: `URI:CHK:u7xfz46l7lpwaxw6yjeqnotqk4:i55qdey7cwaqbfurafx73f4flxmyj6lhq7lynbkfcx5us4g7l5za:3:10:124.1'

100%[================================================================================================================================================================>] 124         --.-K/s   in 0s      

2010-07-08 17:39:42 (7.88 MB/s) - `URI:CHK:u7xfz46l7lpwaxw6yjeqnotqk4:i55qdey7cwaqbfurafx73f4flxmyj6lhq7lynbkfcx5us4g7l5za:3:10:124.1' saved [124/124]

$ hexdump -C URI\:CHK\:u7xfz46l7lpwaxw6yjeqnotqk4\:i55qdey7cwaqbfurafx73f4flxmyj6lhq7lynbkfcx5us4g7l5za\:3\:10\:124 
00000000  47 49 46 38 39 61 0a 00  3c 00 b3 ff 00 c0 c0 c0  |GIF89a..<.......|
00000010  cb cb e5 b1 b1 d8 f8 f8  fb 85 85 c2 e9 e9 f4 b5  |................|
00000020  b5 da dd dd ee ff ff ff  00 00 00 00 00 00 00 00  |................|
00000030  00 00 00 00 00 00 00 00  00 00 00 00 00 21 f9 04  |.............!..|
00000040  01 00 00 00 00 2c 00 00  00 00 0a 00 3c 00 00 04  |.....,......<...|
00000050  29 10 c9 59 0c 00 13 0d  72 ef 3c 5d 27 09 a1 18  |)..Y....r.<]'...|
00000060  94 22 da 9d 6a eb be 70  2c cf 74 6d df 78 ae ef  |."..j..p,.tm.x..|
00000070  7c ef ff c0 a0 70 48 2c  12 23 00 3b              ||....pH,.#.;|
0000007c
$ wget http://127.0.0.1:3456/uri/URI:CHK:u7xfz46l7lpwaxw6yjeqnotqk4:i55qdey7cwaqbfurafx73f4flxmyj6lhq7lynbkfcx5us4g7l5za:3:10:124?t=json
--2010-07-08 17:39:51--  http://127.0.0.1:3456/uri/URI:CHK:u7xfz46l7lpwaxw6yjeqnotqk4:i55qdey7cwaqbfurafx73f4flxmyj6lhq7lynbkfcx5us4g7l5za:3:10:124?t=json
Connecting to 127.0.0.1:3456... connected.
HTTP request sent, awaiting response... 200 OK
Length: 298 [text/plain]
Saving to: `URI:CHK:u7xfz46l7lpwaxw6yjeqnotqk4:i55qdey7cwaqbfurafx73f4flxmyj6lhq7lynbkfcx5us4g7l5za:3:10:124?t=json.1'

100%[================================================================================================================================================================>] 298         --.-K/s   in 0s      

2010-07-08 17:39:51 (18.9 MB/s) - `URI:CHK:u7xfz46l7lpwaxw6yjeqnotqk4:i55qdey7cwaqbfurafx73f4flxmyj6lhq7lynbkfcx5us4g7l5za:3:10:124?t=json.1' saved [298/298]

$ hexdump -C URI\:CHK\:u7xfz46l7lpwaxw6yjeqnotqk4\:i55qdey7cwaqbfurafx73f4flxmyj6lhq7lynbkfcx5us4g7l5za\:3\:10\:124\?t\=json 
00000000  5b 0a 20 22 66 69 6c 65  6e 6f 64 65 22 2c 20 0a  |[. "filenode", .|
00000010  20 7b 0a 20 20 22 6d 75  74 61 62 6c 65 22 3a 20  | {.  "mutable": |
00000020  66 61 6c 73 65 2c 20 0a  20 20 22 76 65 72 69 66  |false, .  "verif|
00000030  79 5f 75 72 69 22 3a 20  22 55 52 49 3a 43 48 4b  |y_uri": "URI:CHK|
00000040  2d 56 65 72 69 66 69 65  72 3a 79 62 70 6f 64 6e  |-Verifier:ybpodn|
00000050  62 35 69 62 67 71 62 6b  61 74 6b 6d 68 64 65 6f  |b5ibgqbkatkmhdeo|
00000060  76 33 36 6d 3a 69 35 35  71 64 65 79 37 63 77 61  |v36m:i55qdey7cwa|
00000070  71 62 66 75 72 61 66 78  37 33 66 34 66 6c 78 6d  |qbfurafx73f4flxm|
00000080  79 6a 36 6c 68 71 37 6c  79 6e 62 6b 66 63 78 35  |yj6lhq7lynbkfcx5|
00000090  75 73 34 67 37 6c 35 7a  61 3a 33 3a 31 30 3a 31  |us4g7l5za:3:10:1|
000000a0  32 34 22 2c 20 0a 20 20  22 72 6f 5f 75 72 69 22  |24", .  "ro_uri"|
000000b0  3a 20 22 55 52 49 3a 43  48 4b 3a 75 37 78 66 7a  |: "URI:CHK:u7xfz|
000000c0  34 36 6c 37 6c 70 77 61  78 77 36 79 6a 65 71 6e  |46l7lpwaxw6yjeqn|
000000d0  6f 74 71 6b 34 3a 69 35  35 71 64 65 79 37 63 77  |otqk4:i55qdey7cw|
000000e0  61 71 62 66 75 72 61 66  78 37 33 66 34 66 6c 78  |aqbfurafx73f4flx|
000000f0  6d 79 6a 36 6c 68 71 37  6c 79 6e 62 6b 66 63 78  |myj6lhq7lynbkfcx|
00000100  35 75 73 34 67 37 6c 35  7a 61 3a 33 3a 31 30 3a  |5us4g7l5za:3:10:|
00000110  31 32 34 22 2c 20 0a 20  20 22 73 69 7a 65 22 3a  |124", .  "size":|
00000120  20 31 32 34 0a 20 7d 0a  5d 0a                    | 124. }.].|
0000012a
But won't the current patch make the following thing go wrong, causing the second request to cache-hit when instead the second request needs to returning something entirely different. (If I'm right, then this probably goes to show that our source:docs/frontends/webapi.txt needs to be reorganized so that people like jsgf can easily find this stuff.) ``` $ wget http://127.0.0.1:3456/uri/URI:CHK:u7xfz46l7lpwaxw6yjeqnotqk4:i55qdey7cwaqbfurafx73f4flxmyj6lhq7lynbkfcx5us4g7l5za:3:10:124 --2010-07-08 17:39:41-- http://127.0.0.1:3456/uri/URI:CHK:u7xfz46l7lpwaxw6yjeqnotqk4:i55qdey7cwaqbfurafx73f4flxmyj6lhq7lynbkfcx5us4g7l5za:3:10:124 Connecting to 127.0.0.1:3456... connected. HTTP request sent, awaiting response... 200 OK Length: 124 [text/plain] Saving to: `URI:CHK:u7xfz46l7lpwaxw6yjeqnotqk4:i55qdey7cwaqbfurafx73f4flxmyj6lhq7lynbkfcx5us4g7l5za:3:10:124.1' 100%[================================================================================================================================================================>] 124 --.-K/s in 0s 2010-07-08 17:39:42 (7.88 MB/s) - `URI:CHK:u7xfz46l7lpwaxw6yjeqnotqk4:i55qdey7cwaqbfurafx73f4flxmyj6lhq7lynbkfcx5us4g7l5za:3:10:124.1' saved [124/124] $ hexdump -C URI\:CHK\:u7xfz46l7lpwaxw6yjeqnotqk4\:i55qdey7cwaqbfurafx73f4flxmyj6lhq7lynbkfcx5us4g7l5za\:3\:10\:124 00000000 47 49 46 38 39 61 0a 00 3c 00 b3 ff 00 c0 c0 c0 |GIF89a..<.......| 00000010 cb cb e5 b1 b1 d8 f8 f8 fb 85 85 c2 e9 e9 f4 b5 |................| 00000020 b5 da dd dd ee ff ff ff 00 00 00 00 00 00 00 00 |................| 00000030 00 00 00 00 00 00 00 00 00 00 00 00 00 21 f9 04 |.............!..| 00000040 01 00 00 00 00 2c 00 00 00 00 0a 00 3c 00 00 04 |.....,......<...| 00000050 29 10 c9 59 0c 00 13 0d 72 ef 3c 5d 27 09 a1 18 |)..Y....r.<]'...| 00000060 94 22 da 9d 6a eb be 70 2c cf 74 6d df 78 ae ef |."..j..p,.tm.x..| 00000070 7c ef ff c0 a0 70 48 2c 12 23 00 3b ||....pH,.#.;| 0000007c $ wget http://127.0.0.1:3456/uri/URI:CHK:u7xfz46l7lpwaxw6yjeqnotqk4:i55qdey7cwaqbfurafx73f4flxmyj6lhq7lynbkfcx5us4g7l5za:3:10:124?t=json --2010-07-08 17:39:51-- http://127.0.0.1:3456/uri/URI:CHK:u7xfz46l7lpwaxw6yjeqnotqk4:i55qdey7cwaqbfurafx73f4flxmyj6lhq7lynbkfcx5us4g7l5za:3:10:124?t=json Connecting to 127.0.0.1:3456... connected. HTTP request sent, awaiting response... 200 OK Length: 298 [text/plain] Saving to: `URI:CHK:u7xfz46l7lpwaxw6yjeqnotqk4:i55qdey7cwaqbfurafx73f4flxmyj6lhq7lynbkfcx5us4g7l5za:3:10:124?t=json.1' 100%[================================================================================================================================================================>] 298 --.-K/s in 0s 2010-07-08 17:39:51 (18.9 MB/s) - `URI:CHK:u7xfz46l7lpwaxw6yjeqnotqk4:i55qdey7cwaqbfurafx73f4flxmyj6lhq7lynbkfcx5us4g7l5za:3:10:124?t=json.1' saved [298/298] $ hexdump -C URI\:CHK\:u7xfz46l7lpwaxw6yjeqnotqk4\:i55qdey7cwaqbfurafx73f4flxmyj6lhq7lynbkfcx5us4g7l5za\:3\:10\:124\?t\=json 00000000 5b 0a 20 22 66 69 6c 65 6e 6f 64 65 22 2c 20 0a |[. "filenode", .| 00000010 20 7b 0a 20 20 22 6d 75 74 61 62 6c 65 22 3a 20 | {. "mutable": | 00000020 66 61 6c 73 65 2c 20 0a 20 20 22 76 65 72 69 66 |false, . "verif| 00000030 79 5f 75 72 69 22 3a 20 22 55 52 49 3a 43 48 4b |y_uri": "URI:CHK| 00000040 2d 56 65 72 69 66 69 65 72 3a 79 62 70 6f 64 6e |-Verifier:ybpodn| 00000050 62 35 69 62 67 71 62 6b 61 74 6b 6d 68 64 65 6f |b5ibgqbkatkmhdeo| 00000060 76 33 36 6d 3a 69 35 35 71 64 65 79 37 63 77 61 |v36m:i55qdey7cwa| 00000070 71 62 66 75 72 61 66 78 37 33 66 34 66 6c 78 6d |qbfurafx73f4flxm| 00000080 79 6a 36 6c 68 71 37 6c 79 6e 62 6b 66 63 78 35 |yj6lhq7lynbkfcx5| 00000090 75 73 34 67 37 6c 35 7a 61 3a 33 3a 31 30 3a 31 |us4g7l5za:3:10:1| 000000a0 32 34 22 2c 20 0a 20 20 22 72 6f 5f 75 72 69 22 |24", . "ro_uri"| 000000b0 3a 20 22 55 52 49 3a 43 48 4b 3a 75 37 78 66 7a |: "URI:CHK:u7xfz| 000000c0 34 36 6c 37 6c 70 77 61 78 77 36 79 6a 65 71 6e |46l7lpwaxw6yjeqn| 000000d0 6f 74 71 6b 34 3a 69 35 35 71 64 65 79 37 63 77 |otqk4:i55qdey7cw| 000000e0 61 71 62 66 75 72 61 66 78 37 33 66 34 66 6c 78 |aqbfurafx73f4flx| 000000f0 6d 79 6a 36 6c 68 71 37 6c 79 6e 62 6b 66 63 78 |myj6lhq7lynbkfcx| 00000100 35 75 73 34 67 37 6c 35 7a 61 3a 33 3a 31 30 3a |5us4g7l5za:3:10:| 00000110 31 32 34 22 2c 20 0a 20 20 22 73 69 7a 65 22 3a |124", . "size":| 00000120 20 31 32 34 0a 20 7d 0a 5d 0a | 124. }.].| 0000012a ```
zooko commented 2010-07-10 23:38:03 +00:00
Copy Link

I asked jsgf about this in email. He replied:

Yes the etag should distinguish different representations.

Which I believe means that comment:66789 is right that the current patch is wrong. I guess this shows that we need a unit test which would be red with the current patch--a unit test that loads a file with one representation (GET /uri/$FILEREADCAP) and then loads it again with a different representation (GET /uri/$FILEREADCAP?t=json) and flunks the code under test if it gave back the same thing on the second query.

I asked jsgf about this in email. He replied: > Yes the etag should distinguish different representations. Which I believe means that [comment:66789](/tahoe-lafs/trac-2024-07-25/issues/443#issuecomment-66789) is right that the current patch is wrong. I guess this shows that we need a unit test which would be red with the current patch--a unit test that loads a file with one representation (`GET /uri/$FILEREADCAP`) and then loads it again with a different representation (`GET /uri/$FILEREADCAP?t=json`) and flunks the code under test if it gave back the same thing on the second query.
zooko commented 2010-07-17 07:33:35 +00:00
Copy Link

This probably just needs one more unit test (to demonstrate the problem mentioned in comment:66790) and one small tweak and it will be ready.

This probably just needs one more unit test (to demonstrate the problem mentioned in [comment:66790](/tahoe-lafs/trac-2024-07-25/issues/443#issuecomment-66790)) and one small tweak and it will be ready.
zooko modified the milestone from 1.7.1 to 1.8β 2010-07-17 07:33:35 +00:00
zooko commented 2010-07-20 04:57:58 +00:00
Copy Link

Oh and a NEWS snippet.

Oh and a NEWS snippet.
davidsarah commented 2010-09-11 01:02:12 +00:00
Owner
Copy Link

Out of time for 1.8.

Out of time for 1.8.
tahoe-lafs modified the milestone from 1.8β to 1.9.0 2010-09-11 01:02:12 +00:00
davidsarah commented 2011-07-16 21:23:50 +00:00
Owner
Copy Link

If anyone wants to add a unit test and fix the issue in comment:66789, they should do so in the next week in order for this improvement to get into 1.9.

If anyone wants to add a unit test and fix the issue in [comment:66789](/tahoe-lafs/trac-2024-07-25/issues/443#issuecomment-66789), they should do so in the next week in order for this improvement to get into 1.9.
zooko modified the milestone from 1.9.0 to soon 2011-07-27 18:23:10 +00:00
amiller commented 2012-03-31 20:53:23 +00:00
Copy Link

I added unit tests and a minor tweak.

In jsgf's original patches, the short-circuit behavior was added to the FileDownloader class and would therefore only apply to the "t=None" case. So the problem in comment:66789 does not occur.

However, we might as well short-circuit when an etag matches for "t=json" etc., in which case the tags do need to be distinguished.

https://github.com/amiller/tahoe-lafs/pull/2.patch

I added unit tests and a minor tweak. In jsgf's original patches, the short-circuit behavior was added to the FileDownloader class and would therefore only apply to the "t=None" case. So the problem in [comment:66789](/tahoe-lafs/trac-2024-07-25/issues/443#issuecomment-66789) does not occur. However, we might as well short-circuit when an etag matches for "t=json" etc., in which case the tags do need to be distinguished. <https://github.com/amiller/tahoe-lafs/pull/2.patch>
tahoe-lafs modified the milestone from soon to 1.10.0 2012-04-01 01:12:30 +00:00
warner commented 2012-05-13 07:44:53 +00:00
Author
Copy Link

I've merged together jsgf's changes with amiller's fixes, and added a couple of new tests. I also fixed the implementation to not use an etag for t=info or t=rename-form, since both actually provide variable output. "", "json", "uri", "readonly-uri" are all eligible.

I'll push the changes in a moment.

I've merged together jsgf's changes with amiller's fixes, and added a couple of new tests. I also fixed the implementation to not use an etag for t=info or t=rename-form, since both actually provide variable output. "", "json", "uri", "readonly-uri" are all eligible. I'll push the changes in a moment.
Brian Warner <warner@lothar.com> commented 2012-05-13 07:47:23 +00:00
Owner
Copy Link

In changeset:5d404db898e1e6dc:

webapi: don't allow ETags in t=info or t=rename-form, both are variable

t=info contains randomly-generated ophandles, and t=rename-form contains the
name of the child being renamed, so neither is eligible for a
short-circuiting ETag. Enhanced test_web to exercise this. Had to improve
FakeCHKFileNode slightly to let it participate. Refs #443.
In changeset:5d404db898e1e6dc: ``` webapi: don't allow ETags in t=info or t=rename-form, both are variable t=info contains randomly-generated ophandles, and t=rename-form contains the name of the child being renamed, so neither is eligible for a short-circuiting ETag. Enhanced test_web to exercise this. Had to improve FakeCHKFileNode slightly to let it participate. Refs #443. ```
warner commented 2012-05-13 07:50:58 +00:00
Author
Copy Link

This landed in a series of patches ending with changeset:5d404db89.

This landed in a series of patches ending with changeset:5d404db89.
warner added the
fixed
 label 2012-05-13 07:50:58 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels   
0.2.0

   
0.3.0

   
0.4.0

   
0.5.0

   
0.5.1

   
0.6.0

   
0.6.1

   
0.7.0

   
0.8.0

   
0.9.0

   
1.0.0

   
1.1.0

   
1.10.0

   
1.10.1

   
1.10.2

   
1.10a2

   
1.11.0

   
1.12.0

   
1.12.1

   
1.13.0

   
1.14.0

   
1.15.0

   
1.15.1

   
1.2.0

   
1.3.0

   
1.4.1

   
1.5.0

   
1.6.0

   
1.6.1

   
1.7.0

   
1.7.1

   
1.7β

   
1.8.0

   
1.8.1

   
1.8.2

   
1.8.3

   
1.8β

   
1.9.0

   
1.9.0-s3branch

   
1.9.0a1

   
1.9.0a2

   
1.9.0b1

   
1.9.1

   
1.9.2

   
1.9.2a1

   
LeastAuthority.com automation

   
blocker

   
cannot reproduce

   
cloud-branch

   
code

catch-all for anything that can be fixed by writing code but isn't classified better

  
code-dirnodes

anything involving tahoe directories

  
code-encoding

immutable-file encoding format/layout, cap format, encoding/decoding algorithms

  
code-frontend

general frontend things: new user-facing interfaces, FTP/SFTP servers, FUSE-like interfaces

  
code-frontend-cli

CLI tools

  
code-frontend-ftp-sftp

   
code-frontend-magic-folder

   
code-frontend-web

webapi interfaces, user-facing "WUI" interfaces

  
code-mutable

anything involving mutable files: encoding/decoding, share format

  
code-network

Introducer, locating storage servers, establishing/maintaining connections to them

  
code-nodeadmin

node startup/shutdown, tools to create nodes, logging tools, management/monitoring tools, manhole, disk-space-limiting tools

  
code-peerselection

server selection/sorting algorithm, rebalancing code, allocation policy, swarming-download

  
code-storage

storage-server implementation, share-storage directory layout, client-to-server share transfer protocol

  
contrib

problems with non-core things that live in the source:contrib/ directory

  
critical

   
defect

   
dev-infrastructure

things that help us build Tahoe: buildbot, automated speed/memory/code-coverage tests and results-displayers, IRC channels, mailing lists, this Trac instance

  
documentation

docs items. Also use 'docs' keyword on tickets in more specific components.

  
duplicate

   
enhancement

   
fixed

   
invalid

   
major

   
minor

   
n/a

   
normal

   
operational

things involved in running a tahoe grid, external tools to monitor/maintain a grid (like "nodeadmin" but larger-scale). Was also used for issues with the allmydata.com grid.

  
packaging

setup.py script, library dependencies, binary packages, licensing, installation instructions

  
somebody else's problem

   
supercritical

   
task

   
trivial

   
unknown

Uncategorized. All tickets default to this component until someone updates it.

  
was already fixed

   
website

things about the tahoe-lafs.org website (and sometimes this Trac instance, shared with 'dev-infrastructure')

  
wontfix

   
worksforme
No Label
0.2.0
0.3.0
0.4.0
0.5.0
0.5.1
0.6.0
0.6.1
0.7.0
0.8.0
0.9.0
1.0.0
1.1.0
1.10.0
1.10.1
1.10.2
1.10a2
1.11.0
1.12.0
1.12.1
1.13.0
1.14.0
1.15.0
1.15.1
1.2.0
1.3.0
1.4.1
1.5.0
1.6.0
1.6.1
1.7.0
1.7.1
1.7β
1.8.0
1.8.1
1.8.2
1.8.3
1.8β
1.9.0
1.9.0-s3branch
1.9.0a1
1.9.0a2
1.9.0b1
1.9.1
1.9.2
1.9.2a1
LeastAuthority.com automation
blocker
cannot reproduce
cloud-branch
code
code-dirnodes
code-encoding
code-frontend
code-frontend-cli
code-frontend-ftp-sftp
code-frontend-magic-folder
code-frontend-web
code-mutable
code-network
code-nodeadmin
code-peerselection
code-storage
contrib
critical
defect
dev-infrastructure
documentation
duplicate
enhancement
fixed
invalid
major
minor
n/a
normal
operational
packaging
somebody else's problem
supercritical
task
trivial
unknown
was already fixed
website
wontfix
worksforme
Milestone
Clear milestone
No items
No Milestone
1.10.0
Assignees
Clear assignees
No Assignees
warner
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Reference: tahoe-lafs/trac-2024-07-25#443
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?