Magic Folder: garbage-collect old versions of files on seeing a newer version #2440

New Issue

tahoe-lafs · 2015-06-01T16:24:23Z

daira commented

2015-06-01 16:24:23 +00:00

When a Magic Folder client sees a newer version of a file in another client's DMD, it should unlink the older version from its own DMD. This ensures that old versions are not retained unnecessarily by garbage collection.

tahoe-lafs added the

code-frontend-magic-folder

normal

defect

1.10.0

labels 2015-06-01 16:24:23 +00:00

tahoe-lafs added this to the eventually milestone 2015-06-01 16:24:23 +00:00

daira commented

2015-06-01 16:24:50 +00:00

Note that this is not required as part of OTF objective 4.

Note that this is *not* required as part of OTF objective 4.

dawuud commented

2015-07-14 12:05:53 +00:00

When a magic-folder client discovers a new version of a file within the DMD... this means within the DMD but not in our own Tahoe upload directory. We must link the DMD file into the client's Tahoe upload dir... after unlinking the old file.

daira commented

2015-07-23 15:20:13 +00:00

Replying to dawuud:

When a magic-folder client discovers a new version of a file within the DMD... this means within the DMD but not in our own Tahoe upload directory. We must link the DMD file into the client's Tahoe upload dir... after unlinking the old file.

It's not necessary to link the new version into this client's DMD, because it is already in the other client's DMD, and we don't rely on all the DMDs being eventually the same. What I was intending was that if we are modifying our own DMD anyway, we "garbage collect" links to versions that are known to be old.

It would be possible to link the new version at the same time even though it isn't required, but that is a separate design decision and not what I was intending to refer to by this ticket.

Replying to [dawuud](/tahoe-lafs/trac-2024-07-25/issues/2440#issuecomment-97529): > When a magic-folder client discovers a new version of a file within the DMD... this means within the DMD but not in our own Tahoe upload directory. We must link the DMD file into the client's Tahoe upload dir... after unlinking the old file. It's not necessary to link the new version into this client's DMD, because it is already in the other client's DMD, and we don't rely on all the DMDs being eventually the same. What I was intending was that *if we are modifying our own DMD anyway*, we "garbage collect" links to versions that are known to be old. It would be possible to link the new version at the same time even though it isn't required, but that is a separate design decision and not what I was intending to refer to by this ticket.

tahoe-lafs changed title from ~~Magic Folder: unlink old versions of files on seeing a newer version~~ to Magic Folder: garbage-collect old versions of files on seeing a newer version

2016-03-21 15:25:17 +00:00

exarkun commented

2020-06-30 13:43:30 +00:00

magic-folder has been split out into a separate project - https://github.com/leastauthority/magic-folder

magic-folder has been split out into a separate project - <https://github.com/leastauthority/magic-folder>

exarkun added the

somebody else's problem

label 2020-06-30 13:43:30 +00:00

exarkun closed this issue

2020-06-30 13:43:30 +00:00

Sign in to join this conversation.