exception from parsing requirements #2242
Labels
No Label
0.2.0
0.3.0
0.4.0
0.5.0
0.5.1
0.6.0
0.6.1
0.7.0
0.8.0
0.9.0
1.0.0
1.1.0
1.10.0
1.10.1
1.10.2
1.10a2
1.11.0
1.12.0
1.12.1
1.13.0
1.14.0
1.15.0
1.15.1
1.2.0
1.3.0
1.4.1
1.5.0
1.6.0
1.6.1
1.7.0
1.7.1
1.7β
1.8.0
1.8.1
1.8.2
1.8.3
1.8β
1.9.0
1.9.0-s3branch
1.9.0a1
1.9.0a2
1.9.0b1
1.9.1
1.9.2
1.9.2a1
LeastAuthority.com automation
blocker
cannot reproduce
cloud-branch
code
code-dirnodes
code-encoding
code-frontend
code-frontend-cli
code-frontend-ftp-sftp
code-frontend-magic-folder
code-frontend-web
code-mutable
code-network
code-nodeadmin
code-peerselection
code-storage
contrib
critical
defect
dev-infrastructure
documentation
duplicate
enhancement
fixed
invalid
major
minor
n/a
normal
operational
packaging
somebody else's problem
supercritical
task
trivial
unknown
was already fixed
website
wontfix
worksforme
No Milestone
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Reference: tahoe-lafs/trac-2024-07-25#2242
Loading…
Reference in New Issue
Block a user
No description provided.
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
as reported by ambimorph on IRC:
Investigation showed the the
*requires*_
variable held a string ("coverage==3.4"
) instead of an iterable containing strings, therefore this code in our splinter of setuptools tried to parse each character of that string.Do we want to fix this specific bug in zetuptoolz, or concentrate on migrating to a later version of setuptools (#2044)?
e9e63c5e72619f4e5811cd1eed31e344db6236c8 will reveal more information in this case.
This came up in #2378, causing one of the buildslaves to fail the "test-from-egg" step.
Would it be okay if I pushed this patch into trunk? I tested it manually and it worked:
Here's the result of running locally a manual test with this patch applied, which does indeed helpfully show me what requirements are triggering the problem:
+1
Here is a patch that is intended to fix this by checking whether
*requires*
is a string or a list, and if it is a string then treat it as a list of one element:I tested this patch manually, and it changed the error shown in comment:95103 to this result, which I think means it worked:
review from IRC:
I would suggest using that code without the assert. The
for
will raise an exception in any case ifarray_of*requires*
is not iterable.Fixed in [575d7a2] (without the assert).