Inconsistent 'tahoe cp' behavior #2027
Labels
No Label
0.2.0
0.3.0
0.4.0
0.5.0
0.5.1
0.6.0
0.6.1
0.7.0
0.8.0
0.9.0
1.0.0
1.1.0
1.10.0
1.10.1
1.10.2
1.10a2
1.11.0
1.12.0
1.12.1
1.13.0
1.14.0
1.15.0
1.15.1
1.2.0
1.3.0
1.4.1
1.5.0
1.6.0
1.6.1
1.7.0
1.7.1
1.7β
1.8.0
1.8.1
1.8.2
1.8.3
1.8β
1.9.0
1.9.0-s3branch
1.9.0a1
1.9.0a2
1.9.0b1
1.9.1
1.9.2
1.9.2a1
LeastAuthority.com automation
blocker
cannot reproduce
cloud-branch
code
code-dirnodes
code-encoding
code-frontend
code-frontend-cli
code-frontend-ftp-sftp
code-frontend-magic-folder
code-frontend-web
code-mutable
code-network
code-nodeadmin
code-peerselection
code-storage
contrib
critical
defect
dev-infrastructure
documentation
duplicate
enhancement
fixed
invalid
major
minor
n/a
normal
operational
packaging
somebody else's problem
supercritical
task
trivial
unknown
was already fixed
website
wontfix
worksforme
No Milestone
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Reference: tahoe-lafs/trac-2024-07-25#2027
Loading…
Reference in New Issue
Block a user
No description provided.
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
When copying a file from the top level of a directory node using the CLI, tahoe requires a file name to be specified.
Ex:
tahoe cp tahoe:Seattle.jpg ~
fails with the following assertion traceback, whiletahoe cp tahoe:Seattle.jpg ~/Seattle.jpg
succeeds.However, when a file is copied from a subdirectory to the local disk without a specified file name, the download will succeed.
Ex:
tahoe cp tahoe:test/Seattle.jpg ~
succeeds along withtahoe cp tahoe:test/Seattle.jpg ~/Seattle.jpg
.All four cases should succeed.
All four cases in the description should succeed.
Inconsistent 'tahoe cp' Behaviorto Inconsistent 'tahoe cp' behaviorHere is my branch for this ticket: https://github.com/markberger/tahoe-lafs/tree/2027-inconsistent-tahoe-cp
On my branch there is a test for this ticket and a patch that solves this issue.
We discussed this ticket on the Dev Chat, and concluded that it needed more work because the Unicode coercion is in the wrong place (it should be moved up in the call stack, at least to the caller of
copy_files_to_target
).Reviewing.
#2029 was merged into this ticket.
I'd like to contribute to this issue, but there is no branch starting with "2027" in tahoe-lafs.git on github. I'm now confused about whether I should look in daira's github repo, or markberger's github repo... or what?
Where's the latest code?
The latest code, rebased to master, is now at https://github.com/tahoe-lafs/tahoe-lafs/commits/2027-inconsistent-tahoe-cp-1.
However, this ticket is blocked on #2235 which changes how
tahoe cp
does Unicode coercion. Please don't commit it until that is fixed.See https://github.com/tahoe-lafs/tahoe-lafs/pull/138 (last two patches).
Huh, those two commits are in a different order in the github pull request view than they are on the branch (https://github.com/tahoe-lafs/tahoe-lafs/commits/2235-long-paths-on-windows-7).
On the pull request I see (topmost patch first):
but on the branch, d70d74a is the penultimate patch, just before [536fe30].
Note that this could potentially interact with #2329.
Replying to daira:
https://help.github.com/articles/why-are-my-commits-in-the-wrong-order/ suggests a possibility, but I didn't rebase that branch.
Replying to [daira]comment:17:
Actually I think I did rebase it and just forgot.
Fixed on the pr138 branch which was merged in [3afe827ad0cbdb41b2928d17c8bfbbaf5102acc8/trunk].
(Woohoo! This set of bugs has been irking me for some time.)