include git branch name in the --version[-and-path] output #1953

New Issue

tahoe-lafs · 2013-04-24T13:58:07Z

daira commented

2013-04-24 13:58:07 +00:00

The linear versioning of the Tahoe code makes it difficult to distinguish branches (such as the I2P branch or the cloud backend branch). In /tahoe-lafs/trac-2024-07-25/issues/6971#comment:91529 Zooko suggests to change the appname in the I2P branch, but that falls foul of #1159. It also depends on branch maintainers to remember to do the right thing, which is quite inconvenient given that the code needs to be patched to change the appname. If tahoe --version[-and-path] (and the version info on the Welcome page) showed the git branch name, that would be much better I think.

The linear versioning of the Tahoe code makes it difficult to distinguish branches (such as the I2P branch or the cloud backend branch). In [/tahoe-lafs/trac-2024-07-25/issues/6971](/tahoe-lafs/trac-2024-07-25/issues/6971)#[comment:91529](/tahoe-lafs/trac-2024-07-25/issues/1953#issuecomment-91529) Zooko suggests to change the appname in the I2P branch, but that falls foul of #1159. It also depends on branch maintainers to remember to do the right thing, which is quite inconvenient given that the code needs to be patched to change the appname. If `tahoe --version[-and-path]` (and the version info on the Welcome page) showed the git branch name, that would be much better I think.

tahoe-lafs added the

labels 2013-04-24 13:58:07 +00:00

tahoe-lafs added this to the soon milestone 2013-04-24 13:58:07 +00:00

daira commented

2013-04-24 15:32:25 +00:00

Please review: https://github.com/tahoe-lafs/tahoe-lafs/commit/1953-branch-in-version.

Please review: <https://github.com/tahoe-lafs/tahoe-lafs/commit/1953-branch-in-version>.

warner commented

2013-04-24 22:46:51 +00:00

I made one comment on that patch, but otherwise it seems good. I don't want to add it to 1.10, though, feels slightly risky this late in the process.

warner modified the milestone from soon to 1.11.0

2013-04-24 22:46:51 +00:00

Daira Hopwood <david-sarah@jacaranda.org> commented

2013-05-01 21:39:53 +00:00

In changeset:8a1b2c7aa6f10882:

Show git branch in version output. fixes #1953
Also make sure strings in _version.py are correctly escaped, and repair a test.

Signed-off-by: Daira Hopwood <david-sarah@jacaranda.org>

In changeset:8a1b2c7aa6f10882: ``` Show git branch in version output. fixes #1953 Also make sure strings in _version.py are correctly escaped, and repair a test. Signed-off-by: Daira Hopwood <david-sarah@jacaranda.org> ```

tahoe-lafs added the

fixed

label 2013-05-01 21:39:53 +00:00

tahoe-lafs closed this issue

2013-05-01 21:39:53 +00:00

Sign in to join this conversation.