tahoe cp --verbose progress messages show double the actual number of files #1783

New Issue

tahoe-lafs · 2012-06-30T16:02:23Z

davidsarah commented

2012-06-30 16:02:23 +00:00

$ ls test
bar  baz  foo
$ bin/tahoe cp --verbose test/* test2:
examining 0 of 5
examining 1 of 5
examining 2 of 5
examining 3 of 5
examining 4 of 5
attaching sources to targets, 3 files / 0 dirs in root
targets assigned, 1 dirs, 6 files
starting copy, 6 files, 1 directories
1/6 files, 0/1 directories
2/6 files, 0/1 directories
3/6 files, 0/1 directories
1/1 directories
Success: files copied

``` $ ls test bar baz foo $ bin/tahoe cp --verbose test/* test2: examining 0 of 5 examining 1 of 5 examining 2 of 5 examining 3 of 5 examining 4 of 5 attaching sources to targets, 3 files / 0 dirs in root targets assigned, 1 dirs, 6 files starting copy, 6 files, 1 directories 1/6 files, 0/1 directories 2/6 files, 0/1 directories 3/6 files, 0/1 directories 1/1 directories Success: files copied ```

tahoe-lafs added the

labels 2012-06-30 16:02:23 +00:00

tahoe-lafs added this to the 1.10.0 milestone 2012-06-30 16:02:23 +00:00

davidsarah commented

2012-06-30 16:03:57 +00:00

Thanks to sickness for reporting this.

davidsarah commented

2012-06-30 16:06:34 +00:00

Another minor issue we can fix at the same time is that the "examining %d of %d" outputs should probably be 1-based rather than 0-based.

Another minor issue we can fix at the same time is that the `"examining %d of %d"` outputs should probably be 1-based rather than 0-based.

davidsarah commented

2012-11-22 01:33:45 +00:00

Replying to davidsarah:

Another minor issue we can fix at the same time is that the "examining %d of %d" outputs should probably be 1-based rather than 0-based.

That was #1805, now fixed. I don't think this issue was fixed.

Replying to [davidsarah](/tahoe-lafs/trac-2024-07-25/issues/1783#issuecomment-89209): > Another minor issue we can fix at the same time is that the `"examining %d of %d"` outputs should probably be 1-based rather than 0-based. That was #1805, now fixed. I don't think this issue was fixed.

davidsarah commented

2013-03-20 01:02:40 +00:00

The problem was that in the loop at source:git/src/allmydata/scripts/tahoe_cp.py@595d611c#L653, self.files_to_copy is incremented by both attach_to_target and the loop body.

Please review: https://github.com/davidsarah/tahoe-lafs/commit/1783-no-double-counting

The problem was that in the loop at source:git/src/allmydata/scripts/tahoe_cp.py@595d611c#L653, `self.files_to_copy` is incremented by both `attach_to_target` and the loop body. Please review: <https://github.com/davidsarah/tahoe-lafs/commit/1783-no-double-counting>

warner commented

2013-03-20 19:05:30 +00:00

Looks good, landed in changeset:ef0a6c30.

warner added the

fixed

label 2013-03-20 19:05:30 +00:00

warner closed this issue

2013-03-20 19:05:30 +00:00

Sign in to join this conversation.