redesigned welcome page #1713
Labels
No Label
0.2.0
0.3.0
0.4.0
0.5.0
0.5.1
0.6.0
0.6.1
0.7.0
0.8.0
0.9.0
1.0.0
1.1.0
1.10.0
1.10.1
1.10.2
1.10a2
1.11.0
1.12.0
1.12.1
1.13.0
1.14.0
1.15.0
1.15.1
1.2.0
1.3.0
1.4.1
1.5.0
1.6.0
1.6.1
1.7.0
1.7.1
1.7β
1.8.0
1.8.1
1.8.2
1.8.3
1.8β
1.9.0
1.9.0-s3branch
1.9.0a1
1.9.0a2
1.9.0b1
1.9.1
1.9.2
1.9.2a1
LeastAuthority.com automation
blocker
cannot reproduce
cloud-branch
code
code-dirnodes
code-encoding
code-frontend
code-frontend-cli
code-frontend-ftp-sftp
code-frontend-magic-folder
code-frontend-web
code-mutable
code-network
code-nodeadmin
code-peerselection
code-storage
contrib
critical
defect
dev-infrastructure
documentation
duplicate
enhancement
fixed
invalid
major
minor
n/a
normal
operational
packaging
somebody else's problem
supercritical
task
trivial
unknown
was already fixed
website
wontfix
worksforme
No Milestone
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Reference: tahoe-lafs/trac-2024-07-25#1713
Loading…
Reference in New Issue
Block a user
No description provided.
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
I've integrated the redesign of the welcome page I did using Twitter Bootstrap and it's actually mostly usable now. I submitted a pull request on Github here:
https://github.com/warner/tahoe-lafs/pull/5
There's still some work to be done to get all of the links working, and the Open URI box needs to be wired up, but the overall majority of the work is done and I think it's looking a lot nicer than the old version.
Here's an earlier work-in-progress screenshot. The version I'm submitting looks even nicer, IMO:
http://i.imgur.com/ftZ8W.png
Screenshot of the actual version in the pull request available here:
http://i.imgur.com/tf1iJ.png
I like it :thumbs-up:
I like the general layout. The file upload and directory creation functions seem to be behind links when they were previously on the welcome page. I know they were a bit ugly, but there's enough room for them and perhaps we can make them less ugly.
(I changed the ticket summary because it's not really relevant that the prototype was done using Twitter Bootstrap.)
Twitter Bootstrap-based welcome pageto redesigned welcome pageYeah, treat anything you see as a concept that's easily changed. You can add another "well" in the Bootstrap terminology which contains the file upload form.
One of the nice things about Bootstrap is that it's extremely well documented, so getting all of the original features back and working again should be something anyone should be able to pull off, and if you use Bootstrap's idioms the visual design should end up looking pretty nice as well:
http://twitter.github.com/bootstrap/scaffolding.html
http://twitter.github.com/bootstrap/components.html
If no one will volunteer to do the rest of the work to get this all of the way there I can finish it up, but I was hoping someone would like it enough to get whatever remains to be done finished for me ;)
New pull request from tarcieri: https://github.com/tahoe-lafs/tahoe-lafs/pull/19
I redesigned the sidebar as follows:
http://i.imgur.com/1Epjv.png
I've also deleted all the script tags on the page as there were concerns about them (there was at least one script loading from a third party domain)
There's a couple concerns left:
There's a single test failure in test_web.py line 3087, in _after_get_welcome_page probably due to the altered markup
davidsarah noted that the file download input boxes aren't labeled properly more and look confusing
Looks awesome! I'm going to one last review pass and get this landed on trunk, where it will be included in 1.10.
I gave this interface a whirl and immediately learned about new features (like the timeline!) that I hadn't used before. And all the functionality I'm used to from the front-page is still intact. So +1 I really like this update and look forward to its integration, and also (additionally, not as a prerequisite) to this style being applied to the rest of the WUI pages.
I'm currently rebasing this and fixing tests.
https://github.com/tahoe-lafs/tahoe-lafs/commits/1713-bootstrapped-welcome-page
Please test for usability and regressions!
This adds back the Report Incident form, avoiding a regression pointed out by warner. It also removes the PNG icon files and
bootstrap-responsive.css
, which were unused, and it renamesstatic/css/tahoe.css
tonew-tahoe.css
to avoid confusion with the existingstatic/tahoe.css
. (We may merge them at some point though.)Also see #1931 for possible aesthetic improvements (as opposed to functionality).
The following CSS warnings are reported by Firefox 17:
Most of them appear to be relatively harmless uses of deprecated Mozilla-specific properties.
Hmm, this was a bug:
Now fixed.
The branch has been rebased on top of the fixes for #1746 and #1775.
The new Welcome page does not work at all on Internet Explorer 8 ("This page cannot be displayed."). Should that be considered a blocker?
I tried forcing it into or out of Compatibility Mode but that didn't help (it's just the chicken you always have to wave in the air for any IE problem).
Replying to davidsarah:
I was mistaken; see ticket:1931#comment:-1.
Having the connected/not-connected indicator be a red or green bullet without any change in text, is an accessibility regression for colourblind people, so I would like to fix that before the release.
Landed in 709be93a. \o/
I will fix the accessibility problem mentioned in comment:88146.
Replying to davidsarah:
Please review: https://github.com/davidsarah/tahoe-lafs/commit/1713-accessibility.
Fix for comment:88146 committed in 1f38c920. It still needs review.
In changeset:1f38c920119aa66e:
That last fix looks fine. It seems slightly weird to have a rendering function delegate-to-self and then compare the result against a string (i.e.
data_introducer_description()
callsself.data_connected_to_introducer()
and sees if the return value is"no"
. In the future, we should probably factor out an internal function that returns a boolean instead. But that code is cool for now.I'm trying the new welcome page web interface after downloading allmydata-tahoe-1.10b1.post1.zip
I've built the release and configured a simple 3 node introducer/storage/client on the same box just
to see how the new web interface is
first of all I noticed that the introducer interface still has the old style
then I've noticed that on firefox 20.0 on 1024x600 resolution lots of things overlap
screenshots of introducer, storage, client web interface provided
introducer http://www.pr0n.it/tahoeintroducer1.10b1.post1.png
storage http://www.pr0n.it/tahoestorage1.10b1.post1.png
client http://www.pr0n.it/tahoeclient1.10b1.post1.png