tahoe-lafs/trac-2024-07-25
2
0
Issues 1.1k Wiki

Patch to add a favicon to the web UI #1592

New Issue
Closed
opened 2011-11-19 21:49:56 +00:00 by marcusw · 13 comments
marcusw commented 2011-11-19 21:49:56 +00:00
Owner
Copy Link

I came up with a small (almost trivial) git branch to add a favicon to the web UI. More information is available at the commit page on github.

I came up with a small (almost trivial) [git branch](https://github.com/marcuswanner/tahoe-lafs/tree/favicon) to add [a favicon](@@https://tahoe-lafs.org/trac/tahoe-lafs/ticket/1185#[comment:86533](/tahoe-lafs/trac-2024-07-25/issues/1592#issuecomment-86533)@@) to the web UI. More information is available at the [commit page](https://github.com/marcuswanner/tahoe-lafs/commit/b3ee8882f0819cab0efdcf1b7620bc9c74b2ff2f) on github.
tahoe-lafs added the
code-frontend-web
minor
enhancement
1.9.0
 labels 2011-11-19 21:49:56 +00:00
tahoe-lafs added this to the undecided milestone 2011-11-19 21:49:56 +00:00
davidsarah commented 2011-11-19 23:12:52 +00:00
Author
Owner
Copy Link

I reviewed the XHTML changes on the git branch and they look good. I confirmed that those are all the XHTML files that need to be changed. I also like the favicon (if we're staying with Kevin Reid's icon more generally).

CC BY 3.0 Unported is not compatible with GPL, primarily because of the attribution requirement. (I hate acting the part of license compatibility enforcer, but care about getting updates to Tahoe-LAFS into distributions like Debian that are strict about that.) This probably means that Kevin Reid's icon needs to be relicensed, so that the derived favicon can be.

I reviewed the XHTML changes on the [git branch](https://github.com/marcuswanner/tahoe-lafs/commit/b3ee8882f0819cab0efdcf1b7620bc9c74b2ff2f) and they look good. I confirmed that those are all the XHTML files that need to be changed. I also like the favicon (if we're staying with Kevin Reid's icon more generally). [CC BY 3.0 Unported](https://creativecommons.org/licenses/by/3.0/) is [not compatible with GPL](https://www.gnu.org/licenses/license-list.html#ccby), primarily because of the attribution requirement. (I hate acting the part of license compatibility enforcer, but care about getting updates to Tahoe-LAFS into distributions like Debian that are strict about that.) This probably means that Kevin Reid's icon needs to be relicensed, so that the derived favicon can be.
tahoe-lafs modified the milestone from undecided to 1.10.0 2011-11-19 23:13:26 +00:00
marcusw commented 2011-11-20 02:15:16 +00:00
Author
Owner
Copy Link

I was afraid of the licensing issues and totally understand (hence the long-winded git comment). Bad things happen to projects with sloppy copyright. Have you contacted kreid about relicensing?

If he agrees, you've got the go-ahead from me to relicense my derivative (the 16x16 icon) under whatever conditions he chooses.

I was afraid of the licensing issues and totally understand (hence the long-winded git comment). Bad things happen to projects with sloppy copyright. Have you contacted kreid about relicensing? If he agrees, you've got the go-ahead from me to relicense my derivative (the 16x16 icon) under whatever conditions he chooses.
zooko commented 2011-11-20 06:30:43 +00:00
Copy Link

Dear Kevin: may we please have permission to use your Tahoe-LAFS logo contributions under the same licences as Tahoe-LAFS itself? Actually, would you mind granting the Tahoe-LAFS Software Foundation permission to use it however that entity sees fit, with little or no restriction? Thank you!

(The reason we're asking is to include a favicon derived from your logo in the Tahoe-LAFS distribution to include in the WUI.)

Dear Kevin: may we please have permission to use your Tahoe-LAFS logo contributions under the same licences as Tahoe-LAFS itself? Actually, would you mind granting the Tahoe-LAFS Software Foundation permission to use it however that entity sees fit, with little or no restriction? Thank you! (The reason we're asking is to include a favicon derived from your logo in the Tahoe-LAFS distribution to include in the WUI.)
kpreid commented 2011-11-27 14:54:49 +00:00
Copy Link

I hereby give permission for my Tahoe logo designs and SVG files (all material at http://switchb.org/kpreid/2009/tahoe/ ) to reused, modified, and distributed under the same license(s) as Tahoe-LAFS itself, including any future relicensing or other such change which the developer community has consensus upon.

I hereby give permission for my Tahoe logo designs and SVG files (all material at <http://switchb.org/kpreid/2009/tahoe/> ) to reused, modified, and distributed under the same license(s) as Tahoe-LAFS itself, including any future relicensing or other such change which the developer community has consensus upon.
marcusw commented 2011-12-16 16:56:44 +00:00
Author
Owner
Copy Link

Any idea when/whether this will be landed?

Any idea when/whether this will be landed?
zooko commented 2011-12-16 23:23:56 +00:00
Copy Link

I removed the licensing keyword. Thanks, Kevin! I don't see either a review-needed keyword or a reviewed keyword so I can't tell instantly what state this ticket is in. Someone please push this ticket further along! https://tahoe-lafs.org/trac/tahoe-lafs/wiki/PatchReviewProcess

I removed the `licensing` keyword. Thanks, Kevin! I don't see either a `review-needed` keyword or a `reviewed` keyword so I can't tell instantly what state this ticket is in. Someone please push this ticket further along! <https://tahoe-lafs.org/trac/tahoe-lafs/wiki/PatchReviewProcess>
davidsarah commented 2011-12-17 01:43:26 +00:00
Author
Owner
Copy Link

marcusw: your changes are still under the license at https://github.com/marcuswanner/tahoe-lafs/commit/b3ee8882f0819cab0efdcf1b7620bc9c74b2ff2f . You need to relax that license, as kpreid did.

marcusw: your changes are still under the license at <https://github.com/marcuswanner/tahoe-lafs/commit/b3ee8882f0819cab0efdcf1b7620bc9c74b2ff2f> . You need to relax that license, as kpreid did.
marcusw commented 2011-12-17 01:50:28 +00:00
Author
Owner
Copy Link

I hereby give permission for my Tahoe logo designs and SVG files previously referenced in this ticket and that git commit message to be reused, modified, and distributed under the same license(s) as Tahoe-LAFS itself, including any future relicensing or other such change which the developer community has consensus upon. This release is in addition to the one on the git branch message.

The same applies to the files linked to in (@@https://tahoe-lafs.org/trac/tahoe-lafs/ticket/1185#comment:-1@@)

I hereby give permission for my Tahoe logo designs and SVG files previously referenced in this ticket and that git commit message to be reused, modified, and distributed under the same license(s) as Tahoe-LAFS itself, including any future relicensing or other such change which the developer community has consensus upon. This release is in addition to the one on the git branch message. The same applies to the files linked to in (@@https://tahoe-lafs.org/trac/tahoe-lafs/ticket/1185#[comment:-1](/tahoe-lafs/trac-2024-07-25/issues/1592#issuecomment--1)@@)
davidsarah commented 2011-12-17 02:02:26 +00:00
Author
Owner
Copy Link

Thanks. Reviewing.

Thanks. Reviewing.
davidsarah commented 2011-12-17 02:05:20 +00:00
Author
Owner
Copy Link

Oh, I already reviewed it in comment:86519. OK, I'll land this now.

Oh, I already reviewed it in [comment:86519](/tahoe-lafs/trac-2024-07-25/issues/1592#issuecomment-86519). OK, I'll land this now.
david-sarah@jacaranda.org commented 2011-12-17 04:35:23 +00:00
Author
Owner
Copy Link

In changeset:054374400e28cb00:

Marcus Wanner's favicon patch. fixes #1592
In changeset:054374400e28cb00: ``` Marcus Wanner's favicon patch. fixes #1592 ```
tahoe-lafs added the
fixed
 label 2011-12-17 04:35:23 +00:00
david-sarah@jacaranda.org closed this issue 2011-12-17 04:35:23 +00:00
davidsarah commented 2011-12-17 04:37:29 +00:00
Author
Owner
Copy Link

I added some tests in changeset:531f562fcfcb7b68. Review needed for those, and also for a cleanup patch changeset:4618571389c62d2f.

I added some tests in changeset:531f562fcfcb7b68. Review needed for those, and also for a cleanup patch changeset:4618571389c62d2f.
tahoe-lafs removed the
fixed
 label 2011-12-17 04:37:29 +00:00
davidsarah reopened this issue 2011-12-17 04:37:29 +00:00
zooko self-assigned this 2011-12-17 15:59:44 +00:00
zooko commented 2011-12-17 16:31:09 +00:00
Copy Link

Reviewed changeset:4618571389c62d2f and changeset:531f562fcfcb7b68.

Reviewed changeset:4618571389c62d2f and changeset:531f562fcfcb7b68.
zooko added the
fixed
 label 2011-12-17 16:31:09 +00:00
zooko closed this issue 2011-12-17 16:31:09 +00:00
tahoe-lafs modified the milestone from 1.10.0 to 1.9.2 2012-03-29 23:30:02 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels   
0.2.0

   
0.3.0

   
0.4.0

   
0.5.0

   
0.5.1

   
0.6.0

   
0.6.1

   
0.7.0

   
0.8.0

   
0.9.0

   
1.0.0

   
1.1.0

   
1.10.0

   
1.10.1

   
1.10.2

   
1.10a2

   
1.11.0

   
1.12.0

   
1.12.1

   
1.13.0

   
1.14.0

   
1.15.0

   
1.15.1

   
1.2.0

   
1.3.0

   
1.4.1

   
1.5.0

   
1.6.0

   
1.6.1

   
1.7.0

   
1.7.1

   
1.7β

   
1.8.0

   
1.8.1

   
1.8.2

   
1.8.3

   
1.8β

   
1.9.0

   
1.9.0-s3branch

   
1.9.0a1

   
1.9.0a2

   
1.9.0b1

   
1.9.1

   
1.9.2

   
1.9.2a1

   
LeastAuthority.com automation

   
blocker

   
cannot reproduce

   
cloud-branch

   
code

catch-all for anything that can be fixed by writing code but isn't classified better

  
code-dirnodes

anything involving tahoe directories

  
code-encoding

immutable-file encoding format/layout, cap format, encoding/decoding algorithms

  
code-frontend

general frontend things: new user-facing interfaces, FTP/SFTP servers, FUSE-like interfaces

  
code-frontend-cli

CLI tools

  
code-frontend-ftp-sftp

   
code-frontend-magic-folder

   
code-frontend-web

webapi interfaces, user-facing "WUI" interfaces

  
code-mutable

anything involving mutable files: encoding/decoding, share format

  
code-network

Introducer, locating storage servers, establishing/maintaining connections to them

  
code-nodeadmin

node startup/shutdown, tools to create nodes, logging tools, management/monitoring tools, manhole, disk-space-limiting tools

  
code-peerselection

server selection/sorting algorithm, rebalancing code, allocation policy, swarming-download

  
code-storage

storage-server implementation, share-storage directory layout, client-to-server share transfer protocol

  
contrib

problems with non-core things that live in the source:contrib/ directory

  
critical

   
defect

   
dev-infrastructure

things that help us build Tahoe: buildbot, automated speed/memory/code-coverage tests and results-displayers, IRC channels, mailing lists, this Trac instance

  
documentation

docs items. Also use 'docs' keyword on tickets in more specific components.

  
duplicate

   
enhancement

   
fixed

   
invalid

   
major

   
minor

   
n/a

   
normal

   
operational

things involved in running a tahoe grid, external tools to monitor/maintain a grid (like "nodeadmin" but larger-scale). Was also used for issues with the allmydata.com grid.

  
packaging

setup.py script, library dependencies, binary packages, licensing, installation instructions

  
somebody else's problem

   
supercritical

   
task

   
trivial

   
unknown

Uncategorized. All tickets default to this component until someone updates it.

  
was already fixed

   
website

things about the tahoe-lafs.org website (and sometimes this Trac instance, shared with 'dev-infrastructure')

  
wontfix

   
worksforme
No Label
0.2.0
0.3.0
0.4.0
0.5.0
0.5.1
0.6.0
0.6.1
0.7.0
0.8.0
0.9.0
1.0.0
1.1.0
1.10.0
1.10.1
1.10.2
1.10a2
1.11.0
1.12.0
1.12.1
1.13.0
1.14.0
1.15.0
1.15.1
1.2.0
1.3.0
1.4.1
1.5.0
1.6.0
1.6.1
1.7.0
1.7.1
1.7β
1.8.0
1.8.1
1.8.2
1.8.3
1.8β
1.9.0
1.9.0-s3branch
1.9.0a1
1.9.0a2
1.9.0b1
1.9.1
1.9.2
1.9.2a1
LeastAuthority.com automation
blocker
cannot reproduce
cloud-branch
code
code-dirnodes
code-encoding
code-frontend
code-frontend-cli
code-frontend-ftp-sftp
code-frontend-magic-folder
code-frontend-web
code-mutable
code-network
code-nodeadmin
code-peerselection
code-storage
contrib
critical
defect
dev-infrastructure
documentation
duplicate
enhancement
fixed
invalid
major
minor
n/a
normal
operational
packaging
somebody else's problem
supercritical
task
trivial
unknown
was already fixed
website
wontfix
worksforme
Milestone
Clear milestone
No items
No Milestone
1.9.2
Assignees
Clear assignees
No Assignees
zooko
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Reference: tahoe-lafs/trac-2024-07-25#1592
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?