separate configuration from instantiation of Client instance #1548

New Issue

zooko · 2011-09-26T21:08:45Z

zooko commented

2011-09-26 21:08:45 +00:00

I'm writing tests of configuration, and currently reading values from the configuration and using them is done inside the constructor of [Client]source:trunk/src/allmydata/client.py?annotate=blame&rev=5232#L111. I would rather there be some separate code that reads the values from configuration and does whatever validation and parsing is necessary and then passes all configuration options as arguments to the constructor of the class. This would be as prescribed in [the CodingStandards document](wiki/CodingStandards).

I'm writing tests of configuration, and currently reading values from the configuration and using them is done inside the constructor of [Client]source:trunk/src/allmydata/client.py?annotate=blame&rev=5232#L111. I would rather there be some separate code that reads the values from configuration and does whatever validation and parsing is necessary and then passes all configuration options as arguments to the constructor of the class. This would be as prescribed in [the [CodingStandards](wiki/CodingStandards) document](wiki/CodingStandards).

zooko added the

labels 2011-09-26 21:08:45 +00:00

zooko added this to the undecided milestone 2011-09-26 21:08:45 +00:00

zooko self-assigned this 2011-09-26 21:08:45 +00:00

zooko commented

2011-09-27 20:01:02 +00:00

Here is a patch to rename Client to ClientAndServer and to put a little shim into place so that .tac files can continue invoking allmydata.client.Client.

Here is a patch to rename `Client` to `ClientAndServer` and to put a little shim into place so that .tac files can continue invoking `allmydata.client.Client`.

zooko commented

2011-09-27 20:01:41 +00:00

Attachment renameClient.dpatch (6695 bytes) added

**Attachment** renameClient.dpatch (6695 bytes) added

renameClient.dpatch

6.5 KiB

davidsarah commented

2011-09-27 22:01:18 +00:00

renameClient.dpatch causes this test failure (looks like just a missing rename):

[ERROR]: allmydata.test.test_upload

Traceback (most recent call last):
  File "/usr/lib/python2.6/dist-packages/twisted/trial/runner.py", line 584, in loadPackage
    module = modinfo.load()
  File "/usr/lib/python2.6/dist-packages/twisted/python/modules.py", line 383, in load
    return self.pathEntry.pythonPath.moduleLoader(self.name)
  File "/usr/lib/python2.6/dist-packages/twisted/python/reflect.py", line 464, in namedAny
    topLevelPackage = _importAndCheckStack(trialname)
  File "/usr/lib/python2.6/dist-packages/twisted/python/reflect.py", line 400, in _importAndCheckStack
    return __import__(importName)
  File "/home/davidsarah/tahoe/ticket999-S3-backend/src/allmydata/test/test_upload.py", line 186, in <module>
    class FakeClient:
  File "/home/davidsarah/tahoe/ticket999-S3-backend/src/allmydata/test/test_upload.py", line 209, in FakeClient
    _secret_holder = client.SecretHolder("lease secret", "convergence secret")
exceptions.AttributeError: 'module' object has no attribute 'SecretHolder'
-------------------------------------------------------------------------------

[renameClient.dpatch](/tahoe-lafs/trac-2024-07-25/attachments/000078ac-a575-bcef-dc7a-acf3ac022fc1) causes this test failure (looks like just a missing rename): ``` [ERROR]: allmydata.test.test_upload Traceback (most recent call last): File "/usr/lib/python2.6/dist-packages/twisted/trial/runner.py", line 584, in loadPackage module = modinfo.load() File "/usr/lib/python2.6/dist-packages/twisted/python/modules.py", line 383, in load return self.pathEntry.pythonPath.moduleLoader(self.name) File "/usr/lib/python2.6/dist-packages/twisted/python/reflect.py", line 464, in namedAny topLevelPackage = _importAndCheckStack(trialname) File "/usr/lib/python2.6/dist-packages/twisted/python/reflect.py", line 400, in _importAndCheckStack return __import__(importName) File "/home/davidsarah/tahoe/ticket999-S3-backend/src/allmydata/test/test_upload.py", line 186, in <module> class FakeClient: File "/home/davidsarah/tahoe/ticket999-S3-backend/src/allmydata/test/test_upload.py", line 209, in FakeClient _secret_holder = client.SecretHolder("lease secret", "convergence secret") exceptions.AttributeError: 'module' object has no attribute 'SecretHolder' ------------------------------------------------------------------------------- ```

davidsarah commented

2011-09-27 22:09:17 +00:00

Attachment 1548-fix-missing-rename.darcs.patch (7776 bytes) added

test/test_upload.py: fix a missing rename of client to clientandserver. refs #1548 (Includes previous patch.)

**Attachment** 1548-fix-missing-rename.darcs.patch (7776 bytes) added test/test_upload.py: fix a missing rename of client to clientandserver. refs #1548 (Includes previous patch.)

1548-fix-missing-rename.darcs.patch

7.6 KiB

tahoe-lafs added

normal

and removed

major

labels 2012-03-29 19:28:00 +00:00

zooko commented

2013-10-14 18:39:59 +00:00

Hm, what's the status of this patch? Is it ready for code review?

daira commented

2013-10-17 15:19:13 +00:00