CLI: make the --mutable-type option value for 'tahoe put' and 'tahoe mkdir' case-insensitive #1527

Closed
opened 2011-09-05 02:09:02 +00:00 by davidsarah · 8 comments
davidsarah commented 2011-09-05 02:09:02 +00:00
Owner

The docs always use uppercase for SDMF and MDMF, so --mutable-type should accept these in uppercase.

The docs always use uppercase for SDMF and MDMF, so `--mutable-type` should accept these in uppercase.
tahoe-lafs added the
code-frontend-cli
minor
defect
1.9.0a1
labels 2011-09-05 02:09:02 +00:00
tahoe-lafs added this to the 1.9.0 milestone 2011-09-05 02:09:02 +00:00
davidsarah commented 2011-09-05 02:12:23 +00:00
Author
Owner

Attachment mutable-type-case-insenstive.darcs.patch (59487 bytes) added

CLI: make the --mutable-type option value for 'tahoe put' and 'tahoe mkdir' case-insensitive, and change --help for these commands accordingly. fixes #1527

**Attachment** mutable-type-case-insenstive.darcs.patch (59487 bytes) added CLI: make the --mutable-type option value for 'tahoe put' and 'tahoe mkdir' case-insensitive, and change --help for these commands accordingly. fixes #1527
davidsarah commented 2011-09-05 02:13:49 +00:00
Author
Owner

The patch also includes a minor code simplification in tahoe_put.py.

The patch also includes a minor code simplification in `tahoe_put.py`.
davidsarah commented 2011-09-05 02:16:19 +00:00
Author
Owner

Note that the change of the default for --mutable-type from False to None just suppresses an unhelpful "[False]default:" in the help synopsis, and has no other effect.

Note that the change of the default for `--mutable-type` from `False` to `None` just suppresses an unhelpful "`[False]default:`" in the help synopsis, and has no other effect.
kevan commented 2011-09-05 18:18:34 +00:00
Author
Owner

Can you add tests for --mutable-type=SDMF and --mutable-type=mdmf to Mkdir.test_mkdir_mutable_type?

Looks good, otherwise.

Can you add tests for `--mutable-type=SDMF` and `--mutable-type=mdmf` to `Mkdir.test_mkdir_mutable_type`? Looks good, otherwise.
davidsarah commented 2011-09-05 23:51:04 +00:00
Author
Owner

Replying to kevan:

Can you add tests for --mutable-type=SDMF and --mutable-type=mdmf to Mkdir.test_mkdir_mutable_type?

Yes, I'll do that tomorrow.

Replying to [kevan](/tahoe-lafs/trac-2024-07-25/issues/1527#issuecomment-85540): > Can you add tests for `--mutable-type=SDMF` and `--mutable-type=mdmf` to `Mkdir.test_mkdir_mutable_type`? Yes, I'll do that tomorrow.
david-sarah@jacaranda.org commented 2011-09-06 18:34:13 +00:00
Author
Owner

In changeset:23f46b758ecb3942:

CLI: make the --mutable-type option value for 'tahoe put' and 'tahoe mkdir' case-insensitive, and change --help for these commands accordingly. fixes #1527
In changeset:23f46b758ecb3942: ``` CLI: make the --mutable-type option value for 'tahoe put' and 'tahoe mkdir' case-insensitive, and change --help for these commands accordingly. fixes #1527 ```
tahoe-lafs added the
fixed
label 2011-09-06 18:34:13 +00:00
david-sarah@jacaranda.org commented 2011-09-06 18:34:14 +00:00
Author
Owner

In changeset:1e59930fda64428f:

CLI: improve test for 'tahoe mkdir --mutable-type='. refs #1527
In changeset:1e59930fda64428f: ``` CLI: improve test for 'tahoe mkdir --mutable-type='. refs #1527 ```
david-sarah@jacaranda.org commented 2011-09-06 18:39:26 +00:00
Author
Owner

In changeset:6b97e6f40720bbe4:

CLI: test_cli.py -- remove an unnecessary call in test_mkdir_mutable_type. refs #1527
In changeset:6b97e6f40720bbe4: ``` CLI: test_cli.py -- remove an unnecessary call in test_mkdir_mutable_type. refs #1527 ```
Sign in to join this conversation.
No Milestone
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Reference: tahoe-lafs/trac-2024-07-25#1527
No description provided.