High latency for 'tahoe get' if 'tahoe put' in parallel #1456
Labels
No Label
0.2.0
0.3.0
0.4.0
0.5.0
0.5.1
0.6.0
0.6.1
0.7.0
0.8.0
0.9.0
1.0.0
1.1.0
1.10.0
1.10.1
1.10.2
1.10a2
1.11.0
1.12.0
1.12.1
1.13.0
1.14.0
1.15.0
1.15.1
1.2.0
1.3.0
1.4.1
1.5.0
1.6.0
1.6.1
1.7.0
1.7.1
1.7β
1.8.0
1.8.1
1.8.2
1.8.3
1.8β
1.9.0
1.9.0-s3branch
1.9.0a1
1.9.0a2
1.9.0b1
1.9.1
1.9.2
1.9.2a1
LeastAuthority.com automation
blocker
cannot reproduce
cloud-branch
code
code-dirnodes
code-encoding
code-frontend
code-frontend-cli
code-frontend-ftp-sftp
code-frontend-magic-folder
code-frontend-web
code-mutable
code-network
code-nodeadmin
code-peerselection
code-storage
contrib
critical
defect
dev-infrastructure
documentation
duplicate
enhancement
fixed
invalid
major
minor
n/a
normal
operational
packaging
somebody else's problem
supercritical
task
trivial
unknown
was already fixed
website
wontfix
worksforme
No Milestone
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Reference: tahoe-lafs/trac-2024-07-25#1456
Loading…
Reference in New Issue
No description provided.
Delete Branch "%!s(<nil>)"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
The two node setup, connected via a VPN and details of the setup can be found here: http://tahoe-lafs.org/pipermail/tahoe-dev/2011-July/006563.html.
Notable was, that if the bandwidth is saturated with another program ('netcat6' in this case), then there was no latency issue for 'tahoe get'. However, with running 'tahoe put' over the same gateway, then the latency went up to about 20 seconds.
I further tried to reproduce the issue within a single host in a KVM instance. One node was set up as a dedicated storage node, the other as a dedicated gateway with no storage. See tahoe.cfg attachments for the detailed node configurations.
The scripted test procedure can be found in the attached test-run.sh.
The results were the following:
Test 0: Download with no parallel upload or limitations: 1.6s average
Test 1: Parallel 'tahoe put', limited to 800kbit/s: 1.8s average
Test 2: Parallel 'tahoe put', tahoe-2 (gateway) limited to 800kbit/s: 87s average
Test 3: Parallel 'tahoe put', tahoe-1 (storage) limited to 800kbit/s: 12s average
For latency of each individual download, see log attachements.
Test 2's individual download times are also very noteworthy in particular. I'm not quite sure whether the 200s and 500s delays are another issue or whether it is an extreme manifestation of the same thing. When I'm repeating the test script, at least one of these highly delayed transfers occures in the beginning of test 2.
For Tests 0 and 1, the 1.6s seem to be a little high for a local transfer of this tiny file, but ok, that latency is just about acceptable.
My actual goal was to be able to run a common httpd and ftpd on top of sshfs using tahoe-lafs. However the results of most tests are too high and influence the usability badly. As there is no feedback for the final user's ftp and http client during the delays, Users might for one thing claim that the service is slow, might abort downloads or applications would abort on their own anyway (with the default settings wget times out after 30s for instance).
During the tests, especially during the downloads that took more than 200s, I didn't notice any cpu usage spikes. I hope that with trickle the limited bandwidth capabilities of the internet uplink as it was the case in the first tests over the VPN could somehow be simulated by that, hopefully with the similar issues in both test setups having the same cause(s).
Attachment tahoe-stats-0.log (50 bytes) added
Log of Test 0: Download with no parallel upload or limitations
Attachment tahoe-stats-1.log (50 bytes) added
Log of Test 1: Parallel 'tahoe put', limited to 800kbit/s
Attachment tahoe-stats-2.log (62 bytes) added
Log of Test 2: Parallel 'tahoe put', tahoe-2 (gateway) limited to 800kbit/s
Attachment tahoe-stats-3.log (59 bytes) added
Log of Test 3: Parallel 'tahoe put', tahoe-1 (storage) limited to 800kbit/s
T_X: thank you for the bug report. It sounds like it might be a serious problem in Tahoe-LAFS. I'm glad you've taken the effort to record detailed measurements and include notes about how you tries to make a minimal, reproducible case. I especially appreciate that you included your test script—very good!
However, I'm still confused and need more help from you to understand what's going on. Could you summarize in one paragraph of English -- like not more than 3 or 4 sentences what is wrong and how you know it is happening?
You're observing dramatically high latency on
tahoe get
in some cases. In fact, in 10 runs oftahoe get
(tahoe-stats-2.log), it took this many seconds:The fact that it took 560 seconds to do a
tahoe get
(after which it completed successfully instead of erroring out?) is definitely an indication of something very wrong. I'm still hoping it turns out to be something wrong in your test rig or scripts rather than in Tahoe-LAFS, but we'll see. :-)So, that's a question. How do we know that the runs that took an order of magnitude longer completed successfully? As far as I can tell from a quick scan of [your script]attachment:test-run.sh#L16, it isn't checking the return value or inspecting the resulting downloaded file to be sure it worked.
(Note this would still be a major problem in Tahoe-LAFS if it waited 560 seconds and failed as if it waited 560 seconds and succeeded, but it would help to understand which is happening).
Thanks!
Replying to zooko:
The issue is that when doing a 'tahoe put' in the background (which is not limited in throughput itself) that a parallel 'tahoe get' seems to be delayed unreasonably long (and I'm considering the 20s delay in the VPN setup as well as the 10s in the VM setup as unreasonable, badly influencing the end user experience). It seems like a tahoe gateway is prefering the 'tahoe put' to the 'tahoe get' - or at least not serving the 'tahoe get' as timely as it should - the 'tahoe get' should always get a response at about the same time as it gets without the parallel 'tahoe put'. I know that this is happening due to the long time the 'tahoe get' needs as seen in test 2 and test 3 as well as in the the vpn setup stated on the mailing list and even when 'tahoe put' saturates the available capacity, it shouldn't take that long for the 19 Bytes to finish downloading.
Replying to zooko:
Actually, the >500s delay I'm having in test 2 was something I didn't expect when setting up this VM configuration as I didn't see that in the VPN test before. I don't know if this issue is related or having a different cause than the 10 or 20s delays. However this delay is very reproducible and always happens during the beginning of test 2, so I think it is an issue within tahoe-lafs.
Replying to zooko:
Hmm, true, but at least 'tahoe get' didn't complain and gave me ten times "tahoe:tahoe-file2download retrieved and written to /tmp/tahoe-file2download" (still have the log in gnu screen session here and just checked). Otherwise it'd be another issue with tahoe not giving an error message - but, sure, I can add a 'rm' and then a check after the 'tahoe get' and run the tests again.
[to correct ms -> s]edited
Can you capture more information from one of those runs that takes a long time, like > 500s? Here are ways to extract more information:
Thanks!
Okay, now with having figured out the cause of #1462, I tried test 2 and had a look at the status page again. And the "download timings" are actually fine, I think:
And actually all other timings on this web status page seem fine too, nothing that is remotely as high as the 500s+.
Instead I noticed that the first mapupdate takes a very, very long time:
'tahoe get' started at Sun Aug 7 17:36:55 BST 2011
Output of web page:
I'll make a tcpdump in a minute.
Here's a 100MB tcpdump capture.
It includes the 'prepare' and the 'test2' part of the test script, as well as some communication with the web interface on port 3457. Interestingly, it seems that the web interface is also totally unresponsive during 'test2'.
The 'tahoe get' started at 18:49:58.
The web interface output is:
Attachment test-run.sh (3533 bytes) added
updated version of the test script
Attachment tahoe-1.2.cfg (1140 bytes) added
updating introducer port (to match the tcpdump, port 38940)
Attachment tahoe-1.cfg (1140 bytes) added
updating introducer port (to match the tcpdump, port 38940)
Attachment tahoe-2.cfg (1139 bytes) added
updating introducer port (to match the tcpdump, port 38940)
T_X: what versions of
tahoe
did you use? If you could try comparing v1.8.2 with today's trunk, that might be informative. My guess is the two shouldn't differ in this behavior, but if they do differ then that might be a good clue.You can get trunk with:
darcs get --lazy http://tahoe-lafs.org/source/darcs/tahoe-lafs/trunk
For test 2 I'm having the following results at the moment.
Current trunk (changeset:37cd111009d0b30e):
1.8.2:
So the very long delay in the beginning seems to be present in both versions. The common latency seems to be slightly lower though.
But looks interesting, that it usually seems to be in the range of 790 and 795 seconds, as if some specific thing needed to time out first.
Don't know if that helps in anyway, but it's with some 'print's I could narrow it down to c.getresponse in common_http.py's do_http, called by tahoe_get's get. The getresponse takes these 700+ seconds to return.
Are the GET and the PUT referencing the same tahoe-side directory? I
wonder if the basic locking we do around the directory's mutable-file
objects (to prevent e.g. two simultaneous writes from the same gateway)
is causing a PUT to block a GET.
There are a couple of convenience methods on dirnodes: things like "add
a new child", or "get a child by a specific name". The add-child method
is really a wrapper around two operations: upload-file, then
attach-child, and only the latter really needs the lock.
My hypothesis is that PUT is using a convenience method which locks the
dirnode during the upload-file phase (which takes a long time), and then
the GET tries to do a list-children operation (to find out the immutable
file that should be downloaded), which blocks until the add-child method
has finished.
If we observed the CHK download to not start until after the PUT's
directory-modification completed (using the "recent uploads and
downloads" page, or maybe
flogtool tail
), that'd be supportingevidence.
Some code notes:
(
ReplaceMeMixin.replace_me_with_a_child
) callsself.parentnode.add_file
DirectoryNode.add_file
) callsupload()
, thenself._create_and_validate_node
, thenself.set_node
Hrm, maybe not: the locks are all in the mutable-file object, not the
dirnode, so the lock shouldn't be claimed until after the upload is
completely finished. Anyways, maybe there's some other bug in this
direction.. worth considering.
Short update: The cause of the delay has to be even before twisted/web/http.py's HTTPChannel's lineReceived. First added a 'print' at the beginning of tahoe-lafs's web/filenode.py's FileNodeHandler's render_GET, but both the 'print' in tahoe-lafs and in twisted still suffer from the long delay. The cause has to be somewhere even earlier.
Reducing pipeline_size in immutable/layout.py to 1 did not help either.
Hm, the line that you printed could itself be buffered and therefore not appear until sometime after the "print" statement was executed. Maybe throw in a timestamp to be sure about that.
[time_format.iso_utc()]source:trunk/src/allmydata/util/time_format.py?annotate=blame&rev=4005#L11
See also the builtin facility to run the tahoe lafs node [under a profiler]source:trunk/src/allmydata/scripts/startstop_node.py?annotate=blame&rev=5074#L9.
I'm already using statements like
and this printed timestamp is usually already too late, that's why I guess the issue has to be before the lineReceived call.
Hmm, I'm usually running 'tahoe run' instead of 'tahoe start' for the 2nd node, the gateway node doing the put and get, because trickle does not seem to work for 'tahoe start'. But for 'tahoe run' this profiler does not seem to be available.
Therefore I started to do my own, manual profiling... Basically I had a look at a call trace of lineReceived and tried surrounding various function calls in there with print's and timestamps. However, I couldn't find a function consuming this awful lot of time yet. twisted's tcp.py's Connection's doRead never needs more than a second.
Attachment tahoe-run-profile-option.darcs.patch (38675 bytes) added
Add --profile option to 'tahoe run'. refs #1456
Replying to T_X:
tahoe-run-profile-option.darcs.patch should add a
--profile
option totahoe run
. If the command fails with no output, look atNODEDIR/logs/tahoesvc.log
. If it works, the output will be inNODEDIR/profiling_results.prof
. You may have tosudo apt-get install python-profiler
.Attachment profiling_results.prof (98167 bytes) added
Profiling results of node #2 (gateway/client, non-storage node)
Results of test 2, using tahoe-lafs trunk r5166:
See attachment for the profiling results of the gateway node. (you don't need any profiling results of node 1, the dedicated storage node, do you?)
EDIT: This run was done with a bandwidth limited to 200KB/s up+down instead of 100, which reduces the delay proportionally.