code cleanup: stop using IFinishableConsumer in sftpd.py #1295

New Issue

tahoe-lafs · 2011-01-07T05:02:12Z

davidsarah commented

2011-01-07 05:02:12 +00:00

Twisted's IFinishableConsumer interface is likely to be deprecated. OverwriteableFileConsumer in source:src/allmydata/frontends/sftpd.py uses it, but could probably just as well use IConsumer. I'd like to improve the test coverage of OverwriteableFileConsumer first, though.

Twisted's `IFinishableConsumer` interface is [likely to be deprecated](http://twistedmatrix.com/trac/ticket/2661). `OverwriteableFileConsumer` in source:src/allmydata/frontends/sftpd.py uses it, but could probably just as well use `IConsumer`. I'd like to improve the test coverage of `OverwriteableFileConsumer` first, though.

tahoe-lafs added the

labels 2011-01-07 05:02:12 +00:00

tahoe-lafs added this to the undecided milestone 2011-01-07 05:02:12 +00:00

tahoe-lafs changed title from ~~stop using IFinishableConsumer in sftpd.py~~ to code cleanup: stop using IFinishableConsumer in sftpd.py

2011-01-07 05:02:33 +00:00

davidsarah commented

2011-09-15 18:05:23 +00:00

This will be done as part of #1525 (and I was right about it being a bad idea to use IFinishableConsumer; that was part of the reason for the issue in #1525).

tahoe-lafs modified the milestone from undecided to soon

2011-09-15 18:05:23 +00:00

david-sarah@jacaranda.org commented

2012-03-14 23:48:39 +00:00

In changeset:421b8b9369cd018d:

Temporarily suppress the DeprecationWarning about IFinishableConsumer; it's irritating, but not in a way that is likely to make me fix the underlying issue (#1525) any sooner :-). refs #1295

In changeset:421b8b9369cd018d: ``` Temporarily suppress the DeprecationWarning about IFinishableConsumer; it's irritating, but not in a way that is likely to make me fix the underlying issue (#1525) any sooner :-). refs #1295 ```

david-sarah@jacaranda.org commented

2012-03-14 23:51:11 +00:00

In changeset:cef646c4a70537d6:

Fix a missing comma in the last patch. refs #1295

In changeset:cef646c4a70537d6: ``` Fix a missing comma in the last patch. refs #1295 ```

david-sarah <david-sarah@jacaranda.org> commented

2012-03-15 17:21:23 +00:00

In changeset:cef646c4a70537d6:

Fix a missing comma in the last patch. refs #1295

In changeset:cef646c4a70537d6: ``` Fix a missing comma in the last patch. refs #1295 ```

david-sarah@jacaranda.org commented

2012-06-14 21:29:56 +00:00

In changeset:854afc095f033269:

Suppress DeprecationWarning about twisted.internet.interfaces.IFinishableConsumer. This also unifies the handling of DeprecationWarnings that need to be suppressed globally. refs #1295

In changeset:854afc095f033269: ``` Suppress DeprecationWarning about twisted.internet.interfaces.IFinishableConsumer. This also unifies the handling of DeprecationWarnings that need to be suppressed globally. refs #1295 ```

david-sarah@jacaranda.org commented

2012-06-14 21:31:14 +00:00

In changeset:5513/1.9.2:

Suppress DeprecationWarning about twisted.internet.interfaces.IFinishableConsumer. This also unifies the handling of DeprecationWarnings that need to be suppressed globally. refs #1295

In changeset:5513/1.9.2: ``` Suppress DeprecationWarning about twisted.internet.interfaces.IFinishableConsumer. This also unifies the handling of DeprecationWarnings that need to be suppressed globally. refs #1295 ```

david-sarah@jacaranda.org commented

2012-06-14 21:34:04 +00:00

In changeset:2c4ea1df5fbf89c5:

Since DeprecationWarning about twisted.internet.interfaces.IFinishableConsumer is suppressed globally, it doesn't need to be suppressed during import. refs #1295

In changeset:2c4ea1df5fbf89c5: ``` Since DeprecationWarning about twisted.internet.interfaces.IFinishableConsumer is suppressed globally, it doesn't need to be suppressed during import. refs #1295 ```

david-sarah@jacaranda.org commented

2012-06-14 21:35:04 +00:00

In changeset:5515/1.9.2:

Since DeprecationWarning about twisted.internet.interfaces.IFinishableConsumer is suppressed globally, it doesn't need to be suppressed during import. refs #1295

In changeset:5515/1.9.2: ``` Since DeprecationWarning about twisted.internet.interfaces.IFinishableConsumer is suppressed globally, it doesn't need to be suppressed during import. refs #1295 ```

davidsarah commented

2012-06-14 21:37:41 +00:00

The reason for the patches in comment:81771 -- comment:81774 was that sftpd.py wasn't being imported at the point where the suppression was active, so the suppression wasn't previously working.

The reason for the patches in [comment:81771](/tahoe-lafs/trac-2024-07-25/issues/1295#issuecomment-81771) -- [comment:81774](/tahoe-lafs/trac-2024-07-25/issues/1295#issuecomment-81774) was that `sftpd.py` wasn't being imported at the point where the suppression was active, so the suppression wasn't previously working.

david-sarah <david-sarah@jacaranda.org> commented

2012-06-14 22:04:22 +00:00

In changeset:2c4ea1df5fbf89c5:

Since DeprecationWarning about twisted.internet.interfaces.IFinishableConsumer is suppressed globally, it doesn't need to be suppressed during import. refs #1295

In changeset:2c4ea1df5fbf89c5: ``` Since DeprecationWarning about twisted.internet.interfaces.IFinishableConsumer is suppressed globally, it doesn't need to be suppressed during import. refs #1295 ```

david-sarah@jacaranda.org commented

2012-07-10 20:04:58 +00:00

In changeset:5862/cloud-backend:

Suppress DeprecationWarning about twisted.internet.interfaces.IFinishableConsumer. This also unifies the handling of DeprecationWarnings that need to be suppressed globally. refs #1295

In changeset:5862/cloud-backend: ``` Suppress DeprecationWarning about twisted.internet.interfaces.IFinishableConsumer. This also unifies the handling of DeprecationWarnings that need to be suppressed globally. refs #1295 ```

david-sarah@jacaranda.org commented

2012-07-13 00:51:39 +00:00

In changeset:5865/cloud-backend:

Since !DeprecationWarning about twisted.internet.interfaces.IFinishableConsumer is suppressed globally, it doesn't need to be suppressed during import. refs #1295

In changeset:5865/cloud-backend: ``` Since !DeprecationWarning about twisted.internet.interfaces.IFinishableConsumer is suppressed globally, it doesn't need to be suppressed during import. refs #1295 ```

davidsarah commented

2013-02-20 21:58:08 +00:00

Twisted 12.3.0 has removed IFinishableConsumer, breaking the SFTP frontend when that version (or newer) is used. This means that just suppressing the warning is no longer sufficient, so I'm resolving this as a duplicate of #1525, which would fix the underlying problem.

Twisted 12.3.0 has removed `IFinishableConsumer`, breaking the SFTP frontend when that version (or newer) is used. This means that just suppressing the warning is no longer sufficient, so I'm resolving this as a duplicate of #1525, which would fix the underlying problem.

tahoe-lafs added

normal

duplicate

and removed

minor

labels 2013-02-20 21:58:08 +00:00

tahoe-lafs modified the milestone from soon to 1.10.0

2013-02-20 21:58:08 +00:00

davidsarah closed this issue

2013-02-20 21:58:08 +00:00

Sign in to join this conversation.