tahoe-lafs/trac-2024-07-25
2
0
Issues 1.1k Wiki

code cleanup: stop using IFinishableConsumer in sftpd.py #1295

New Issue
Closed
opened 2011-01-07 05:02:12 +00:00 by davidsarah · 13 comments
davidsarah commented 2011-01-07 05:02:12 +00:00
Owner
Copy Link

Twisted's IFinishableConsumer interface is likely to be deprecated. OverwriteableFileConsumer in source:src/allmydata/frontends/sftpd.py uses it, but could probably just as well use IConsumer. I'd like to improve the test coverage of OverwriteableFileConsumer first, though.

Twisted's `IFinishableConsumer` interface is [likely to be deprecated](http://twistedmatrix.com/trac/ticket/2661). `OverwriteableFileConsumer` in source:src/allmydata/frontends/sftpd.py uses it, but could probably just as well use `IConsumer`. I'd like to improve the test coverage of `OverwriteableFileConsumer` first, though.
tahoe-lafs added the
code-frontend
minor
defect
1.8.1
 labels 2011-01-07 05:02:12 +00:00
tahoe-lafs added this to the undecided milestone 2011-01-07 05:02:12 +00:00
tahoe-lafs changed title from stop using IFinishableConsumer in sftpd.py to code cleanup: stop using IFinishableConsumer in sftpd.py 2011-01-07 05:02:33 +00:00
davidsarah commented 2011-09-15 18:05:23 +00:00
Author
Owner
Copy Link

This will be done as part of #1525 (and I was right about it being a bad idea to use IFinishableConsumer; that was part of the reason for the issue in #1525).

This will be done as part of #1525 (and I was right about it being a bad idea to use IFinishableConsumer; that was part of the reason for the issue in #1525).
tahoe-lafs modified the milestone from undecided to soon 2011-09-15 18:05:23 +00:00
david-sarah@jacaranda.org commented 2012-03-14 23:48:39 +00:00
Author
Owner
Copy Link

In changeset:421b8b9369cd018d:

Temporarily suppress the DeprecationWarning about IFinishableConsumer; it's irritating, but not in a way that is likely to make me fix the underlying issue (#1525) any sooner :-). refs #1295
In changeset:421b8b9369cd018d: ``` Temporarily suppress the DeprecationWarning about IFinishableConsumer; it's irritating, but not in a way that is likely to make me fix the underlying issue (#1525) any sooner :-). refs #1295 ```
david-sarah@jacaranda.org commented 2012-03-14 23:51:11 +00:00
Author
Owner
Copy Link

In changeset:cef646c4a70537d6:

Fix a missing comma in the last patch. refs #1295
In changeset:cef646c4a70537d6: ``` Fix a missing comma in the last patch. refs #1295 ```
david-sarah <david-sarah@jacaranda.org> commented 2012-03-15 17:21:23 +00:00
Author
Owner
Copy Link

In changeset:cef646c4a70537d6:

Fix a missing comma in the last patch. refs #1295
In changeset:cef646c4a70537d6: ``` Fix a missing comma in the last patch. refs #1295 ```
david-sarah@jacaranda.org commented 2012-06-14 21:29:56 +00:00
Author
Owner
Copy Link

In changeset:854afc095f033269:

Suppress DeprecationWarning about twisted.internet.interfaces.IFinishableConsumer. This also unifies the handling of DeprecationWarnings that need to be suppressed globally. refs #1295
In changeset:854afc095f033269: ``` Suppress DeprecationWarning about twisted.internet.interfaces.IFinishableConsumer. This also unifies the handling of DeprecationWarnings that need to be suppressed globally. refs #1295 ```
david-sarah@jacaranda.org commented 2012-06-14 21:31:14 +00:00
Author
Owner
Copy Link

In changeset:5513/1.9.2:

Suppress DeprecationWarning about twisted.internet.interfaces.IFinishableConsumer. This also unifies the handling of DeprecationWarnings that need to be suppressed globally. refs #1295
In changeset:5513/1.9.2: ``` Suppress DeprecationWarning about twisted.internet.interfaces.IFinishableConsumer. This also unifies the handling of DeprecationWarnings that need to be suppressed globally. refs #1295 ```
david-sarah@jacaranda.org commented 2012-06-14 21:34:04 +00:00
Author
Owner
Copy Link

In changeset:2c4ea1df5fbf89c5:

Since DeprecationWarning about twisted.internet.interfaces.IFinishableConsumer is suppressed globally, it doesn't need to be suppressed during import. refs #1295
In changeset:2c4ea1df5fbf89c5: ``` Since DeprecationWarning about twisted.internet.interfaces.IFinishableConsumer is suppressed globally, it doesn't need to be suppressed during import. refs #1295 ```
david-sarah@jacaranda.org commented 2012-06-14 21:35:04 +00:00
Author
Owner
Copy Link

In changeset:5515/1.9.2:

Since DeprecationWarning about twisted.internet.interfaces.IFinishableConsumer is suppressed globally, it doesn't need to be suppressed during import. refs #1295
In changeset:5515/1.9.2: ``` Since DeprecationWarning about twisted.internet.interfaces.IFinishableConsumer is suppressed globally, it doesn't need to be suppressed during import. refs #1295 ```
davidsarah commented 2012-06-14 21:37:41 +00:00
Author
Owner
Copy Link

The reason for the patches in comment:81771 -- comment:81774 was that sftpd.py wasn't being imported at the point where the suppression was active, so the suppression wasn't previously working.

The reason for the patches in [comment:81771](/tahoe-lafs/trac-2024-07-25/issues/1295#issuecomment-81771) -- [comment:81774](/tahoe-lafs/trac-2024-07-25/issues/1295#issuecomment-81774) was that `sftpd.py` wasn't being imported at the point where the suppression was active, so the suppression wasn't previously working.
david-sarah <david-sarah@jacaranda.org> commented 2012-06-14 22:04:22 +00:00
Author
Owner
Copy Link

In changeset:2c4ea1df5fbf89c5:

Since DeprecationWarning about twisted.internet.interfaces.IFinishableConsumer is suppressed globally, it doesn't need to be suppressed during import. refs #1295
In changeset:2c4ea1df5fbf89c5: ``` Since DeprecationWarning about twisted.internet.interfaces.IFinishableConsumer is suppressed globally, it doesn't need to be suppressed during import. refs #1295 ```
david-sarah@jacaranda.org commented 2012-07-10 20:04:58 +00:00
Author
Owner
Copy Link

In changeset:5862/cloud-backend:

Suppress DeprecationWarning about twisted.internet.interfaces.IFinishableConsumer. This also unifies the handling of DeprecationWarnings that need to be suppressed globally. refs #1295
In changeset:5862/cloud-backend: ``` Suppress DeprecationWarning about twisted.internet.interfaces.IFinishableConsumer. This also unifies the handling of DeprecationWarnings that need to be suppressed globally. refs #1295 ```
david-sarah@jacaranda.org commented 2012-07-13 00:51:39 +00:00
Author
Owner
Copy Link

In changeset:5865/cloud-backend:

Since !DeprecationWarning about twisted.internet.interfaces.IFinishableConsumer is suppressed globally, it doesn't need to be suppressed during import. refs #1295
In changeset:5865/cloud-backend: ``` Since !DeprecationWarning about twisted.internet.interfaces.IFinishableConsumer is suppressed globally, it doesn't need to be suppressed during import. refs #1295 ```
davidsarah commented 2013-02-20 21:58:08 +00:00
Author
Owner
Copy Link

Twisted 12.3.0 has removed IFinishableConsumer, breaking the SFTP frontend when that version (or newer) is used. This means that just suppressing the warning is no longer sufficient, so I'm resolving this as a duplicate of #1525, which would fix the underlying problem.

Twisted 12.3.0 has removed `IFinishableConsumer`, breaking the SFTP frontend when that version (or newer) is used. This means that just suppressing the warning is no longer sufficient, so I'm resolving this as a duplicate of #1525, which would fix the underlying problem.
tahoe-lafs added
normal
duplicate
 and removed
minor
 labels 2013-02-20 21:58:08 +00:00
tahoe-lafs modified the milestone from soon to 1.10.0 2013-02-20 21:58:08 +00:00
davidsarah closed this issue 2013-02-20 21:58:08 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels   
0.2.0

   
0.3.0

   
0.4.0

   
0.5.0

   
0.5.1

   
0.6.0

   
0.6.1

   
0.7.0

   
0.8.0

   
0.9.0

   
1.0.0

   
1.1.0

   
1.10.0

   
1.10.1

   
1.10.2

   
1.10a2

   
1.11.0

   
1.12.0

   
1.12.1

   
1.13.0

   
1.14.0

   
1.15.0

   
1.15.1

   
1.2.0

   
1.3.0

   
1.4.1

   
1.5.0

   
1.6.0

   
1.6.1

   
1.7.0

   
1.7.1

   
1.7β

   
1.8.0

   
1.8.1

   
1.8.2

   
1.8.3

   
1.8β

   
1.9.0

   
1.9.0-s3branch

   
1.9.0a1

   
1.9.0a2

   
1.9.0b1

   
1.9.1

   
1.9.2

   
1.9.2a1

   
LeastAuthority.com automation

   
blocker

   
cannot reproduce

   
cloud-branch

   
code

catch-all for anything that can be fixed by writing code but isn't classified better

  
code-dirnodes

anything involving tahoe directories

  
code-encoding

immutable-file encoding format/layout, cap format, encoding/decoding algorithms

  
code-frontend

general frontend things: new user-facing interfaces, FTP/SFTP servers, FUSE-like interfaces

  
code-frontend-cli

CLI tools

  
code-frontend-ftp-sftp

   
code-frontend-magic-folder

   
code-frontend-web

webapi interfaces, user-facing "WUI" interfaces

  
code-mutable

anything involving mutable files: encoding/decoding, share format

  
code-network

Introducer, locating storage servers, establishing/maintaining connections to them

  
code-nodeadmin

node startup/shutdown, tools to create nodes, logging tools, management/monitoring tools, manhole, disk-space-limiting tools

  
code-peerselection

server selection/sorting algorithm, rebalancing code, allocation policy, swarming-download

  
code-storage

storage-server implementation, share-storage directory layout, client-to-server share transfer protocol

  
contrib

problems with non-core things that live in the source:contrib/ directory

  
critical

   
defect

   
dev-infrastructure

things that help us build Tahoe: buildbot, automated speed/memory/code-coverage tests and results-displayers, IRC channels, mailing lists, this Trac instance

  
documentation

docs items. Also use 'docs' keyword on tickets in more specific components.

  
duplicate

   
enhancement

   
fixed

   
invalid

   
major

   
minor

   
n/a

   
normal

   
operational

things involved in running a tahoe grid, external tools to monitor/maintain a grid (like "nodeadmin" but larger-scale). Was also used for issues with the allmydata.com grid.

  
packaging

setup.py script, library dependencies, binary packages, licensing, installation instructions

  
somebody else's problem

   
supercritical

   
task

   
trivial

   
unknown

Uncategorized. All tickets default to this component until someone updates it.

  
was already fixed

   
website

things about the tahoe-lafs.org website (and sometimes this Trac instance, shared with 'dev-infrastructure')

  
wontfix

   
worksforme
No Label
0.2.0
0.3.0
0.4.0
0.5.0
0.5.1
0.6.0
0.6.1
0.7.0
0.8.0
0.9.0
1.0.0
1.1.0
1.10.0
1.10.1
1.10.2
1.10a2
1.11.0
1.12.0
1.12.1
1.13.0
1.14.0
1.15.0
1.15.1
1.2.0
1.3.0
1.4.1
1.5.0
1.6.0
1.6.1
1.7.0
1.7.1
1.7β
1.8.0
1.8.1
1.8.2
1.8.3
1.8β
1.9.0
1.9.0-s3branch
1.9.0a1
1.9.0a2
1.9.0b1
1.9.1
1.9.2
1.9.2a1
LeastAuthority.com automation
blocker
cannot reproduce
cloud-branch
code
code-dirnodes
code-encoding
code-frontend
code-frontend-cli
code-frontend-ftp-sftp
code-frontend-magic-folder
code-frontend-web
code-mutable
code-network
code-nodeadmin
code-peerselection
code-storage
contrib
critical
defect
dev-infrastructure
documentation
duplicate
enhancement
fixed
invalid
major
minor
n/a
normal
operational
packaging
somebody else's problem
supercritical
task
trivial
unknown
was already fixed
website
wontfix
worksforme
Milestone
Clear milestone
No items
No Milestone
1.10.0
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Reference: tahoe-lafs/trac-2024-07-25#1295
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?