support twistd's --profiler= and --debug options when starting a node #1267

New Issue

tahoe-lafs · 2010-11-21T01:06:18Z

davidsarah commented

2010-11-21 01:06:18 +00:00

tahoe start and tahoe run should take a --profile option, like the twistd command, so that you don't have to run twistd directly when profiling.

twistd's --debug option might also be useful.

`tahoe start` and `tahoe run` should take a `--profile` option, like the `twistd` command, so that you don't have to run `twistd` directly when profiling. `twistd`'s `--debug` option might also be useful.

tahoe-lafs added the

labels 2010-11-21 01:06:18 +00:00

tahoe-lafs added this to the undecided milestone 2010-11-21 01:06:18 +00:00

davidsarah commented

2010-11-21 01:10:52 +00:00

From the output of twistd --help:

  -p, --profile=         Run in profile mode, dumping results to specified file
      --profiler=        Name of the profiler to use (profile, cprofile,
                         hotshot). [default: hotshot]
[...]
  -b, --debug            run the application in the Python Debugger (implies
                         nodaemon), sending SIGUSR2 will drop into debugger

From the output of `twistd --help`: ``` -p, --profile= Run in profile mode, dumping results to specified file --profiler= Name of the profiler to use (profile, cprofile, hotshot). [default: hotshot] [...] -b, --debug run the application in the Python Debugger (implies nodaemon), sending SIGUSR2 will drop into debugger ```

davidsarah commented

2010-11-21 01:26:04 +00:00

Oh, it already does support the --profile option, but not overriding the profiler:

$ bin/tahoe start --help

Usage:  tahoe <command> [command options] start [options]
Options:
[...]
  -p, --profile           Run under the Python profiler, putting results in
                          'profiling_results.prof'.

source:src/allmydata/scripts/startstop_node.py@4765#L57:

    if opts["profile"]:
        args.extend(["--profile=profiling_results.prof", "--savestats",])

Oh, it already does support the `--profile` option, but not overriding the profiler: ``` $ bin/tahoe start --help Usage: tahoe <command> [command options] start [options] Options: [...] -p, --profile Run under the Python profiler, putting results in 'profiling_results.prof'. ``` source:src/allmydata/scripts/startstop_node.py@4765#L57: ``` if opts["profile"]: args.extend(["--profile=profiling_results.prof", "--savestats",]) ```

tahoe-lafs changed title from ~~support twistd's --profile option when starting a node~~ to support twistd's --profiler= and --debug options when starting a node

2010-11-21 01:26:04 +00:00

davidsarah commented

2010-11-24 00:09:22 +00:00

According to francois in /tahoe-lafs/trac-2024-07-25/issues/6326#comment:7, the -n or --nodaemon option to twistd is necessary in order to save profile output.

According to francois in [/tahoe-lafs/trac-2024-07-25/issues/6326](/tahoe-lafs/trac-2024-07-25/issues/6326)#comment:7, the `-n` or `--nodaemon` option to `twistd` is necessary in order to save profile output.

warner commented

2010-11-27 09:37:42 +00:00

What if we accepted a syntax like "tahoe start DIR -- ARG1 ARG2" or "tahoe start -- ARG1 ARG2", and passed all the extra ARG1/ARG2 strings into twistd.run()? I'd really like if it we had a way to pass arbitrary twistd arguments, rather than having to hand-code support for each one.

What if we accepted a syntax like "`tahoe start DIR -- ARG1 ARG2`" or "`tahoe start -- ARG1 ARG2`", and passed all the extra ARG1/ARG2 strings into `twistd.run()`? I'd really like if it we had a way to pass arbitrary twistd arguments, rather than having to hand-code support for each one.

zooko commented

2011-09-26 07:18:32 +00:00

Replying to warner:

What if we accepted a syntax like "tahoe start DIR -- ARG1 ARG2" or "tahoe start -- ARG1 ARG2", and passed all the extra ARG1/ARG2 strings into twistd.run()? I'd really like if it we had a way to pass arbitrary twistd arguments, rather than having to hand-code support for each one.

Created #1546 for this.

Replying to [warner](/tahoe-lafs/trac-2024-07-25/issues/1267#issuecomment-81332): > What if we accepted a syntax like "`tahoe start DIR -- ARG1 ARG2`" or "`tahoe start -- ARG1 ARG2`", and passed all the extra ARG1/ARG2 strings into `twistd.run()`? I'd really like if it we had a way to pass arbitrary twistd arguments, rather than having to hand-code support for each one. Created #1546 for this.

exarkun commented

2020-01-16 20:13:51 +00:00

ticket:1546 would seem to completely supersede this one since it suggests allowing any options to be passed through to twistd and the profiler and debugger options fall into the set of "any options".

Not sure why this was left open or why that other ticket was created instead of this one being resolved. Resolving this one as a duplicate now.

ticket:1546 would seem to completely supersede this one since it suggests allowing any options to be passed through to twistd and the profiler and debugger options fall into the set of "any options". Not sure why this was left open or why that other ticket was created instead of this one being resolved. Resolving this one as a duplicate now.

exarkun added the

duplicate

label 2020-01-16 20:13:51 +00:00

exarkun closed this issue

2020-01-16 20:13:51 +00:00

Sign in to join this conversation.