cancelled downloads are marked incorrectly on the Recent Uploads/Downloads page #1173

New Issue

zooko · 2010-08-12T20:53:57Z

zooko commented

2010-08-12 20:53:57 +00:00

I cancelled a download in progress, and its completeness went to 100% and its state stayed at "fetching segment 1886". This is wrong--if anything its completeness should have stayed at the incomplete percentage that it already was and its state should have changed to "cancelled".

I'm tagging this one with the regression tag, partially because I wonder if we shouldn't delay the Tahoe-LAFS v1.8.0 release to address this one as well as perhaps #1166, #1169, #1171 and (maybe, if there is anything to it) #1170.

I cancelled a download in progress, and its completeness went to 100% and its state stayed at "fetching segment 1886". This is wrong--if anything its completeness should have stayed at the incomplete percentage that it already was and its state should have changed to "cancelled". I'm tagging this one with the `regression` tag, partially because I wonder if we shouldn't delay the Tahoe-LAFS v1.8.0 release to address this one as well as perhaps #1166, #1169, #1171 and (maybe, if there is anything to it) #1170.

zooko added the

labels 2010-08-12 20:53:57 +00:00

zooko added this to the 1.8.0 milestone 2010-08-12 20:53:57 +00:00

zooko commented

2010-08-12 20:54:12 +00:00

Attachment Tahoe-LAFS - Current Uploads_Downloads.html (2403 bytes) added

**Attachment** Tahoe-LAFS - Current Uploads_Downloads.html (2403 bytes) added

Tahoe-LAFS - Current Uploads_Downloads.html

2.3 KiB

zooko commented

2010-08-13 05:23:20 +00:00

I'm about to attach one that ended because I had asked curl to download only a certain range and it had finished doing so, and it is marked as "idle".

zooko commented

2010-08-13 05:24:03 +00:00

Attachment ended-idle-Tahoe-LAFS - Current Uploads_Downloads.html (1104 bytes) added

**Attachment** ended-idle-Tahoe-LAFS - Current Uploads_Downloads.html (1104 bytes) added

ended-idle-Tahoe-LAFS - Current Uploads_Downloads.html

1.1 KiB

warner commented

2010-08-13 22:18:59 +00:00

Hm, weird. The stuck-at-"fetching segment 1886" is definitely a bug. I'm uncertain about the "completeness=100%" part.. what ought that to say when a download is cancelled? Hm, maybe "cancelled" ?

Some of this needs some reworking.. there's a method that is expected to return a number from 0 to 1 that is used to populate the "completed percentage" field. To replace that with a "cancelled" string, we need to get rid of that method, or allow it to return None, or something.

Hm, weird. The stuck-at-"fetching segment 1886" is definitely a bug. I'm uncertain about the "completeness=100%" part.. what ought that to say when a download is cancelled? Hm, maybe "cancelled" ? Some of this needs some reworking.. there's a method that is expected to return a number from 0 to 1 that is used to populate the "completed percentage" field. To replace that with a "cancelled" string, we need to get rid of that method, or allow it to return None, or something.

zooko commented

2010-08-14 07:03:43 +00:00

It sounds like these bugs are unimportant enough to leave them in v1.8.0 final. If you agree, please bump them to the "soon" Milestone and remove the "regression" tag.

tahoe-lafs modified the milestone from 1.8.0 to 1.9.0

2010-09-04 13:13:38 +00:00

zooko commented

2010-10-22 13:40:23 +00:00

Oh, if someone could do it real quick, we could fix this bug in v1.8.1. That would be nice!

zooko modified the milestone from 1.9.0 to 1.8.1

2010-10-22 13:40:23 +00:00

kevan commented

2010-10-24 19:09:45 +00:00

I couldn't reproduce either of these issues on a fresh checkout of trunk.

When I cancel a download (either by stopping it, if I've downloaded it after using Firefox to access the WUI, or by stopping the curl process, if I've used curl, though I don't see why there should be a difference between the two), I see "Failed (output stopped)" as its status on the status page, and its completeness percentage reflects the amount of data that it had downloaded when I stopped it. This seems like expected behavior to me; at least, it is what I expected to see.

If I try to download part of a file (using, e.g., curl --range 10-10000000) and then stop the download before it can finish, I don't see anything at all about it on the status page. If I let the request complete, I still don't see anything about it on the status page. Weird, arguably buggy behavior, but not what Zooko observed.

Zooko: Can you reproduce these problems? If so, what am I doing wrong to not be able to reproduce them?

I couldn't reproduce either of these issues on a fresh checkout of trunk. When I cancel a download (either by stopping it, if I've downloaded it after using Firefox to access the WUI, or by stopping the curl process, if I've used curl, though I don't see why there should be a difference between the two), I see "Failed (output stopped)" as its status on the status page, and its completeness percentage reflects the amount of data that it had downloaded when I stopped it. This seems like expected behavior to me; at least, it is what I expected to see. If I try to download part of a file (using, e.g., `curl --range 10-10000000`) and then stop the download before it can finish, I don't see anything at all about it on the status page. If I let the request complete, I *still* don't see anything about it on the status page. Weird, arguably buggy behavior, but not what Zooko observed. Zooko: Can you reproduce these problems? If so, what am I doing wrong to not be able to reproduce them?

zooko self-assigned this 2010-10-24 20:54:44 +00:00

zooko modified the milestone from 1.8.1 to soon

2010-11-02 02:32:00 +00:00

zooko commented

2011-09-02 21:25:02 +00:00

Brian changed some of the progress reporting of mutable files in changeset:9756146d61673552 but I suppose this can't have any effect on these immutables that I had trouble with. Anyway, leaving assigned to me to try to reproduce.

zooko removed their assignment 2012-02-02 22:12:27 +00:00

davidsarah commented

2012-04-01 23:17:45 +00:00

Zooko, did you fail to reproduce this, or did you not get chance to try to do so?

tahoe-lafs modified the milestone from soon to 1.11.0

2012-04-01 23:17:45 +00:00

zooko was assigned by tahoe-lafs

2012-04-01 23:17:45 +00:00

zooko commented

2012-04-01 23:25:14 +00:00

I haven't tried yet. Will try.

Sign in to join this conversation.