tahoe-lafs
/
trac-2024-07-25
2
0
Issues 1.1k Wiki

add regression test for shnums: "e,r,r,o,r" #1171

New Issue
Open
opened 2010-08-12 20:39:56 +00:00 by zooko · 8 comments
zooko commented 2010-08-12 20:39:56 +00:00
Copy Link

In this download status page that I attached to #1170 -- http://tahoe-lafs.org/trac/tahoe-lafs/attachment/ticket/1170/down-1.html one of the entries in the "shnums" column (the one for serverid 62nlabgf), says e,r,r,o,r.

In this download status page that I attached to #1170 -- <http://tahoe-lafs.org/trac/tahoe-lafs/attachment/ticket/1170/down-1.html> one of the entries in the "shnums" column (the one for serverid 62nlabgf), says `e,r,r,o,r`.
zooko added the
code-frontend-web
major
defect
1.8β
 labels 2010-08-12 20:39:56 +00:00
zooko added this to the undecided milestone 2010-08-12 20:39:56 +00:00
zooko commented 2010-08-14 07:05:15 +00:00
Author
Copy Link

Perhaps we should investigate and make sure that this doesn't cause worse problems, and fix it in 1.8.0 if it is easy to fix or if it causes worse problems.

Perhaps we should investigate and make sure that this doesn't cause worse problems, and fix it in 1.8.0 if it is easy to fix or if it causes worse problems.
zooko modified the milestone from undecided to 1.8.0 2010-08-14 07:05:15 +00:00
warner commented 2010-08-14 18:36:22 +00:00
Copy Link

I agree with checking that it doesn't cause worse problems, but I have a for-after-1.8.0 patch to rewrite the way that errors are recorded in the DownloadStatus structure that will make this go away.

I agree with checking that it doesn't cause worse problems, but I have a for-after-1.8.0 patch to rewrite the way that errors are recorded in the `DownloadStatus` structure that will make this go away.
tahoe-lafs modified the milestone from 1.8.0 to 1.9.0 2010-08-21 21:56:32 +00:00
zooko commented 2010-10-22 13:41:23 +00:00
Author
Copy Link

This is another bug that was introduced in v1.8.0 and it would be great if we could fix it in v1.8.1, but someone would have to volunteer to do the work quite soon.

This is another bug that was introduced in v1.8.0 and it would be great if we could fix it in v1.8.1, but someone would have to volunteer to do the work quite soon.
zooko modified the milestone from 1.9.0 to 1.8.1 2010-10-22 13:41:23 +00:00
zooko modified the milestone from 1.8.1 to soon 2010-11-02 02:26:35 +00:00
davidsarah commented 2012-06-29 13:06:43 +00:00
Owner
Copy Link

warner: can your patch mentioned in comment:79640 be applied for 1.10 without disruption?

warner: can your patch mentioned in [comment:79640](/tahoe-lafs/trac-2024-07-25/issues/1171#issuecomment-79640) be applied for 1.10 without disruption?
tahoe-lafs modified the milestone from soon to 1.10.0 2012-06-29 13:06:43 +00:00
warner was assigned by tahoe-lafs 2012-06-29 13:06:43 +00:00
warner commented 2012-09-04 16:41:28 +00:00
Copy Link

I'll investigate.. this one might alredy be fixed now.

I'll investigate.. this one might alredy be fixed now.
warner commented 2012-09-04 23:59:40 +00:00
Copy Link

It looks like the changes I had in mind have been applied already. Specifically, source:src/allmydata/immutable/downloader/status.py#L42 DYHBEvent has a distinct error() method, and source:src/allmydata/immutable/downloader/finder.py calls exactly one of finished() or error(). So shnums should only ever be a list of share numbers (keys of the dict-of-buckets returned by a successful DYHB call).

So I'm closing this one.

It looks like the changes I had in mind have been applied already. Specifically, source:src/allmydata/immutable/downloader/status.py#L42 `DYHBEvent` has a distinct `error()` method, and source:src/allmydata/immutable/downloader/finder.py calls exactly one of `finished()` or `error()`. So `shnums` should only ever be a list of share numbers (keys of the dict-of-buckets returned by a successful DYHB call). So I'm closing this one.
warner added the
fixed
 label 2012-09-04 23:59:40 +00:00
zooko commented 2012-09-05 02:14:27 +00:00
Author
Copy Link

I briefly looked at the two links into the source code that Brian posted in comment:79649 and it looks good to me.

I briefly looked at the two links into the source code that Brian posted in [comment:79649](/tahoe-lafs/trac-2024-07-25/issues/1171#issuecomment-79649) and it looks good to me.
davidsarah commented 2012-09-05 03:31:57 +00:00
Owner
Copy Link

This didn't have a test though. Ideally we should have a regression test.

This didn't have a test though. Ideally we should have a regression test.
tahoe-lafs removed the
fixed
 label 2012-09-05 03:31:57 +00:00
tahoe-lafs changed title from shnums: "e,r,r,o,r" to add regression test for shnums: "e,r,r,o,r" 2012-09-05 03:31:57 +00:00
tahoe-lafs added
normal
 and removed
major
 labels 2012-12-13 17:10:43 +00:00
tahoe-lafs modified the milestone from 1.10.0 to 1.11.0 2012-12-20 16:32:10 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels   
0.2.0

   
0.3.0

   
0.4.0

   
0.5.0

   
0.5.1

   
0.6.0

   
0.6.1

   
0.7.0

   
0.8.0

   
0.9.0

   
1.0.0

   
1.1.0

   
1.10.0

   
1.10.1

   
1.10.2

   
1.10a2

   
1.11.0

   
1.12.0

   
1.12.1

   
1.13.0

   
1.14.0

   
1.15.0

   
1.15.1

   
1.2.0

   
1.3.0

   
1.4.1

   
1.5.0

   
1.6.0

   
1.6.1

   
1.7.0

   
1.7.1

   
1.7β

   
1.8.0

   
1.8.1

   
1.8.2

   
1.8.3

   
1.8β

   
1.9.0

   
1.9.0-s3branch

   
1.9.0a1

   
1.9.0a2

   
1.9.0b1

   
1.9.1

   
1.9.2

   
1.9.2a1

   
LeastAuthority.com automation

   
blocker

   
cannot reproduce

   
cloud-branch

   
code

catch-all for anything that can be fixed by writing code but isn't classified better

  
code-dirnodes

anything involving tahoe directories

  
code-encoding

immutable-file encoding format/layout, cap format, encoding/decoding algorithms

  
code-frontend

general frontend things: new user-facing interfaces, FTP/SFTP servers, FUSE-like interfaces

  
code-frontend-cli

CLI tools

  
code-frontend-ftp-sftp

   
code-frontend-magic-folder

   
code-frontend-web

webapi interfaces, user-facing "WUI" interfaces

  
code-mutable

anything involving mutable files: encoding/decoding, share format

  
code-network

Introducer, locating storage servers, establishing/maintaining connections to them

  
code-nodeadmin

node startup/shutdown, tools to create nodes, logging tools, management/monitoring tools, manhole, disk-space-limiting tools

  
code-peerselection

server selection/sorting algorithm, rebalancing code, allocation policy, swarming-download

  
code-storage

storage-server implementation, share-storage directory layout, client-to-server share transfer protocol

  
contrib

problems with non-core things that live in the source:contrib/ directory

  
critical

   
defect

   
dev-infrastructure

things that help us build Tahoe: buildbot, automated speed/memory/code-coverage tests and results-displayers, IRC channels, mailing lists, this Trac instance

  
documentation

docs items. Also use 'docs' keyword on tickets in more specific components.

  
duplicate

   
enhancement

   
fixed

   
invalid

   
major

   
minor

   
n/a

   
normal

   
operational

things involved in running a tahoe grid, external tools to monitor/maintain a grid (like "nodeadmin" but larger-scale). Was also used for issues with the allmydata.com grid.

  
packaging

setup.py script, library dependencies, binary packages, licensing, installation instructions

  
somebody else's problem

   
supercritical

   
task

   
trivial

   
unknown

Uncategorized. All tickets default to this component until someone updates it.

  
was already fixed

   
website

things about the tahoe-lafs.org website (and sometimes this Trac instance, shared with 'dev-infrastructure')

  
wontfix

   
worksforme
No Label
0.2.0
0.3.0
0.4.0
0.5.0
0.5.1
0.6.0
0.6.1
0.7.0
0.8.0
0.9.0
1.0.0
1.1.0
1.10.0
1.10.1
1.10.2
1.10a2
1.11.0
1.12.0
1.12.1
1.13.0
1.14.0
1.15.0
1.15.1
1.2.0
1.3.0
1.4.1
1.5.0
1.6.0
1.6.1
1.7.0
1.7.1
1.7β
1.8.0
1.8.1
1.8.2
1.8.3
1.8β
1.9.0
1.9.0-s3branch
1.9.0a1
1.9.0a2
1.9.0b1
1.9.1
1.9.2
1.9.2a1
LeastAuthority.com automation
blocker
cannot reproduce
cloud-branch
code
code-dirnodes
code-encoding
code-frontend
code-frontend-cli
code-frontend-ftp-sftp
code-frontend-magic-folder
code-frontend-web
code-mutable
code-network
code-nodeadmin
code-peerselection
code-storage
contrib
critical
defect
dev-infrastructure
documentation
duplicate
enhancement
fixed
invalid
major
minor
n/a
normal
operational
packaging
somebody else's problem
supercritical
task
trivial
unknown
was already fixed
website
wontfix
worksforme
Milestone
Clear milestone
No items
No Milestone
soon
Assignees
Clear assignees
No Assignees
warner
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Reference: tahoe-lafs/trac-2024-07-25#1171
No description provided.
Delete Branch "%!s(<nil>)"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?