viewing web-status of unfinished immutable downloads causes exception #1160

New Issue

zooko · 2010-08-09T21:16:52Z

zooko commented

2010-08-09 21:16:52 +00:00

The web-status view (visible at <http://$GATEWAY/status>) of immutable downloads shows "not impl yet" in the status column. If you click on that to get an exception which ends with:

          File "/Library/Python/2.6/site-packages/allmydata/web/status.py", line 416, in render_events
            rtt = received - sent
        exceptions.TypeError: unsupported operand type(s) for -: 'NoneType' and 'float'

Attached is an incident report file from such an incident.

The web-status view (visible at `<http://$GATEWAY/status>`) of immutable downloads shows "not impl yet" in the status column. If you click on that to get an exception which ends with: ``` File "/Library/Python/2.6/site-packages/allmydata/web/status.py", line 416, in render_events rtt = received - sent exceptions.TypeError: unsupported operand type(s) for -: 'NoneType' and 'float' ``` Attached is an incident report file from such an incident.

zooko added the

labels 2010-08-09 21:16:52 +00:00

zooko added this to the 1.8.0 milestone 2010-08-09 21:16:52 +00:00

zooko commented

2010-08-09 21:18:08 +00:00

Attachment incident-2010-08-09-140456-fzgnluy.flog.bz2 (25484 bytes) added

**Attachment** incident-2010-08-09-140456-fzgnluy.flog.bz2 (25484 bytes) added

incident-2010-08-09-140456-fzgnluy.flog.bz2

25 KiB

warner commented

2010-08-09 22:28:25 +00:00

Attachment patch-1-hush-logs.3.diff (909 bytes) added

don't log storage requests that arrive after the download is finished

**Attachment** patch-1-hush-logs.3.diff (909 bytes) added don't log storage requests that arrive after the download is finished

patch-1-hush-logs.3.diff

909 B

warner commented

2010-08-09 22:30:26 +00:00

Attachment patch-3-tolerate-unretired-DYHB.diff (3770 bytes) added

real fix for #1160: tolerate DYHB requests that haven't retired, plus tests

**Attachment** patch-3-tolerate-unretired-DYHB.diff (3770 bytes) added real fix for #1160: tolerate DYHB requests that haven't retired, plus tests

patch-3-tolerate-unretired-DYHB.diff

3.7 KiB

davidsarah commented

2010-08-09 22:37:38 +00:00

Accepting for review.

warner commented

2010-08-09 23:10:10 +00:00

Attachment patch-2-fewer-downloadstatus.diff (6419 bytes) added

stop creating download-status objects for non-downloaded filenodes (v2)

**Attachment** patch-2-fewer-downloadstatus.diff (6419 bytes) added stop creating download-status objects for non-downloaded filenodes (v2)

patch-2-fewer-downloadstatus.diff

6.3 KiB

davidsarah commented

2010-08-09 23:12:01 +00:00

Looks good, ok to apply with v2 of second patch.

Brian Warner <warner@lothar.com> commented

2010-08-09 23:15:45 +00:00

In changeset:dc1afc81bbfe95de:

web download-status: tolerate DYHBs that haven't retired yet. Fixes #1160.

Also add a better unit test for it.

In changeset:dc1afc81bbfe95de: ``` web download-status: tolerate DYHBs that haven't retired yet. Fixes #1160. Also add a better unit test for it. ```

tahoe-lafs added the

fixed

label 2010-08-09 23:15:45 +00:00

tahoe-lafs closed this issue

2010-08-09 23:15:45 +00:00

Brian Warner <warner@lothar.com> commented

2010-08-12 05:58:27 +00:00

In [4693/ticket68-multi-introducer]:

web download-status: tolerate DYHBs that haven't retired yet. Fixes #1160.

Also add a better unit test for it.

In [4693/ticket68-multi-introducer]: ``` web download-status: tolerate DYHBs that haven't retired yet. Fixes #1160. Also add a better unit test for it. ```

Sign in to join this conversation.