tahoe-lafs/tahoe-lafs
tahoe-lafs
/
tahoe-lafs
2
0
Fork 0
Code Issues Pull Requests 23 Packages Projects Releases 1 Wiki Activity

Remove mock from test_introducer #936

Merged
exarkun merged 10 commits from 3534.test_introducer-no-mock into master 2021-01-04 20:06:30 +00:00
Conversation 1 Commits 10 Files Changed 6 +132 -37
exarkun commented 2020-12-16 20:26:32 +00:00 (Migrated from github.com)
Copy Link

https://tahoe-lafs.org/trac/tahoe-lafs/ticket/3534

https://tahoe-lafs.org/trac/tahoe-lafs/ticket/3534
codecov[bot] commented 2020-12-16 20:29:13 +00:00 (Migrated from github.com)
Copy Link

Codecov Report

Merging #936 (3513e9b) into master (d19b1cf) will decrease coverage by 0%.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #936   +/-   ##
======================================
- Coverage      92%     92%   -0%     
======================================
  Files         151     151           
  Lines       27159   27159           
  Branches     4078    4078           
======================================
- Hits        25014   25012    -2     
- Misses       1493    1494    +1     
- Partials      652     653    +1
Impacted Files Coverage Δ
src/allmydata/immutable/layout.py 91% <0%> (-1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d19b1cf...4117beb. Read the comment docs.

# [Codecov](https://codecov.io/gh/tahoe-lafs/tahoe-lafs/pull/936?src=pr&el=h1) Report > Merging [#936](https://codecov.io/gh/tahoe-lafs/tahoe-lafs/pull/936?src=pr&el=desc) (3513e9b) into [master](https://codecov.io/gh/tahoe-lafs/tahoe-lafs/commit/d19b1cfd687cfede9374d994aca7c1890af6811e?el=desc) (d19b1cf) will **decrease** coverage by `0%`. > The diff coverage is `n/a`. [![Impacted file tree graph](https://codecov.io/gh/tahoe-lafs/tahoe-lafs/pull/936/graphs/tree.svg?width=650&height=150&src=pr&token=Ztmu9sr4vi)](https://codecov.io/gh/tahoe-lafs/tahoe-lafs/pull/936?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #936 +/- ## ====================================== - Coverage 92% 92% -0% ====================================== Files 151 151 Lines 27159 27159 Branches 4078 4078 ====================================== - Hits 25014 25012 -2 - Misses 1493 1494 +1 - Partials 652 653 +1 ``` | [Impacted Files](https://codecov.io/gh/tahoe-lafs/tahoe-lafs/pull/936?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [src/allmydata/immutable/layout.py](https://codecov.io/gh/tahoe-lafs/tahoe-lafs/pull/936/diff?src=pr&el=tree#diff-c3JjL2FsbG15ZGF0YS9pbW11dGFibGUvbGF5b3V0LnB5) | `91% <0%> (-1%)` | :arrow_down: | ------ [Continue to review full report at Codecov](https://codecov.io/gh/tahoe-lafs/tahoe-lafs/pull/936?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/tahoe-lafs/tahoe-lafs/pull/936?src=pr&el=footer). Last update [d19b1cf...4117beb](https://codecov.io/gh/tahoe-lafs/tahoe-lafs/pull/936?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
meejah (Migrated from github.com) approved these changes 2021-01-04 19:57:58 +00:00
meejah (Migrated from github.com) left a comment
Copy Link

👍

:+1:
src/allmydata/introducer/client.py
@ -18,3 +18,3 @@
from twisted.application import service
from foolscap.api import Referenceable, eventually
from foolscap.api import Referenceable
from allmydata.interfaces import InsufficientVersionError
meejah (Migrated from github.com) commented 2021-01-04 19:25:47 +00:00
Copy Link

ooo, less "eventually" is always good

ooo, less "eventually" is always good
Sign in to join this conversation.
Reviewers
No reviewers
meejah
Labels
Clear labels   
Benchmarking and Performance

   
HTTP Storage Protocol

   
Nevow Removal

   
Python 3 Porting

   
not-for-merge
No Label
Benchmarking and Performance
HTTP Storage Protocol
Nevow Removal
Python 3 Porting
not-for-merge
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: tahoe-lafs/tahoe-lafs#936
No description provided.
Delete Branch "3534.test_introducer-no-mock"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?