tahoe-lafs/tahoe-lafs
tahoe-lafs
/
tahoe-lafs
2
0
Fork 0
Code Issues Pull Requests 23 Packages Projects Releases 1 Wiki Activity

3019 remove tuple unpacking #600

Merged
heartsucker merged 2 commits from 3019-remove-tuple-unpacking into master 2019-04-26 17:37:56 +00:00
Conversation 5 Commits 2 Files Changed 35 +603 -376
heartsucker commented 2019-04-12 14:20:26 +00:00 (Migrated from github.com)
Copy Link

Fixes: ticket:3019

https://tahoe-lafs.org/trac/tahoe-lafs/ticket/3019

This change is Reviewable

Fixes: ticket:3019 https://tahoe-lafs.org/trac/tahoe-lafs/ticket/3019 <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/tahoe-lafs/tahoe-lafs/600) <!-- Reviewable:end -->
exarkun commented 2019-04-12 14:38:59 +00:00 (Migrated from github.com)
Copy Link

fixes: 3019

This won't cause the ticket to close. The merge commit message needs "Fixes: ticket:3019" in it.

> fixes: 3019 This won't cause the ticket to close. The merge commit message needs "Fixes: ticket:3019" in it.
👍 1
codecov-io commented 2019-04-12 14:56:41 +00:00 (Migrated from github.com)
Copy Link

Codecov Report

Merging #600 into master will decrease coverage by 0.03%.
The diff coverage is 47.54%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #600      +/-   ##
==========================================
- Coverage   86.16%   86.13%   -0.04%     
==========================================
  Files         159      159              
  Lines       28713    28741      +28     
  Branches     4087     4087              
==========================================
+ Hits        24741    24755      +14     
- Misses       3269     3283      +14     
  Partials      703      703
Impacted Files Coverage Δ
src/allmydata/frontends/sftpd.py 12.05% <0%> (-0.1%) ⬇️
src/allmydata/immutable/downloader/segmentation.py 100% <100%> (ø) ⬆️
src/allmydata/immutable/upload.py 95.64% <100%> (ø) ⬆️
src/allmydata/immutable/downloader/node.py 96.02% <100%> (+0.01%) ⬆️
src/allmydata/immutable/encode.py 95.96% <100%> (ø) ⬆️
src/allmydata/mutable/filenode.py 98.6% <100%> (ø) ⬆️
src/allmydata/scripts/debug.py 85.95% <100%> (+0.01%) ⬆️
src/allmydata/util/spans.py 96.33% <100%> (+0.01%) ⬆️
src/allmydata/dirnode.py 96.57% <100%> (ø) ⬆️
src/allmydata/frontends/ftpd.py 49.41% <31.57%> (-0.39%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 48a2b42...a087a5b. Read the comment docs.

# [Codecov](https://codecov.io/gh/tahoe-lafs/tahoe-lafs/pull/600?src=pr&el=h1) Report > Merging [#600](https://codecov.io/gh/tahoe-lafs/tahoe-lafs/pull/600?src=pr&el=desc) into [master](https://codecov.io/gh/tahoe-lafs/tahoe-lafs/commit/48a2b42ec11fb17c00edf502ee794be934054e52?src=pr&el=desc) will **decrease** coverage by `0.03%`. > The diff coverage is `47.54%`. [![Impacted file tree graph](https://codecov.io/gh/tahoe-lafs/tahoe-lafs/pull/600/graphs/tree.svg?width=650&token=Ztmu9sr4vi&height=150&src=pr)](https://codecov.io/gh/tahoe-lafs/tahoe-lafs/pull/600?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #600 +/- ## ========================================== - Coverage 86.16% 86.13% -0.04% ========================================== Files 159 159 Lines 28713 28741 +28 Branches 4087 4087 ========================================== + Hits 24741 24755 +14 - Misses 3269 3283 +14 Partials 703 703 ``` | [Impacted Files](https://codecov.io/gh/tahoe-lafs/tahoe-lafs/pull/600?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [src/allmydata/frontends/sftpd.py](https://codecov.io/gh/tahoe-lafs/tahoe-lafs/pull/600/diff?src=pr&el=tree#diff-c3JjL2FsbG15ZGF0YS9mcm9udGVuZHMvc2Z0cGQucHk=) | `12.05% <0%> (-0.1%)` | :arrow_down: | | [src/allmydata/immutable/downloader/segmentation.py](https://codecov.io/gh/tahoe-lafs/tahoe-lafs/pull/600/diff?src=pr&el=tree#diff-c3JjL2FsbG15ZGF0YS9pbW11dGFibGUvZG93bmxvYWRlci9zZWdtZW50YXRpb24ucHk=) | `100% <100%> (ø)` | :arrow_up: | | [src/allmydata/immutable/upload.py](https://codecov.io/gh/tahoe-lafs/tahoe-lafs/pull/600/diff?src=pr&el=tree#diff-c3JjL2FsbG15ZGF0YS9pbW11dGFibGUvdXBsb2FkLnB5) | `95.64% <100%> (ø)` | :arrow_up: | | [src/allmydata/immutable/downloader/node.py](https://codecov.io/gh/tahoe-lafs/tahoe-lafs/pull/600/diff?src=pr&el=tree#diff-c3JjL2FsbG15ZGF0YS9pbW11dGFibGUvZG93bmxvYWRlci9ub2RlLnB5) | `96.02% <100%> (+0.01%)` | :arrow_up: | | [src/allmydata/immutable/encode.py](https://codecov.io/gh/tahoe-lafs/tahoe-lafs/pull/600/diff?src=pr&el=tree#diff-c3JjL2FsbG15ZGF0YS9pbW11dGFibGUvZW5jb2RlLnB5) | `95.96% <100%> (ø)` | :arrow_up: | | [src/allmydata/mutable/filenode.py](https://codecov.io/gh/tahoe-lafs/tahoe-lafs/pull/600/diff?src=pr&el=tree#diff-c3JjL2FsbG15ZGF0YS9tdXRhYmxlL2ZpbGVub2RlLnB5) | `98.6% <100%> (ø)` | :arrow_up: | | [src/allmydata/scripts/debug.py](https://codecov.io/gh/tahoe-lafs/tahoe-lafs/pull/600/diff?src=pr&el=tree#diff-c3JjL2FsbG15ZGF0YS9zY3JpcHRzL2RlYnVnLnB5) | `85.95% <100%> (+0.01%)` | :arrow_up: | | [src/allmydata/util/spans.py](https://codecov.io/gh/tahoe-lafs/tahoe-lafs/pull/600/diff?src=pr&el=tree#diff-c3JjL2FsbG15ZGF0YS91dGlsL3NwYW5zLnB5) | `96.33% <100%> (+0.01%)` | :arrow_up: | | [src/allmydata/dirnode.py](https://codecov.io/gh/tahoe-lafs/tahoe-lafs/pull/600/diff?src=pr&el=tree#diff-c3JjL2FsbG15ZGF0YS9kaXJub2RlLnB5) | `96.57% <100%> (ø)` | :arrow_up: | | [src/allmydata/frontends/ftpd.py](https://codecov.io/gh/tahoe-lafs/tahoe-lafs/pull/600/diff?src=pr&el=tree#diff-c3JjL2FsbG15ZGF0YS9mcm9udGVuZHMvZnRwZC5weQ==) | `49.41% <31.57%> (-0.39%)` | :arrow_down: | ------ [Continue to review full report at Codecov](https://codecov.io/gh/tahoe-lafs/tahoe-lafs/pull/600?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/tahoe-lafs/tahoe-lafs/pull/600?src=pr&el=footer). Last update [48a2b42...a087a5b](https://codecov.io/gh/tahoe-lafs/tahoe-lafs/pull/600?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
meejah (Migrated from github.com) approved these changes 2019-04-23 18:38:41 +00:00
meejah commented 2019-04-23 18:58:42 +00:00 (Migrated from github.com)
Copy Link

Hrrmmmm...is there a "real error" there somewhere? I re-started the Travis job that failed on "too many open files" and it failed again, same error...

Hrrmmmm...is there a "real error" there somewhere? I re-started the Travis job that failed on "too many open files" and it failed again, same error...
meejah commented 2019-04-23 19:23:21 +00:00 (Migrated from github.com)
Copy Link

okay, it just failed a third time with too many open files ... oh, also it seems that one is failing on master too .. so nevermind

okay, it just failed a third time with too many open files ... oh, also it seems that one is failing on master too .. so nevermind
heartsucker commented 2019-04-25 07:41:59 +00:00 (Migrated from github.com)
Copy Link

Can you kick the failed jobs when you get a chance?

Can you kick the failed jobs when you get a chance?
Sign in to join this conversation.
Reviewers
No reviewers
meejah
Labels
Clear labels   
Benchmarking and Performance

   
HTTP Storage Protocol

   
Nevow Removal

   
Python 3 Porting

   
not-for-merge
No Label
Benchmarking and Performance
HTTP Storage Protocol
Nevow Removal
Python 3 Porting
not-for-merge
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: tahoe-lafs/tahoe-lafs#600
No description provided.
Delete Branch "3019-remove-tuple-unpacking"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?