tahoe-lafs/tahoe-lafs
tahoe-lafs
/
tahoe-lafs
2
0
Fork 0
Code Issues Pull Requests 23 Packages Projects Releases 1 Wiki Activity

Refactor mutable tests to use common Async or Sync testcase #1123

Merged
Fenn-CS merged 16 commits from 3788.refactor-src.test.mutable into master 2022-01-31 14:04:49 +00:00
Conversation 2 Commits 16 Files Changed 16 +325 -287
Fenn-CS commented 2021-09-09 00:54:36 +00:00 (Migrated from github.com)
Copy Link

Refactoring test in test.mutable to use common base testcases just as in #1104 and #1100

Closes : https://tahoe-lafs.org/trac/tahoe-lafs/ticket/3788#ticket

Refactoring test in `test.mutable` to use common base testcases just as in #1104 and #1100 Closes : https://tahoe-lafs.org/trac/tahoe-lafs/ticket/3788#ticket
itamarst (Migrated from github.com) reviewed 2021-09-09 00:54:36 +00:00
meejah (Migrated from github.com) reviewed 2021-09-09 00:54:36 +00:00
coveralls commented 2021-09-10 13:42:48 +00:00 (Migrated from github.com)
Copy Link

Coverage Status

Coverage increased (+0.01%) to 95.707% when pulling 640bb05a57 on Fenn-CS:3788.refactor-src.test.mutable into 210a0e773b on tahoe-lafs:master.

[![Coverage Status](https://coveralls.io/builds/46045346/badge)](https://coveralls.io/builds/46045346) Coverage increased (+0.01%) to 95.707% when pulling **640bb05a5778c706a1ec6fcdbdf0bbb48b8ad649 on Fenn-CS:3788.refactor-src.test.mutable** into **210a0e773b1223ff06de4d170b098799ade4de05 on tahoe-lafs:master**.
exarkun (Migrated from github.com) requested changes 2021-11-22 16:37:19 +00:00
exarkun (Migrated from github.com) left a comment
Copy Link

Thanks. This is a nice chunk of cleanup/refactoring. I noticed what I think are a few mis-translations, I left comments inline about them.

Thanks. This is a nice chunk of cleanup/refactoring. I noticed what I think are a few mis-translations, I left comments inline about them.
src/allmydata/test/mutable/test_problems.py
exarkun (Migrated from github.com) commented 2021-11-22 16:20:23 +00:00
Copy Link

assertTrue should be assertEquals here

`assertTrue` should be `assertEquals` here
exarkun (Migrated from github.com) commented 2021-11-22 16:20:41 +00:00
Copy Link

assertTrue should be assertEquals here

`assertTrue` should be `assertEquals` here
src/allmydata/test/mutable/test_problems.py
exarkun (Migrated from github.com) commented 2021-11-22 16:20:53 +00:00
Copy Link

another assertTrue

another `assertTrue`
exarkun (Migrated from github.com) commented 2021-11-22 16:21:03 +00:00
Copy Link

another assertTrue

another `assertTrue`
src/allmydata/test/mutable/test_problems.py
exarkun (Migrated from github.com) commented 2021-11-22 16:21:10 +00:00
Copy Link

and one more

and one more
src/allmydata/test/mutable/test_repair.py
exarkun (Migrated from github.com) commented 2021-11-22 16:23:07 +00:00
Copy Link

assertTrue should be assertEqual

`assertTrue` should be `assertEqual`
exarkun (Migrated from github.com) reviewed 2021-11-29 13:54:27 +00:00
src/allmydata/test/mutable/test_problems.py
exarkun (Migrated from github.com) commented 2021-11-29 13:54:26 +00:00
Copy Link

This one still needs fixing.

This one still needs fixing.
exarkun commented 2022-01-31 14:04:09 +00:00 (Migrated from github.com)
Copy Link

Thanks. Sorry about the delay in revisiting this. The changes look good to me. The CI problems appear unrelated and are tracked by https://tahoe-lafs.org/trac/tahoe-lafs/ticket/3869

Thanks. Sorry about the delay in revisiting this. The changes look good to me. The CI problems appear unrelated and are tracked by https://tahoe-lafs.org/trac/tahoe-lafs/ticket/3869
🎉 1
exarkun (Migrated from github.com) approved these changes 2022-01-31 14:04:19 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
itamarst
meejah
exarkun
Labels
Clear labels   
Benchmarking and Performance

   
HTTP Storage Protocol

   
Nevow Removal

   
Python 3 Porting

   
not-for-merge
No Label
Benchmarking and Performance
HTTP Storage Protocol
Nevow Removal
Python 3 Porting
not-for-merge
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: tahoe-lafs/tahoe-lafs#1123
No description provided.
Delete Branch "3788.refactor-src.test.mutable"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?