3681 Use x86 Python for Windows testing #1047

Merged
sajith merged 14 commits from 3681.github-actions-use-x86-windows into master 2021-04-27 22:36:13 +00:00

14 Commits

Author SHA1 Message Date
Sajith Sasidharan 6d1b95b965 GitHub Actions: add more parenthesis
https://github.community/t/and-operator-in-if-condition/154825
suggests that adding more parens might work.
2021-04-27 16:21:22 -04:00
Sajith Sasidharan 3722b8f628 GitHub Actions: quote architecture
Docs for actions/setup-python seem to do that, although
inconsistently.
2021-04-27 15:52:28 -04:00
Sajith Sasidharan 73d3295a6a GitHub Actions: use 64-bit Python 3.6 to test on Windows 2021-04-27 15:49:25 -04:00
Sajith Sasidharan 65398a2d63 GitHub Actions: update note about Windows again 2021-04-26 17:06:34 -04:00
Sajith Sasidharan 1531bea63f GitHub Actions: update note about Windows
[skip ci]
2021-04-26 16:58:24 -04:00
Sajith Sasidharan e46e4409c2 GitHub Actions: really use x86 Python on Windows
In a prior commit, I mistakenly used "architecture: x64" instead of
"architecture: x86", and tests actually passed.

That was surprising, because netifaces do not have amd64_win will on
PyPI.  But mystery was solved when itamarst pointed out that netifaces
wheel (that we previously built) is present on pip cache.

But pip cache might be purged one day, and tests will fail again that
day.  We can't have that, so we will try to stick with x86 for now.
2021-04-26 16:39:23 -04:00
Sajith Sasidharan 1a05fb21de Name newsfragment correctly 2021-04-26 14:02:26 -04:00
Sajith Sasidharan 68603fc015 GitHub Actions: just use x86 Python to test on Windows
I can't figure out the correct GitHub Actions magic incantation^w^w
expression syntax that is needed to isolate (Windows && Python 2.7),
so let's just run also run x86 Python 3.6 on Windows.
2021-04-26 13:41:17 -04:00
Sajith Sasidharan dec97b3aa1 GitHub Actions: when in doubt, drop some curly braces 2021-04-26 13:35:37 -04:00
Sajith Sasidharan ed82119f32 GitHub Actions: when in doubt, throw in more parens 2021-04-26 13:14:28 -04:00
Sajith Sasidharan 106976e8cc GitHub Actions: use expression syntax
Per GitHub documentation:

  When you use expressions in an if conditional, you may omit the
  expression syntax (${{ }}) because GitHub automatically evaluates
  the if conditional as an expression, unless the expression contains
  any operators. If the expression contains any operators, the
  expression must be contained within ${{ }} to explicitly mark it for
  evaluation.

https://docs.github.com/en/actions/reference/context-and-expression-syntax-for-github-actions
2021-04-26 12:17:25 -04:00
Sajith Sasidharan f4b8780ba7 Add newsfragment 2021-04-26 12:00:37 -04:00
Sajith Sasidharan 196ce5103d GitHub Actions: test with 32-bit Python 2.7 on Windows 2021-04-26 12:00:11 -04:00
Sajith Sasidharan b707a6ca7b GitHub Actions: do not install vcpython27
Microsoft seems to have pulled the compiler download.
2021-04-26 11:36:51 -04:00