3681 Use x86 Python for Windows testing #1047

2021-04-26T16:02:10Z

sajith commented

2021-04-26 16:02:10 +00:00

(Migrated from github.com)

Ticket is https://tahoe-lafs.org/trac/tahoe-lafs/ticket/3681.

Microsoft seems to have removed Microsoft Visual C++ Compiler for Python 2.7 downloads from their website, and it has broken our CI. Among Tahoe-LAFS dependencies, the only Python package that needs vcpython27 is netutils, and netutils ships a cp27-cp27m-win32 wheel package, and no cp27-cp27m-win_amd64. This change will switch to 32-bit Python for Windows testing.

Ideally we should be only switching to 32-bit Python 2.7 and leave Python 3.6 setup alone, but I could not figure out the GitHub Actions magic incantation to do that. Commits in this PR and their corresponding CI failures will bear witness to that. ;-)

Ticket is https://tahoe-lafs.org/trac/tahoe-lafs/ticket/3681. Microsoft seems to have removed Microsoft Visual C++ Compiler for Python 2.7 downloads from their website, and it has broken our CI. Among Tahoe-LAFS dependencies, the only Python package that needs vcpython27 is netutils, and netutils ships a `cp27-cp27m-win32` wheel package, and no `cp27-cp27m-win_amd64`. This change will switch to 32-bit Python for Windows testing. Ideally we should be only switching to 32-bit Python 2.7 and leave Python 3.6 setup alone, but I could not figure out the GitHub Actions magic incantation to do that. Commits in this PR and their corresponding CI failures will bear witness to that. ;-)

coveralls commented

2021-04-26 18:50:22 +00:00

(Migrated from github.com)

Coverage remained the same at 95.113% when pulling 6d1b95b965 on 3681.github-actions-use-x86-windows into 6142168977 on master.

[![Coverage Status](https://coveralls.io/builds/39167967/badge)](https://coveralls.io/builds/39167967) Coverage remained the same at 95.113% when pulling **6d1b95b965f16f7a15a238f8431fa60cb68f9cdf on 3681.github-actions-use-x86-windows** into **61421689777b57482bc01cf468ef94ba0756d804 on master**.

itamarst (Migrated from github.com) approved these changes 2021-04-27 13:15:16 +00:00

itamarst (Migrated from github.com) left a comment

I am not sure 32-bit vs 64-bit makes much difference for Tahoe-LAFS, but ... you can apply the suggestion I made, or not.

.github/workflows/ci.yml

itamarst (Migrated from github.com) commented

2021-04-27 13:09:20 +00:00

You can do {{ matrix.os == 'windows-latest' && matrix.python-version == '3.6' }} I believe.

You can do `{{ matrix.os == 'windows-latest' && matrix.python-version == '3.6' }}` I believe.

sajith (Migrated from github.com) reviewed 2021-04-27 20:14:39 +00:00

.github/workflows/ci.yml

sajith (Migrated from github.com) commented

2021-04-27 20:14:39 +00:00

Sadly GitHub Actions skipped right over this:

      - name: Set up Python ${{ matrix.python-version }} [Windows x64]
        if: ${{ matrix.os == 'windows-latest' && matrix.python-version == '3.6' }}
        uses: actions/setup-python@v1
        with:
          python-version: ${{ matrix.python-version }}
          architecture: 'x64'

... and chose to use the next step instead:

      - name: Set up Python ${{ matrix.python-version }} [Windows x86]
        if: ${{ matrix.os == 'windows-latest' && matrix.python-version == '2.7' }}
        uses: actions/setup-python@v1
        with:
          python-version: ${{ matrix.python-version }}
          architecture: 'x86'

See https://github.com/tahoe-lafs/tahoe-lafs/pull/1047/checks?check_run_id=2442603808

Sadly GitHub Actions skipped right over this: ``` - name: Set up Python ${{ matrix.python-version }} [Windows x64] if: ${{ matrix.os == 'windows-latest' && matrix.python-version == '3.6' }} uses: actions/setup-python@v1 with: python-version: ${{ matrix.python-version }} architecture: 'x64' ``` ... and chose to use the next step instead: ``` - name: Set up Python ${{ matrix.python-version }} [Windows x86] if: ${{ matrix.os == 'windows-latest' && matrix.python-version == '2.7' }} uses: actions/setup-python@v1 with: python-version: ${{ matrix.python-version }} architecture: 'x86' ``` See https://github.com/tahoe-lafs/tahoe-lafs/pull/1047/checks?check_run_id=2442603808

sajith (Migrated from github.com) reviewed 2021-04-27 21:05:23 +00:00

.github/workflows/ci.yml

sajith (Migrated from github.com) commented

2021-04-27 21:05:23 +00:00

Seems that this works:

      - name: Set up Python ${{ matrix.python-version }} [Windows x64]
        if: ${{ ( matrix.os == 'windows-latest' ) && ( matrix.python-version == '3.6' ) }}
        uses: actions/setup-python@v1
        with:
          python-version: ${{ matrix.python-version }}
          architecture: 'x64'

      - name: Set up Python ${{ matrix.python-version }} [Windows x86]
        if: ${{ ( matrix.os == 'windows-latest' ) && ( matrix.python-version == '2.7' ) }}
        uses: actions/setup-python@v1
        with:
          python-version: ${{ matrix.python-version }}
          architecture: 'x86'

Seems that this works: ``` - name: Set up Python ${{ matrix.python-version }} [Windows x64] if: ${{ ( matrix.os == 'windows-latest' ) && ( matrix.python-version == '3.6' ) }} uses: actions/setup-python@v1 with: python-version: ${{ matrix.python-version }} architecture: 'x64' - name: Set up Python ${{ matrix.python-version }} [Windows x86] if: ${{ ( matrix.os == 'windows-latest' ) && ( matrix.python-version == '2.7' ) }} uses: actions/setup-python@v1 with: python-version: ${{ matrix.python-version }} architecture: 'x86' ```

Sign in to join this conversation.

No reviewers

itamarst