Commit Graph

7828 Commits

Author SHA1 Message Date
87e0ce801a proper assert 2018-09-10 21:58:28 -06:00
3cc64649c0 add a pointer to relevant ticket 2018-09-10 21:58:28 -06:00
d0141b2f95 better docstring from exarkun 2018-09-10 21:58:28 -06:00
edb581b434 better docstring from exarkun 2018-09-10 21:58:28 -06:00
507c2db649 better utest docstring, cleanup 2018-09-10 21:58:28 -06:00
376a1dcbd5 turn XXX into a ticket 2018-09-10 21:58:28 -06:00
8b5e988755 use docstring to mark method as async 2018-09-10 21:58:28 -06:00
2b5d3be3c8 convert XXX comment to ticket 2018-09-10 21:58:28 -06:00
7de94f623c clarify Introducer imports 2018-09-10 21:58:28 -06:00
9a8ef9512e clarify comments 2018-09-10 21:58:28 -06:00
f488b79c71 self._portnumfile -> config.portnum_fname 2018-09-10 21:58:28 -06:00
692128ad1d better defaults handling 2018-09-10 21:58:28 -06:00
2e2bdf1ea1 test for EnvironmentError that's not ENOENT 2018-09-10 21:58:28 -06:00
ab812ca75f fix utests for Deferred/Failure-returning methods 2018-09-10 21:58:28 -06:00
f6b62ca192 import 2018-09-10 21:58:28 -06:00
a344bb24dc immutable default 2018-09-10 21:58:27 -06:00
dee8b72206 dead code 2018-09-10 21:58:27 -06:00
9aae4bd459 only handle ENOENT 2018-09-10 21:58:27 -06:00
a5287add80 clarify comments 2018-09-10 21:58:27 -06:00
efce7b1f6a use Failure for all errors from async methods 2018-09-10 21:58:27 -06:00
676a9efc23 docstring 2018-09-10 21:58:27 -06:00
714b0887dc more docstrings 2018-09-10 21:58:27 -06:00
2d55b61dd2 fixups after rebase 2018-09-10 21:58:27 -06:00
c22d7c632e docstring improvements 2018-09-10 21:58:27 -06:00
d6aeae0540 newsfragment 2018-09-10 21:58:27 -06:00
3974af6660 redundant imports 2018-09-10 21:58:27 -06:00
7632504373 create_client is async 2018-09-10 21:58:27 -06:00
14a66a54f0 flake8 2018-09-10 21:58:27 -06:00
0cfbdeb634 dead code 2018-09-10 21:58:27 -06:00
767f4ddd5d reorder args to match other method 2018-09-10 21:58:27 -06:00
045af64c2b dead code 2018-09-10 21:58:27 -06:00
06de4c88c4 codecleanup (incorrect merge?) 2018-09-10 21:58:27 -06:00
edc50f655b get rid of is_tub_listening 2018-09-10 21:58:27 -06:00
a82aa4ba2c code cleanup, docs 2018-09-10 21:58:27 -06:00
955d7abfa3 move validation code to parser-helper 2018-09-10 21:58:27 -06:00
2517535d2b test for 'listen on port 0' 2018-09-10 21:58:27 -06:00
9e34d15b90 simplify _tub_portlocation helper 2018-09-10 21:58:27 -06:00
053b494054 comment 2018-09-10 21:58:27 -06:00
e74d2a7d01 get rid of redundant 'introducer_clients' var 2018-09-10 21:58:27 -06:00
c84e50baf0 post-rebase fixup: _client_factory and docs 2018-09-10 21:58:27 -06:00
c7b47f44d2 flake8 2018-09-10 21:58:27 -06:00
17fa32633c post-rebase fixups; needs review 2018-09-10 21:58:27 -06:00
23d304814f not required for tests 2018-09-10 21:58:27 -06:00
283be23e3a basedir fixup, more tests 2018-09-10 21:58:27 -06:00
a628411988 basedir fixup 2018-09-10 21:58:27 -06:00
c2d1cf4400 correct service-parent in tests 2018-09-10 21:58:27 -06:00
136495e405 basedir fixup 2018-09-10 21:58:27 -06:00
2d044e1324 remove unused method 2018-09-10 21:58:27 -06:00
bb332fecf7 basedir fixup 2018-09-10 21:58:27 -06:00
548d9cbbcc basedir fixup 2018-09-10 21:58:27 -06:00