results of deep-size should include mutable files #975

New Issue

tahoe-lafs · 2010-03-02T00:51:32Z

davidsarah commented

2010-03-02 00:51:32 +00:00

A user (Jody Harris) quite reasonably expected the results of a deep-size operation to include mutable files in the total.

<bigpig> davidsarah, when I run a "Run a deep-size operation" on a directory, what should I expect for results?
[...]
<bigpig> after some time, page refresh, and I get "finished: yes\n size: 59767"
<davidsarah> that sounds reasonable
<bigpig> That's probably "unfinished business." I would expect an auto-refreshing page like a check operation gives.

(Note that the existing deep-size produces text results, and can't be changed to auto-refresh without breaking compatibility.)

<davidsarah> deep-size doesn't tell you anything except the total size
[...]
<bigpig_offline> size has no units.
<secorp> you can also do deep-stats which has more information
[...]
<bigpig> secorp, I really just wanted to know the size of the directory and everything in it.
<davidsarah> size is in bytes I think
[...]
<davidsarah> yes, it is documented as being in bytes (webapi.txt, search for 'start-deep-size')
<bigpig> If this is in bytes, I'm in trouble.... or it's not reporting what I'm expecting to see.
<bigpig> Should this tell me the size of the files in the directory, or the size of the *directory* itself?
<davidsarah> "a number (in bytes) containing the sum of the filesize of all directories and immutable files reachable from the given directory"
<bigpig> davidsarah, might want to check that on a directory of your own. 59kb for this directory is not correct.
[...]
<davidsarah> is it too low or too high?
<davidsarah> note that it doesn't include mutable files
<bigpig> two low by three two orders of magnitude.
<bigpig> oh... wait....
<bigpig> "does not include mutable files....."
<bigpig> that's the problem.
<bigpig> No way to get the size of mutable files, huh?
<davidsarah> right. that's a defect
<davidsarah> even if it's a documented one. will check if there's a ticket for it
<bigpig> "defect" or "hard to solve." ;)
<davidsarah> not hard to solve
<davidsarah> but you can get the size of an immutable file from the directory...
<davidsarah> whereas you have to get the size of a mutable file by looking at its current version
<davidsarah> that's probably why it wasn't implemented

A user (Jody Harris) quite reasonably expected the results of a deep-size operation to include mutable files in the total. ``` <bigpig> davidsarah, when I run a "Run a deep-size operation" on a directory, what should I expect for results? [...] <bigpig> after some time, page refresh, and I get "finished: yes\n size: 59767" <davidsarah> that sounds reasonable <bigpig> That's probably "unfinished business." I would expect an auto-refreshing page like a check operation gives. ``` (Note that the existing deep-size produces text results, and can't be changed to auto-refresh without breaking compatibility.) ``` <davidsarah> deep-size doesn't tell you anything except the total size [...] <bigpig_offline> size has no units. <secorp> you can also do deep-stats which has more information [...] <bigpig> secorp, I really just wanted to know the size of the directory and everything in it. <davidsarah> size is in bytes I think [...] <davidsarah> yes, it is documented as being in bytes (webapi.txt, search for 'start-deep-size') <bigpig> If this is in bytes, I'm in trouble.... or it's not reporting what I'm expecting to see. <bigpig> Should this tell me the size of the files in the directory, or the size of the *directory* itself? <davidsarah> "a number (in bytes) containing the sum of the filesize of all directories and immutable files reachable from the given directory" <bigpig> davidsarah, might want to check that on a directory of your own. 59kb for this directory is not correct. [...] <davidsarah> is it too low or too high? <davidsarah> note that it doesn't include mutable files <bigpig> two low by three two orders of magnitude. <bigpig> oh... wait.... <bigpig> "does not include mutable files....." <bigpig> that's the problem. <bigpig> No way to get the size of mutable files, huh? <davidsarah> right. that's a defect <davidsarah> even if it's a documented one. will check if there's a ticket for it <bigpig> "defect" or "hard to solve." ;) <davidsarah> not hard to solve <davidsarah> but you can get the size of an immutable file from the directory... <davidsarah> whereas you have to get the size of a mutable file by looking at its current version <davidsarah> that's probably why it wasn't implemented ```