Message saying that we couldn't find bin/tahoe in test_runner.py should say where we looked #909

New Issue

tahoe-lafs · 2010-01-16T20:42:23Z

davidsarah commented

2010-01-16 20:42:23 +00:00

Several of the tests in source:src/allmydata/test/test_runner.py can be skipped if bin/tahoe isn't found, but it can be time-consuming to diagnose why. The attached message says where we looked for it, and gives a hint as to what might be wrong.

Several of the tests in source:src/allmydata/test/test_runner.py can be skipped if bin/tahoe isn't found, but it can be time-consuming to diagnose why. The attached message says where we looked for it, and gives a hint as to what *might* be wrong.

tahoe-lafs added the

labels 2010-01-16 20:42:23 +00:00

tahoe-lafs added this to the undecided milestone 2010-01-16 20:42:23 +00:00

davidsarah commented

2010-01-16 20:55:37 +00:00

Attachment cannot-find-bin-tahoe.darcspatch.txt (43936 bytes) added

Message saying that we couldn't find bin/tahoe should say where we looked

**Attachment** cannot-find-bin-tahoe.darcspatch.txt (43936 bytes) added Message saying that we couldn't find bin/tahoe should say where we looked

cannot-find-bin-tahoe.darcspatch.txt

43 KiB

davidsarah commented

2010-01-16 20:59:12 +00:00

The patch also factors out some duplicated code.

Note that there's a slight behaviour change for test_baddir -- it uses tahoe start and tahoe stop, so it should be skipped if we can't daemonize. The test was working, but I don't know why and I think it was bogus.

The patch also factors out some duplicated code. Note that there's a slight behaviour change for `test_baddir` -- it uses `tahoe start` and `tahoe stop`, so it should be skipped if we can't daemonize. The test was working, but I don't know why and I think it was bogus.

zooko commented

2010-01-26 04:59:50 +00:00

Looks good, thanks! Applied as changeset:174d3566923a37b5.

zooko added the

fixed

label 2010-01-26 04:59:50 +00:00

zooko closed this issue

2010-01-26 04:59:50 +00:00

zooko modified the milestone from undecided to 1.6.0

2010-01-26 15:04:31 +00:00

Sign in to join this conversation.