Fix 'local variable is assigned to but not used' warnings from pyflakes #900

New Issue

tahoe-lafs · 2010-01-14T04:29:50Z

davidsarah commented

2010-01-14 04:29:50 +00:00

The latest version of pyflakes (0.4.0) gives a bunch of warnings about local variables not being used. Fix them.

(the code was pyflakes-0.3.0 clean, but pyflakes-0.4.0 has new checks)

The latest version of pyflakes (0.4.0) gives a bunch of warnings about local variables not being used. Fix them. (the code was pyflakes-0.3.0 clean, but pyflakes-0.4.0 has new checks)

tahoe-lafs added the

labels 2010-01-14 04:29:50 +00:00

tahoe-lafs added this to the undecided milestone 2010-01-14 04:29:50 +00:00

davidsarah commented

2010-01-14 18:06:25 +00:00

Most of these warnings look harmless. I'm not sure about a few of them -- for example archives_dir starting at source:src/allmydata/scripts/tahoe_backup.py#L106 .

tahoe-lafs added

minor

and removed

major

labels 2010-01-14 18:06:25 +00:00

warner commented

2010-01-14 19:43:46 +00:00

I think that archives_dir stuff is vestigal, from before backupdb started tracking directories (it used to have to find and read the most recent snapshot). It can be removed.

I'll make a pass through these at some point.

I think that archives_dir stuff is vestigal, from before backupdb started tracking directories (it used to have to find and read the most recent snapshot). It can be removed. I'll make a pass through these at some point.

warner commented

2010-01-14 22:34:14 +00:00

changeset:731d15e56f509f9a, changeset:e9223fcd0efd5a5c, and changeset:2e098e2a4ddc66a8 fixes these.. the tree is now pyflakes-0.4.0-clean on my box.

warner added the

fixed

label 2010-01-14 22:34:14 +00:00

warner modified the milestone from undecided to 1.6.0

2010-01-14 22:34:14 +00:00

warner closed this issue

2010-01-14 22:34:14 +00:00

Sign in to join this conversation.