add support for NixOS to iputil #898

New Issue

zooko · 2010-01-13T17:21:23Z

zooko commented

2010-01-13 17:21:23 +00:00

Here is a test failure: http://allmydata.org/buildbot/builders/Ludo%20NixOS-amd64/builds/0/steps/test/logs/stdio

This is because source:src/allmydata/util/iputil.py tries to invoke /sbin/ifconfig but there isn't a file by that name on NixOS.

Ludo has patches this for the NixOS package of Tahoe-LAFS, like this: https://svn.nixos.org/repos/nix/nixpkgs/trunk/pkgs/tools/networking/p2p/tahoe-lafs/default.nix

He says to see the "patchPhase" part of that file.

Here is a test failure: <http://allmydata.org/buildbot/builders/Ludo%20NixOS-amd64/builds/0/steps/test/logs/stdio> This is because source:src/allmydata/util/iputil.py tries to invoke `/sbin/ifconfig` but there isn't a file by that name on NixOS. Ludo has patches this for the NixOS package of Tahoe-LAFS, like this: <https://svn.nixos.org/repos/nix/nixpkgs/trunk/pkgs/tools/networking/p2p/tahoe-lafs/default.nix> He says to see the "patchPhase" part of that file.

zooko added the

labels 2010-01-13 17:21:23 +00:00

zooko added this to the undecided milestone 2010-01-13 17:21:23 +00:00

zooko commented

2010-05-01 19:12:16 +00:00

I don't think ludo is currently planning to work on this ticket, so I'm unassigning it from him. I would personally love to get NixOS which already maintains a package of Tahoe-LAFS (https://svn.nixos.org/repos/nix/nixpkgs/trunk/pkgs/tools/networking/p2p/tahoe-lafs/ ), to be a Supported system. So I would be grateful if someone would look at this issue.

I don't think ludo is currently planning to work on this ticket, so I'm unassigning it from him. I would personally love to get NixOS which already maintains a package of Tahoe-LAFS (<https://svn.nixos.org/repos/nix/nixpkgs/trunk/pkgs/tools/networking/p2p/tahoe-lafs/> ), to be a Supported system. So I would be grateful if someone would look at this issue.

davidsarah commented

2012-03-14 21:10:02 +00:00

The way we currently determine which command to run in iputil is unnecessarily unportable and high-maintenance. In practice all Unices support one of a small number of command syntaxes to get local IP addresses. We should just try all of them whenever the OS is not Windows.

zooko commented

2013-05-27 17:31:19 +00:00

See #1988

Daira Hopwood <david-sarah@jacaranda.org> commented

2013-06-25 18:15:57 +00:00

In /tahoe-lafs/trac-2024-07-25/commit/a493ee0bb641175ecf918e28fce4d25df15994b6:

iputil.py: add tests for recent changes. refs #1381, #1988, #982, #1064, #1536, #1935, #898, #1707, #1918

Signed-off-by: Daira Hopwood <david-sarah@jacaranda.org>

In [/tahoe-lafs/trac-2024-07-25/commit/a493ee0bb641175ecf918e28fce4d25df15994b6](/tahoe-lafs/trac-2024-07-25/commit/a493ee0bb641175ecf918e28fce4d25df15994b6): ``` iputil.py: add tests for recent changes. refs #1381, #1988, #982, #1064, #1536, #1935, #898, #1707, #1918 Signed-off-by: Daira Hopwood <david-sarah@jacaranda.org> ```

daira commented

2013-06-27 01:43:57 +00:00

iputil on trunk no longer distinguishes between Unix variants, which fixes this bug.

tahoe-lafs added the

fixed

label 2013-06-27 01:43:57 +00:00

daira closed this issue

2013-06-27 01:43:57 +00:00

tahoe-lafs modified the milestone from undecided to 1.11.0

2013-06-27 01:44:42 +00:00

Sign in to join this conversation.