blackmatch fuse doesn't know what to think about immutable directories #894

New Issue

zooko · 2010-01-11T00:19:58Z

zooko commented

2010-01-11 00:19:58 +00:00

As reported by François over on comment:73442:

Sat Jan  9 22:25:05 2010: exception:
Traceback (most recent call last):
  File "/home/francois/WORK/dev/tahoe/contrib/fuse/impl_c/blackmatch.py", line 177, in inner_logexc
    ret = meth(self, *args, **kwargs)
  File "/home/francois/WORK/dev/tahoe/contrib/fuse/impl_c/blackmatch.py", line 314, in done
    precondition(not self.read_heap, self.read_heap, self.target_size, self.get_size())
  File "/usr/local/lib/python2.6/dist-packages/allmydata_tahoe-1.5.0_r4054-py2.6.egg/allmydata/util/assertutil.py", line 46, in precondition
    raise AssertionError, "".join(msgbuf)
AssertionError: precondition: [(3832, 0, <Deferred at 0x3c94440>)] <type 'list'>, 264 <type 'int'>, 264 <type 'int'>

As reported by François over on [comment:73442](/tahoe-lafs/trac-2024-07-25/issues/830#issuecomment-73442): ``` Sat Jan 9 22:25:05 2010: exception: Traceback (most recent call last): File "/home/francois/WORK/dev/tahoe/contrib/fuse/impl_c/blackmatch.py", line 177, in inner_logexc ret = meth(self, *args, **kwargs) File "/home/francois/WORK/dev/tahoe/contrib/fuse/impl_c/blackmatch.py", line 314, in done precondition(not self.read_heap, self.read_heap, self.target_size, self.get_size()) File "/usr/local/lib/python2.6/dist-packages/allmydata_tahoe-1.5.0_r4054-py2.6.egg/allmydata/util/assertutil.py", line 46, in precondition raise AssertionError, "".join(msgbuf) AssertionError: precondition: [(3832, 0, <Deferred at 0x3c94440>)] <type 'list'>, 264 <type 'int'>, 264 <type 'int'> ```

zooko added the

labels 2010-01-11 00:19:58 +00:00

zooko added this to the undecided milestone 2010-01-11 00:19:58 +00:00

warner commented

2010-01-11 19:56:46 +00:00

this log fragment isn't very enlightening.. basically all it says is that it wasn't done reading when it should be been done. I see a lot of logging calls in the blackmatch code.. is there perhaps a real Failure logged anywhere? Maybe syslog or something?

Immutable directories have almost exactly the same API as mutable directories, but the blackmatch code has not been updated in forever, so I suspect that there's enough bitrot for the minor differences to cause a problem. I'd suspect something in its use of DirectoryURI: new code should be using less of that and more of client.create_node_from_uri.

this log fragment isn't very enlightening.. basically all it says is that it wasn't done reading when it should be been done. I see a lot of logging calls in the blackmatch code.. is there perhaps a real Failure logged anywhere? Maybe syslog or something? Immutable directories have almost exactly the same API as mutable directories, but the blackmatch code has not been updated in forever, so I suspect that there's enough bitrot for the minor differences to cause a problem. I'd suspect something in its use of `DirectoryURI`: new code should be using less of that and more of `client.create_node_from_uri`.

tahoe-lafs modified the milestone from undecided to 1.7.0

2010-02-01 19:57:39 +00:00

tahoe-lafs modified the milestone from 1.7.0 to 1.6.1

2010-02-15 19:42:28 +00:00

zooko commented

2010-02-22 05:12:35 +00:00

We're not going to finish this for v1.6.1, but hopefully for v1.7.0!

zooko modified the milestone from 1.6.1 to 1.7.0

2010-02-22 05:12:35 +00:00

zooko commented

2010-05-08 19:22:32 +00:00

I don't want to touch the fuse code until we have the fuse tests being automatically run by a CI (buildbot) server. So this ticket is blocked on #621 "Incorporate fuse tests into buildbot flow"

zooko modified the milestone from 1.7.0 to eventually

2010-05-08 19:22:32 +00:00

exarkun commented

2019-07-25 18:20:06 +00:00

This FUSE implementation has been removed (#1409).

exarkun added the

wontfix

label 2019-07-25 18:20:06 +00:00

exarkun closed this issue

2019-07-25 18:20:06 +00:00

Sign in to join this conversation.