contrib/fuse/runtests.py doesn't tolerate deprecations warnings #876

New Issue

Depending on the versions of external libraries such as Twisted of Foolscap,
the tahoe CLI can display deprecation warnings on stdout. The tests should
not interpret those warnings as a failure if the node is in fact correctly
started.

Depending on the versions of external libraries such as Twisted of Foolscap, the tahoe CLI can display deprecation warnings on stdout. The tests should not interpret those warnings as a failure if the node is in fact correctly started.

davidsarah commented

2009-12-30 01:43:29 +00:00

The regexp the patch uses to skip over the warnings is ((.*\n)*)?. Besides the fact that the ? is redundant, shouldn't this only match lines that contain "DeprecationWarning"? That would be (.*DeprecationWarning.*\n)*

The regexp the patch uses to skip over the warnings is `((.*\n)*)?`. Besides the fact that the `?` is redundant, shouldn't this only match lines that contain "DeprecationWarning"? That would be `(.*DeprecationWarning.*\n)*`

francois commented

2009-12-30 13:28:08 +00:00

Yes, you're right about the ? being redundant.

However, the regex you proposed doesn't match the warnings I get here because it contains additional context lines which are not known beforehand.

/home/francois/WORK/dev/tahoe/support/lib/python2.6/site-packages/Twisted-8.2.0-py2.6-linux-i686.egg/twisted/persisted/sob.py:12: DeprecationWarning: the md5 module is deprecated; use hashlib instead
  import os, md5, sys
/home/francois/WORK/dev/tahoe/support/lib/python2.6/site-packages/Twisted-8.2.0-py2.6-linux-i686.egg/twisted/python/filepath.py:12: DeprecationWarning: the sha module is deprecated; use the hashlib module instead
  import sha
/home/francois/WORK/dev/tahoe/support/lib/python2.6/site-packages/foolscap-0.4.2-py2.6.egg/foolscap/banana.py:2: DeprecationWarning: the sets module is deprecated
  import struct, sets, time
/usr/lib/python2.6/dist-packages/formless/annotate.py:730: DeprecationWarning: object.__new__() takes no parameters
  rv = cls = InterfaceClass.__new__(cls, name, bases, dct)
/usr/lib/python2.6/dist-packages/nevow/testutil.py:7: DeprecationWarning: The popen2 module is deprecated.  Use the subprocess module.
  from popen2 import Popen3
STARTING /tmp/tahoe_fuse_test_nWBEII/introducer
introducer node probably started

I'll uploaded an updated version of the patch.

Yes, you're right about the ? being redundant. However, the regex you proposed doesn't match the warnings I get here because it contains additional context lines which are not known beforehand. ``` /home/francois/WORK/dev/tahoe/support/lib/python2.6/site-packages/Twisted-8.2.0-py2.6-linux-i686.egg/twisted/persisted/sob.py:12: DeprecationWarning: the md5 module is deprecated; use hashlib instead import os, md5, sys /home/francois/WORK/dev/tahoe/support/lib/python2.6/site-packages/Twisted-8.2.0-py2.6-linux-i686.egg/twisted/python/filepath.py:12: DeprecationWarning: the sha module is deprecated; use the hashlib module instead import sha /home/francois/WORK/dev/tahoe/support/lib/python2.6/site-packages/foolscap-0.4.2-py2.6.egg/foolscap/banana.py:2: DeprecationWarning: the sets module is deprecated import struct, sets, time /usr/lib/python2.6/dist-packages/formless/annotate.py:730: DeprecationWarning: object.__new__() takes no parameters rv = cls = InterfaceClass.__new__(cls, name, bases, dct) /usr/lib/python2.6/dist-packages/nevow/testutil.py:7: DeprecationWarning: The popen2 module is deprecated. Use the subprocess module. from popen2 import Popen3 STARTING /tmp/tahoe_fuse_test_nWBEII/introducer introducer node probably started ``` I'll uploaded an updated version of the patch.

francois commented

2009-12-30 13:28:22 +00:00

Attachment bug-876.2.dpatch (34092 bytes) added

**Attachment** bug-876.2.dpatch (34092 bytes) added

bug-876.2.dpatch

33 KiB

davidsarah commented

2009-12-30 20:02:26 +00:00

Looks good to me.