Tahoe CLI with unicode patches applied fails when stdout is redirected #734

New Issue

tahoe-lafs · 2009-06-12T08:36:19Z

francois commented

2009-06-12 08:36:19 +00:00

Andrej Falout reported this bug on the mailing-list.

http://allmydata.org/pipermail/tahoe-dev/2009-June/001969.html

andrej@polar:/usr/src/tahoe/darcs/09-06-11_19-00/tahoe> tahoe ls
--node-directory='/home/andrej/.tahoe-allmydata.com/' tahoe:'/' > /dev/null
Traceback (most recent call last):
  File "/usr/src/tahoe/darcs/09-06-11_19-00/tahoe/support/bin/tahoe", line 8, in <module>
    load_entry_point('allmydata-tahoe==1.4.1-r3926', 'console_scripts', 'tahoe')()
  File "/usr/src/tahoe/darcs/09-06-11_19-00/tahoe/src/allmydata/scripts/runner.py", line 91, in run
    rc = runner(sys.argv[1:])
  File "/usr/src/tahoe/darcs/09-06-11_19-00/tahoe/src/allmydata/scripts/runner.py", line 78, in runner
    rc = cli.dispatch[command](so)
  File "/usr/src/tahoe/darcs/09-06-11_19-00/tahoe/src/allmydata/scripts/cli.py", line 385, in list
    rc = tahoe_ls.list(options)
  File "/usr/src/tahoe/darcs/09-06-11_19-00/tahoe/src/allmydata/scripts/tahoe_ls.py", line 125, in list
    line.append(unicode_to_stdout(name) + classify)
  File "/usr/src/tahoe/darcs/09-06-11_19-00/tahoe/src/allmydata/util/stringutils.py", line 70, in unicode_to_stdout
    return s.encode(sys.stdout.encoding, 'replace')
TypeError: encode() argument 1 must be string, not None

andrej@polar:/usr/src/tahoe/darcs/09-06-11_19-00/tahoe> tahoe --version
allmydata-tahoe: 1.4.1-r3926, foolscap: 0.4.1, pycryptopp: 0.5.12, zfec:
1.4.4, Twisted: 8.2.0, Nevow: 0.9.32, zope.interface: 3.5.0, python: 2.6.0,
platform: Linux-SuSE_11.1-x86_64-64bit_ELF, sqlite: 3.6.4, simplejson:
2.0.7, argparse: 0.8.0, pyOpenSSL: 0.7, pyutil: 1.3.30, zbase32: 1.1.1,
setuptools: 0.6c12dev, pysqlite: 2.4.1
andrej@polar:/usr/src/tahoe/darcs/09-06-11_19-00/tahoe>

Andrej Falout reported this bug on the mailing-list. <http://allmydata.org/pipermail/tahoe-dev/2009-June/001969.html> ``` andrej@polar:/usr/src/tahoe/darcs/09-06-11_19-00/tahoe> tahoe ls --node-directory='/home/andrej/.tahoe-allmydata.com/' tahoe:'/' > /dev/null Traceback (most recent call last): File "/usr/src/tahoe/darcs/09-06-11_19-00/tahoe/support/bin/tahoe", line 8, in <module> load_entry_point('allmydata-tahoe==1.4.1-r3926', 'console_scripts', 'tahoe')() File "/usr/src/tahoe/darcs/09-06-11_19-00/tahoe/src/allmydata/scripts/runner.py", line 91, in run rc = runner(sys.argv[1:]) File "/usr/src/tahoe/darcs/09-06-11_19-00/tahoe/src/allmydata/scripts/runner.py", line 78, in runner rc = cli.dispatch[command](so) File "/usr/src/tahoe/darcs/09-06-11_19-00/tahoe/src/allmydata/scripts/cli.py", line 385, in list rc = tahoe_ls.list(options) File "/usr/src/tahoe/darcs/09-06-11_19-00/tahoe/src/allmydata/scripts/tahoe_ls.py", line 125, in list line.append(unicode_to_stdout(name) + classify) File "/usr/src/tahoe/darcs/09-06-11_19-00/tahoe/src/allmydata/util/stringutils.py", line 70, in unicode_to_stdout return s.encode(sys.stdout.encoding, 'replace') TypeError: encode() argument 1 must be string, not None ``` ``` andrej@polar:/usr/src/tahoe/darcs/09-06-11_19-00/tahoe> tahoe --version allmydata-tahoe: 1.4.1-r3926, foolscap: 0.4.1, pycryptopp: 0.5.12, zfec: 1.4.4, Twisted: 8.2.0, Nevow: 0.9.32, zope.interface: 3.5.0, python: 2.6.0, platform: Linux-SuSE_11.1-x86_64-64bit_ELF, sqlite: 3.6.4, simplejson: 2.0.7, argparse: 0.8.0, pyOpenSSL: 0.7, pyutil: 1.3.30, zbase32: 1.1.1, setuptools: 0.6c12dev, pysqlite: 2.4.1 andrej@polar:/usr/src/tahoe/darcs/09-06-11_19-00/tahoe> ```

tahoe-lafs added the

labels 2009-06-12 08:36:19 +00:00

tahoe-lafs added this to the 1.5.0 milestone 2009-06-12 08:36:19 +00:00

zooko modified the milestone from 1.5.0 to eventually

2009-06-30 17:53:46 +00:00

davidsarah commented

2009-12-07 03:57:55 +00:00

Possible fix (untested) in /tahoe-lafs/trac-2024-07-25/issues/5596#comment:79.

Possible fix (untested) in [/tahoe-lafs/trac-2024-07-25/issues/5596](/tahoe-lafs/trac-2024-07-25/issues/5596)#comment:79.

davidsarah commented

2010-02-02 00:19:14 +00:00

Should be same milestone as #534.

tahoe-lafs modified the milestone from eventually to 1.7.0

2010-02-02 00:19:14 +00:00

zooko commented

2010-04-24 04:48:56 +00:00

To test this we can mock out {{sys.stdout}}} to have None for its encoding attribute.

By the way, do we know if having the encoding be None is intended behavior by Python? (It seems like it probably is.)

To test this we can mock out {{sys.stdout}}} to have `None` for its `encoding` attribute. By the way, do we know if having the `encoding` be `None` is intended behavior by Python? (It seems like it probably is.)

zooko commented

2010-05-11 16:04:35 +00:00

I really want to see this patch in trunk in the next 48 hours for Tahoe-LAFS v1.7, but I can't contribute to it myself right now.

davidsarah commented

2010-05-11 19:35:22 +00:00

The patches in #534 to which this ticket applied are probably not now going to be committed; they have been superceded by francois' later patches. I'll take into account the possibility of sys.stdout.encoding being None when reviewing the latter.

The patches in #534 to which this ticket applied are probably not now going to be committed; they have been superceded by francois' later patches. I'll take into account the possibility of `sys.stdout.encoding` being `None` when reviewing the latter.

tahoe-lafs added the

invalid

label 2010-05-11 19:35:22 +00:00

davidsarah closed this issue

2010-05-11 19:35:22 +00:00

Sign in to join this conversation.