declare dependency on sqlite when on py2.4 #728

New Issue

warner · 2009-06-01T23:04:42Z

warner commented

2009-06-01 23:04:42 +00:00

Zooko and I agreed to add a metadata dependency on one of the sqlite bindings
(used by Tahoe's backupdb feature). This means:

code can assume that either the 'sqlite3' or the 'pysqlite2' package will
be importable
(sqlite3 comes with py2.5/py2.6 . pysqlite2 is an add-on, useful for
py2.4)
setuptools must be content with the sqlite3 that comes with py2.5/py2.6.
If python -c "import sqlite3" works, it must not attempt to
download+build pysqlite2 or sqlite3.
My concern here is that the batteries-included sqlite3 module typically
does not include an .egg-info file, and so setuptools might not believe
that it exists.
if this is a problem, then either we don't add the dependency, add it
only when sys.version says 2.4, or try the import before adding the
dependency.

Python2.4 users will have an extra dependency to deal with, which may or may
not be satisfiable automatically. In exchange for this, we can remove the
--no-backupdb option from "tahoe backup". I think we might want to retain the
"here's advice for getting pysqlite" message in the ImportError handler,
because we'll be removing the alternative (running without sqlite and without
a backupdb).

Zooko and I agreed to add a metadata dependency on one of the sqlite bindings (used by Tahoe's backupdb feature). This means: * code can assume that either the 'sqlite3' or the 'pysqlite2' package will be importable * (sqlite3 comes with py2.5/py2.6 . pysqlite2 is an add-on, useful for py2.4) * setuptools must be content with the sqlite3 that comes with py2.5/py2.6. If `python -c "import sqlite3"` works, it must *not* attempt to download+build pysqlite2 or sqlite3. * My concern here is that the batteries-included sqlite3 module typically does not include an .egg-info file, and so setuptools might not believe that it exists. * if this is a problem, then either we don't add the dependency, add it only when sys.version says 2.4, or try the import before adding the dependency. Python2.4 users will have an extra dependency to deal with, which may or may not be satisfiable automatically. In exchange for this, we can remove the --no-backupdb option from "tahoe backup". I think we might want to retain the "here's advice for getting pysqlite" message in the ImportError handler, because we'll be removing the alternative (running without sqlite and without a backupdb).