trailing spaces in filenames break the WUI rename function #631

New Issue

zooko · 2009-02-18T04:47:56Z

zooko commented

2009-02-18 04:47:56 +00:00

I accidentally created a child directory named "darcs executables for ". Then I tried to use the "rename" button to change the name to "darcs executables for Windows". I got this HTML:

<html>
  <head>
    <title>Directory SI=iy5il</title>
    <!-- <link href="http://www.allmydata.com/common/css/styles.css"
          rel="stylesheet" type="text/css"/> -->
    <link href="/webform_css" type="text/css" rel="stylesheet" />
    <link href="/tahoe_css" type="text/css" rel="stylesheet" />
    <meta content="text/html; charset=utf-8" http-equiv="Content-Type" />
  </head>

<body>

<h2>Rename in directory SI=iy5il:</h2>

<div class="freeform-form">
    <form action="." method="post" enctype="multipart/form-data">
        <fieldset>
            <legend class="freeform-form-label">Rename child</legend>
            <input type="hidden" name="t" value="rename" />
            <input type="hidden" name="when_done" value="." />

            Rename child:
            <input readonly="true" type="text" name="from_name" value="darcs executables for " />
            to
            <input type="text" name="to_name" />
            <input type="submit" value="rename" />
        </fieldset>
    </form>
</div>

</body></html>

Entering a new name and clicking "rename" yields the text/plain message:

No such child: darcs executables for

I assume that the trailing newline is being stripped somewhere and causing this problem.

I accidentally created a child directory named "darcs executables for ". Then I tried to use the "rename" button to change the name to "darcs executables for Windows". I got this HTML: ``` <html> <head> <title>Directory SI=iy5il</title>  <link href="/webform_css" type="text/css" rel="stylesheet" /> <link href="/tahoe_css" type="text/css" rel="stylesheet" /> <meta content="text/html; charset=utf-8" http-equiv="Content-Type" /> </head> <body> <h2>Rename in directory SI=iy5il:</h2> <div class="freeform-form"> <form action="." method="post" enctype="multipart/form-data"> <fieldset> <legend class="freeform-form-label">Rename child</legend> <input type="hidden" name="t" value="rename" /> <input type="hidden" name="when_done" value="." /> Rename child: <input readonly="true" type="text" name="from_name" value="darcs executables for " /> to <input type="text" name="to_name" /> <input type="submit" value="rename" /> </fieldset> </form> </div> </body></html> ``` Entering a new name and clicking "rename" yields the text/plain message: ``` No such child: darcs executables for ``` I assume that the trailing newline is being stripped somewhere and causing this problem.