add a 'repair' button on the webapi checker results page #622

New Issue

warner · 2009-02-11T20:42:57Z

warner commented

2009-02-11 20:42:57 +00:00

The "Repair" button appears when the checker results indicate an unhealthy file. But the target URL that it points at is wrong, so clicking on it doesn't do anything.

warner added the

labels 2009-02-11 20:42:57 +00:00

zooko commented

2009-04-09 23:12:45 +00:00

I'm going to find and comment-out the Repair button on the check-results-page for 1.4.0, then move this ticket ahead to Milestone 1.4.1. If someone else comments-out that button or otherwise fixes this before I get around to that (likely late tonight or tomorrow morning) then that's cool.

warner commented

2009-04-09 23:49:25 +00:00

I'll get it.

warner commented

2009-04-10 21:32:32 +00:00

code patched.. the button is commented out.

I think the bug might be related to files vs directories: the URL of the check-results page will look like FILECAP?t=check for files, and DIRCAP/?t=check for directories, so the relative link to the repair URL needs to be different (FILECAP?t=check&repair=true for files, and just ?t=check&repair=true for directories). Or, we should point directly at /uri/CAP?t=check for both, instead of trying to use a relative link. Well, except that we always want some kind of relative link, otherwise things break when you've got a proxy in front of the webapi server.

code patched.. the button is commented out. I think the bug might be related to files vs directories: the URL of the check-results page will look like `FILECAP?t=check` for files, and `DIRCAP/?t=check` for directories, so the relative link to the repair URL needs to be different (`FILECAP?t=check&repair=true` for files, and just `?t=check&repair=true` for directories). Or, we should point directly at `/uri/CAP?t=check` for both, instead of trying to use a relative link. Well, except that we always want some kind of relative link, otherwise things break when you've got a proxy in front of the webapi server.

zooko commented

2009-04-11 14:01:57 +00:00

The button is comment out, and I'm moving this ticket to Milestone 1.4.1.

zooko added this to the 1.4.1 milestone 2009-04-11 14:01:57 +00:00

zooko modified the milestone from 1.6.0 to eventually

2010-01-26 15:41:36 +00:00

tahoe-lafs modified the milestone from eventually to 1.7.0

2010-02-11 01:27:06 +00:00

tahoe-lafs modified the milestone from 1.7.0 to 1.6.1

2010-02-15 19:54:34 +00:00

zooko commented

2010-02-16 05:21:41 +00:00

I think this is a new feature rather than a bugfix (since the button is absent, rather than broken, in v1.6.0).

zooko modified the milestone from 1.6.1 to 1.7.0

2010-02-16 05:21:41 +00:00

zooko changed title from ~~'repair' button on the webapi checker results page doesn't work~~ to add a 'repair' button on the webapi checker results page

2010-02-16 05:21:41 +00:00

zooko modified the milestone from 1.7.0 to eventually

2010-06-18 23:48:21 +00:00

tahoe-lafs modified the milestone from eventually to 1.11.0

2014-09-27 03:15:58 +00:00

daira commented

2014-09-27 13:44:02 +00:00

1.11 is frozen for work on new tickets, but please feel free to work on this for 1.12.

tahoe-lafs added

enhancement

and removed

defect

labels 2014-09-27 13:44:02 +00:00

tahoe-lafs modified the milestone from 1.11.0 to 1.12.0

2014-09-27 13:44:02 +00:00

Lcstyle commented

2014-10-01 02:09:55 +00:00

Since this is the only "major" priority issue I've assigned to myself, I've decided to work on it next. Since 1382 is hopefully making it into 1.11 (and part of 1382 is of course: "Extend servers of happiness to file check, verify, and repair operations;"), it would be nice to have this repair button work properly. I've found the original diff here:
https://github.com/tahoe-lafs/tahoe-lafs/commit/54952e9beacdbe20590221341f89b3b2246aa9bc#diff-0595565110d5f14254df062f4b0e3726

It'd be nice to have some additional color on this issue before I begin, if any can be provided by anyone?

Since this is the only "major" priority issue I've assigned to myself, I've decided to work on it next. Since 1382 is hopefully making it into 1.11 (and part of 1382 is of course: "Extend servers of happiness to file check, verify, and repair operations;"), it would be nice to have this repair button work properly. I've found the original diff here: <https://github.com/tahoe-lafs/tahoe-lafs/commit/54952e9beacdbe20590221341f89b3b2246aa9bc#diff-0595565110d5f14254df062f4b0e3726> It'd be nice to have some additional color on this issue before I begin, if any can be provided by anyone?

daira commented

2014-10-02 01:06:45 +00:00

I would suggest undoing [54952e9beacdbe20590221341f89b3b2246aa9bc] on a branch, then adding a test that checks the HTML for whether the button submit URL is correct (once you've worked out what it should be).