premature abort of upload if some shares were already present and some servers fail #608

New Issue

zooko · 2009-02-07T20:16:15Z

zooko commented

2009-02-07 20:16:15 +00:00

There is logic in source:src/allmydata/immutable/encode.py@20090107034822-92b7f-4b8bbe1a2c1bf374154bc1cd32ff8040e998ca00#L474 to abort an upload if there aren't enough remaining shareholders. This fails to take into account that some shares might already have been present on servers before this upload began. So for example if M=10, and there were 5 shares present on servers when you started, and shares_of_happiness is 7, then you'll be talking to 5 landlords, and if one of them disconnects you should not then give up on the whole upload, per this line:

        if len(self.landlords) < self.shares_of_happiness:
            msg = "lost too many shareholders during upload: %s" % why

To test this, the test needs to create a file with 10 shares, delete 5 of them, start an upload, and then arrange it that during the upload 3 of the servers fail -- the upload should proceed normally (since share_of_happiness is 7). Also test what happens when 4 of them fail -- the upload should stop immediately.

There is logic in source:src/allmydata/immutable/encode.py@20090107034822-92b7f-4b8bbe1a2c1bf374154bc1cd32ff8040e998ca00#L474 to abort an upload if there aren't enough remaining shareholders. This fails to take into account that some shares might already have been present on servers before this upload began. So for example if M=10, and there were 5 shares present on servers when you started, and shares_of_happiness is 7, then you'll be talking to 5 landlords, and if one of them disconnects you should not then give up on the whole upload, per this line: ``` if len(self.landlords) < self.shares_of_happiness: msg = "lost too many shareholders during upload: %s" % why ``` To test this, the test needs to create a file with 10 shares, delete 5 of them, start an upload, and then arrange it that during the upload 3 of the servers fail -- the upload should proceed normally (since share_of_happiness is 7). Also test what happens when 4 of them fail -- the upload should stop immediately.

zooko added the

labels 2009-02-07 20:16:15 +00:00

zooko added this to the 1.3.0 milestone 2009-02-07 20:16:15 +00:00

zooko commented

2009-02-08 01:08:30 +00:00

Eh, this doesn't have to be fixed for tahoe-1.3.0.

zooko removed this from the 1.3.0 milestone 2009-02-08 01:08:30 +00:00

zooko commented

2009-02-09 18:24:23 +00:00

I'm going to add cc: tahoe-dev to this ticket, and then I'm going to post the original contents of this ticket to tahoe-dev along with a link to this ticket.