SFTP frontend needs tests #531

New Issue

warner · 2008-11-03T21:45:30Z

warner commented

2008-11-03 21:45:30 +00:00

It would be nice to have an SFTP front end (the encrypted kind that's a part of the ssh protocol, as opposed to the unencrypted old protocol covered in #512). In particular, there is a good fuse-based 'sshfs' layer that works well on OS-X.

warner added the

labels 2008-11-03 21:45:30 +00:00

warner added this to the undecided milestone 2008-11-03 21:45:30 +00:00

zooko commented

2010-02-06 04:15:00 +00:00

Ed Pimentl and Jack Lloyd are offering bounties for SFTP: http://allmydata.org/pipermail/tahoe-dev/2010-February/003807.html

Ed Pimentl and Jack Lloyd are offering bounties for SFTP: <http://allmydata.org/pipermail/tahoe-dev/2010-February/003807.html>

zooko commented

2010-02-06 04:20:49 +00:00

Brian implemented an SFTP server in Tahoe-LAFS fifteen months ago: http://allmydata.org/trac/tahoe/browser/src/allmydata/frontends/sftpd.py

But it lacks tests. There is an open issue against it: #645 (connecting to sftp frontend using sshfs fails from linux client). Alberto Berti contributed a patch to fix this issue but his patch allegedly causes a different issue. Since there aren't tests I couldn't tell what to do with this situation and left Alberto's patch out of trunk pending someone writing tests for the two alleged issues.

Brian implemented an SFTP server in Tahoe-LAFS fifteen months ago: <http://allmydata.org/trac/tahoe/browser/src/allmydata/frontends/sftpd.py> But it lacks tests. There is an open issue against it: #645 (connecting to sftp frontend using sshfs fails from linux client). Alberto Berti contributed a patch to fix this issue but his patch allegedly causes a different issue. Since there aren't tests I couldn't tell what to do with this situation and left Alberto's patch out of trunk pending someone writing tests for the two alleged issues.

tahoe-lafs added

defect

and removed

enhancement

labels 2010-02-07 16:13:05 +00:00

tahoe-lafs modified the milestone from undecided to 1.7.0

2010-02-07 16:13:05 +00:00

tahoe-lafs changed title from ~~SFTP frontend~~ to SFTP frontend needs tests

2010-02-07 16:13:05 +00:00

davidsarah commented

2010-05-12 06:13:30 +00:00

Attachment test_sftp.py (44673 bytes) added

Tests for new SFTP implementation

**Attachment** test_sftp.py (44673 bytes) added Tests for new SFTP implementation

test_sftp.py

44 KiB

davidsarah commented

2010-05-12 06:18:21 +00:00

Attachment sftp-all-darcspatch.txt (118301 bytes) added

All patches needed for new SFTP implementation and tests

**Attachment** sftp-all-darcspatch.txt (118301 bytes) added All patches needed for new SFTP implementation and tests

sftp-all-darcspatch.txt

116 KiB

davidsarah commented

2010-05-12 06:21:38 +00:00

Attachment shouldFail-darcspatch.txt (6473 bytes) added

Change shouldFail to avoid Unicode errors when converting Failure to str. (This patch is included in sftp-all-darcspatch.txt but is easier to review as a separate file.)

**Attachment** shouldFail-darcspatch.txt (6473 bytes) added Change shouldFail to avoid Unicode errors when converting Failure to str. (This patch is included in sftp-all-darcspatch.txt but is easier to review as a separate file.)

shouldFail-darcspatch.txt

6.3 KiB

zooko commented

2010-05-18 21:03:23 +00:00

Further work on this is on #1037.

zooko added the

duplicate

label 2010-05-18 21:03:23 +00:00

zooko closed this issue

2010-05-18 21:03:23 +00:00

Sign in to join this conversation.