Fix the cli_options.stdout pattern #4048

New Issue

exarkun · 2023-07-20T18:18:23Z

exarkun commented

2023-07-20 18:18:23 +00:00

In tor_provider and i2p_provider, https://github.com/tahoe-lafs/tahoe-lafs/pull/1283 introduced a couple type ignore comments to suppress the mypy error now present in those places due to new type annotations. The error complains about Options having no stdout attribute. It's true the type doesn't generally, but runner.py puts one there.

Instead of dynamically adding extra attributes to Options, the code should either pass stdout (and stderr I think?) separately or introduce a new type specifically for representing an options value and some more stuff.

In tor_provider and i2p_provider, <https://github.com/tahoe-lafs/tahoe-lafs/pull/1283> introduced a couple type ignore comments to suppress the mypy error now present in those places due to new type annotations. The error complains about `Options` having no `stdout` attribute. It's true the type doesn't generally, but `runner.py` puts one there. Instead of dynamically adding extra attributes to `Options`, the code should either pass stdout (and stderr I think?) separately or introduce a new type specifically for representing an options value and some more stuff.

Fix the cli_options.stdout pattern #4048

Fix the `cli_options.stdout` pattern #4048