The list of NURLs in announcements should be a set #4046

New Issue

itamarst · 2023-07-11T22:03:58Z

itamarst commented

2023-07-11 22:03:58 +00:00

In storage_client.py there is logic to decide if an announcement is worth paying attention to, by comparing it to the old known announcement. NURLs might end up in a different order, but that is not a semantic difference. So this suggests NURLs should be sent as a set.

In `storage_client.py` there is logic to decide if an announcement is worth paying attention to, by comparing it to the old known announcement. NURLs might end up in a different order, but that is not a semantic difference. So this suggests NURLs should be sent as a set.

itamarst added the

labels 2023-07-11 22:03:58 +00:00

itamarst added this to the HTTP Storage Protocol milestone 2023-07-11 22:03:58 +00:00

GitHub <noreply@github.com> commented

2023-07-20 15:46:00 +00:00

In f7f30c78/trunk:

Merge pull request #1315 from tahoe-lafs/4046.nurls-are-set

Make NURLs a set

Fixes ticket:4046

In [f7f30c78/trunk](/tahoe-lafs/trac-2024-07-25/commit/f7f30c78b727c6d4e799e5bb2634d3cfdf9af2a4): ``` Merge pull request #1315 from tahoe-lafs/4046.nurls-are-set Make NURLs a set Fixes ticket:4046 ```