fix zfec to install under 2.4 #4

New Issue

zooko · 2007-04-26T17:17:15Z

zooko commented

2007-04-26 17:17:15 +00:00

fix zfec to install under 2.4 (the relative ..util in cmdline.zfec breaks byte-compilation)

"cmdline" isn't used by tahoe, so maybe I can configure GNUmakefile to configure setup.py to not try to compile cmdline.

> * fix zfec to install under 2.4 (the relative ..util in cmdline.zfec breaks byte-compilation) "cmdline" isn't used by tahoe, so maybe I can configure GNUmakefile to configure setup.py to not try to compile cmdline.

zooko added the

blocker

defect

labels 2007-04-26 17:17:15 +00:00

zooko added this to the 0.2.0 milestone 2007-04-26 17:17:15 +00:00

zooko self-assigned this 2007-04-26 17:17:15 +00:00

warner commented

2007-04-26 18:09:28 +00:00

the zfec setup.py will need to refrain from putting the cmdline/*.py modules into any generated distributions (like the 'install' target), because it's the deban package's post-install script that tries to byte-compile every .py in the bundle and fails on the 2.5-only syntax

To retain the 2.5-only relative imports, you might have setup.py do something like:

packages = ['zfec', 'zfec.util', 'zfec.test']
if sys.version_info[0:2] >= (2.5):
   packages += ['zfec.cmdline']

setup(
...
    package=packages,
...
)

Or, by renaming cmdline/zfec.py to something that doesn't overlap with the top-level zfec/ package (say cmdline_zfec.py), you could use absolute imports and make even the command-line tools work under 2.4.

the zfec setup.py will need to refrain from putting the cmdline/*.py modules into any generated distributions (like the 'install' target), because it's the deban package's post-install script that tries to byte-compile every .py in the bundle and fails on the 2.5-only syntax To retain the 2.5-only relative imports, you might have setup.py do something like: ``` packages = ['zfec', 'zfec.util', 'zfec.test'] if sys.version_info[0:2] >= (2.5): packages += ['zfec.cmdline'] setup( ... package=packages, ... ) ``` Or, by renaming cmdline/zfec.py to something that doesn't overlap with the top-level zfec/ package (say cmdline_zfec.py), you could use absolute imports and make even the command-line tools work under 2.4.