webapi download with ?filename= should not log filename #385

Closed
opened 2008-04-15 02:23:16 +00:00 by warner · 1 comment

I noticed today that our log-sanitizing is failing to remove the filenames specified as query arguments from the web hits that we log. This is closely related to #221 (give proper filenames on download).
I think that if we make the download links use a filename as the last component of the URL (rather than in a query arg), then that will resolve this issue easily.

I noticed today that our log-sanitizing is failing to remove the filenames specified as query arguments from the web hits that we log. This is closely related to #221 (give proper filenames on download). I think that if we make the download links use a filename as the last component of the URL (rather than in a query arg), then that will resolve this issue easily.
warner added the
code-frontend-web
major
defect
1.0.0
labels 2008-04-15 02:23:16 +00:00
warner added this to the eventually milestone 2008-04-15 02:23:16 +00:00
tahoe-lafs modified the milestone from eventually to 1.7.0 2010-02-27 08:42:09 +00:00
zooko modified the milestone from 1.7.0 to soon 2010-05-30 21:35:17 +00:00
tahoe-lafs modified the milestone from soon to 1.11.0 2012-09-06 15:21:43 +00:00
daira commented 2013-05-13 01:01:42 +00:00
Owner

Special case of #1904.

Special case of #1904.
tahoe-lafs added the
duplicate
label 2013-05-13 01:01:42 +00:00
daira closed this issue 2013-05-13 01:01:42 +00:00
Sign in to join this conversation.
No Milestone
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Reference: tahoe-lafs/trac-2024-07-25#385
No description provided.