Add integration tests for file get and put variations, especially stdin/stdout #3715

New Issue

itamarst · 2021-05-13T15:03:48Z

itamarst commented

2021-05-13 15:03:48 +00:00

Unicode vs. bytes is one of the harder parts of the port.
Unit testing stdin/stdout interactions is likely to be quite fragile, given both quite different semantics on Python 2 and 3, and need to emulate things like stdin/stdout.

As such, integration tests of tahoe get and tahoe put with (a) binary files and (b) stdin/stdout usage seems like a good idea, even with nominally good unit test coverage.

1. Unicode vs. bytes is one of the harder parts of the port. 2. Unit testing stdin/stdout interactions is likely to be quite fragile, given both quite different semantics on Python 2 and 3, and need to emulate things like stdin/stdout. As such, integration tests of `tahoe get` and `tahoe put` with (a) binary files and (b) stdin/stdout usage seems like a good idea, even with nominally good unit test coverage.

itamarst added the

labels 2021-05-13 15:03:48 +00:00

itamarst added this to the Support Python 3 milestone 2021-05-13 15:03:48 +00:00

itamarst self-assigned this 2021-05-13 15:03:48 +00:00

itamarst commented

2021-05-21 15:24:56 +00:00

Python has a pipes module, but it does the stupid thing on Python 3 where it assumes unicode files. So going to do it manually.

GitHub <noreply@github.com> commented

2021-05-24 13:15:35 +00:00

In 05a1349/trunk:

Merge pull request #1066 from tahoe-lafs/3715-get-put-integration-tests

CLI get/put integration tests.

Fixes ticket:3715

In [05a1349/trunk](/tahoe-lafs/trac-2024-07-25/commit/05a13499ad7209bd258cf61a88973c59bad6f859): ``` Merge pull request #1066 from tahoe-lafs/3715-get-put-integration-tests CLI get/put integration tests. Fixes ticket:3715 ```

tahoe-lafs added the

fixed

label 2021-05-24 13:15:35 +00:00

tahoe-lafs closed this issue

2021-05-24 13:15:35 +00:00

Sign in to join this conversation.