Take stock of Python 3 port #3643

New Issue

chadwhitacre · 2021-03-20T23:20:07Z

chadwhitacre commented

2021-03-20 23:20:07 +00:00

How much do we have left to do?

chadwhitacre added the

labels 2021-03-20 23:20:07 +00:00

chadwhitacre added this to the Support Python 3 milestone 2021-03-20 23:20:07 +00:00

exarkun commented

2021-03-22 11:51:26 +00:00

There's a report in the test suite:

$ trial allmydata.test.test_python3
allmydata.test.test_python3
  Python3PortingEffortTests
    test_finished_porting ...                                            [TODO]
    test_ported_modules_distinct ...                                       [OK]
    test_ported_modules_exist ...                                          [OK]

===============================================================================
[TODO]
Reason: 'https://tahoe-lafs.org/trac/tahoe-lafs/milestone/Support%20Python%203 should be completed'
Traceback (most recent call last):
  File "/home/exarkun/Work/python/tahoe-lafs/src/allmydata/test/test_python3.py", line 43, in test_finished_porting
    ported_names,
  File "/home/exarkun/VirtualEnvs/tahoe-lafs/lib/python2.7/site-packages/twisted/trial/_synctest.py", line 434, in assertEqual
    super(_Assertions, self).assertEqual(first, second, msg)
  File "/nix/store/knrv5c2qzbxrr7f6hp5xj9zgcig36j3w-python-2.7.17/lib/python2.7/unittest/case.py", line 513, in assertEqual
    assertion_func(first, second, msg=msg)
  File "/nix/store/knrv5c2qzbxrr7f6hp5xj9zgcig36j3w-python-2.7.17/lib/python2.7/unittest/case.py", line 797, in assertSetEqual
    self.fail(self._formatMessage(msg, standardMsg))
twisted.trial.unittest.FailTest: Some unported modules remain: 
Ported files: 195 / 283
Ported lines: 78666 / 95524


allmydata.test.test_python3.Python3PortingEffortTests.test_finished_porting
-------------------------------------------------------------------------------
Ran 3 tests in 1.041s

There's a report in the test suite: ``` $ trial allmydata.test.test_python3 allmydata.test.test_python3 Python3PortingEffortTests test_finished_porting ... [TODO] test_ported_modules_distinct ... [OK] test_ported_modules_exist ... [OK] =============================================================================== [TODO] Reason: 'https://tahoe-lafs.org/trac/tahoe-lafs/milestone/Support%20Python%203 should be completed' Traceback (most recent call last): File "/home/exarkun/Work/python/tahoe-lafs/src/allmydata/test/test_python3.py", line 43, in test_finished_porting ported_names, File "/home/exarkun/VirtualEnvs/tahoe-lafs/lib/python2.7/site-packages/twisted/trial/_synctest.py", line 434, in assertEqual super(_Assertions, self).assertEqual(first, second, msg) File "/nix/store/knrv5c2qzbxrr7f6hp5xj9zgcig36j3w-python-2.7.17/lib/python2.7/unittest/case.py", line 513, in assertEqual assertion_func(first, second, msg=msg) File "/nix/store/knrv5c2qzbxrr7f6hp5xj9zgcig36j3w-python-2.7.17/lib/python2.7/unittest/case.py", line 797, in assertSetEqual self.fail(self._formatMessage(msg, standardMsg)) twisted.trial.unittest.FailTest: Some unported modules remain: Ported files: 195 / 283 Ported lines: 78666 / 95524 allmydata.test.test_python3.Python3PortingEffortTests.test_finished_porting ------------------------------------------------------------------------------- Ran 3 tests in 1.041s ```